Commit graph

52 commits

Author SHA1 Message Date
Felipe Borges
4fa6852cdc online-accounts: Present all supported providers at once
Instead of having the "more" button which reveals more items to the
providers list.

We still list branded providers above non-branded providers in the
list.

Fixes #1072
2021-04-08 12:34:44 +00:00
Adrien Plazas
f06379e30c Replace HdyColumn by HdyClamp
In libhandy 1, HdyClamp replaces HdyColumn. This stops setting values
when they match HdyClamp's defaults.
2020-07-20 08:04:28 +02:00
Robert Ancell
ece1911f40 online-accounts: Replace GtkStack child names with widget references
The child names are easier to break if widgets are changed - this can't be
detected by the compiler.
2020-03-30 02:13:43 +00:00
Jeremy Bicha
a9d6ed149b online-accounts: Set label relationship for listboxes
Set the label relationships so that screen readers
read the headers for the listboxes.
2019-01-10 11:53:00 +00:00
Adrien Plazas
851cdc8eb3 online-accounts: Wrap the header label
This will help the window to fit narrow screens.
2018-11-29 00:48:16 +00:00
Adrien Plazas
0d901e086d online-accounts: Remove a hardcoded minimum width
This will help the window to fit narrow screens.
2018-11-29 00:48:16 +00:00
Adrien Plazas
8c92368e7c online-accounts: Use a HdyColumn
This better adapts the panel's size to the window's size, allowing it to
look good on both large and narrow windows.
2018-11-29 00:48:16 +00:00
Allan Day
8a8e53ab8a Standardize vertical spacing of panels
Ensure that the vertical spacing inside each panel is similar.
This makes the transition between each panel smoother and makes
the control center feel more cohesive.

Settings panels are given 32px above and below their content
and 32px vertical space between major sections. 12px space is
placed below headings.

Bluetooth, displays and printers are not addressed.

https://bugzilla.gnome.org/show_bug.cgi?id=786384
2017-08-20 18:38:42 +02:00
Debarshi Ray
ebdaa85ba4 online-accounts: Increase the spacing above the "Remove Account" button
https://bugzilla.gnome.org/show_bug.cgi?id=779368
2017-05-31 16:38:16 +02:00
Georges Basile Stavracas Neto
e63accbf82 online-accounts: Move the margins and spacing lower down the hierarchy
The expired credentials GtkButton is going to be replaced with a
GtkInfoBar touching the top, start and end edges of the GtkDialog.
Therefore, the margins around the account details and GtkSwitches
cannot be set on the higher level GtkBoxes. Instead, they need to be
set lower down the hierarchy closer to the actual widgets that need
them.

Bump required GOA version for the new goa_provider_show_account
behaviour.

https://bugzilla.gnome.org/show_bug.cgi?id=779368
2017-05-30 17:06:44 +02:00
Piotr Drąg
55b31ba967 online-accounts: Fix grammar in a new string
Since there weren’t any translation updates yet, fix grammar
in the newly added string — “setup” is a noun, “set up” is the verb.
2017-02-23 05:36:09 +01:00
Georges Basile Stavracas Neto
bd527d44c1 online-accounts: Improve dialog content margins
More alignment issues.
2017-02-22 23:13:00 -03:00
Allan Day
2e6d07cb01 online-accounts: Fix account dialog layout
More spacing needed everywhere. This is a partial fix - some other
adjustments are necessary.
2017-02-22 23:12:57 -03:00
Allan Day
432d55b30e online-accounts: Improve panel layout
Ensure sufficient spacing within and around rows. Increase panel
height to make it easier to view the list.
2017-02-22 23:12:52 -03:00
Georges Basile Stavracas Neto
4662c5be58 online-accounts: Make the account editor box vertical
When credentials expire, they're being added horizontally since
this is the default value of the GtkOrientable:orientation property.

Fix that by making the account editor box vertical, and adding some
spacing.

https://bugzilla.gnome.org/show_bug.cgi?id=774222
2017-02-22 23:00:49 -03:00
Georges Basile Stavracas Neto
fa81d1679a online-accounts: Only show the accounts list when there are accounts
When the user has no account set, the current implementation of the
Online Accounts panel shows a weird 1px line that is the empty list.

Fix that by only showing the list when there are accounts available.

https://bugzilla.gnome.org/show_bug.cgi?id=774222
2017-02-22 23:00:49 -03:00
Georges Basile Stavracas Neto
1594d8c7a1 online-accounts: Align the panel widgets in the middle
The current implementation of the Online Accounts panel allows
2 states: either the widgets of the panel fill the whole horizontal
space, or they shrink and fill only the absolutely minimum. The
ideal solution, however, is to make them grow with the panel.

Fix that by turn the main box into a GtkGrid, and adding stub widgets
that expand horizontally and pull the main widgets to the middle,
allowing them to cover at most 1/3 of the screen. The widgets themselves
are inside a GtkBox, so that hiding them automatically removes the
spacing in between.

https://bugzilla.gnome.org/show_bug.cgi?id=774222
2017-02-22 23:00:49 -03:00
Georges Basile Stavracas Neto
1e580c679b online-accounts: Add an offline message label
When offline, we currently block the new accounts listbox
so that users can't add new accounts. There is, however,
no visual indication that we're offline, besides the listbox.

Fix that by adding a descriptive label that's only visible
when offline.

https://bugzilla.gnome.org/show_bug.cgi?id=774222
2017-02-22 23:00:49 -03:00
Georges Basile Stavracas Neto
e9198bdb4d online-accounts: Add a bottom row to display non-branded providers
As per the mockups, and mimicking the dialog behavior, add a bottom
row that shows non-branded providers.

https://bugzilla.gnome.org/show_bug.cgi?id=774222
2017-02-22 23:00:49 -03:00
Georges Basile Stavracas Neto
1f1f2e2b1f online-accounts: Always keep editor dialog size the minimum
When adding and editing accounts, the different options that Online
Accounts provides may require different sizes of the dialog. There is,
however, a specific issue where the dialog can't resize because a
provider widget is interefering with the others.

Fix that by making the dialog's stack non-homogeneous, and making sure
to always reset the dialog size before showing it.

https://bugzilla.gnome.org/show_bug.cgi?id=774222
2017-02-17 17:19:45 +01:00
Georges Basile Stavracas Neto
7d852bfab0 online-accounts: Small UI improvement
Add more margin to the lists.

https://bugzilla.gnome.org/show_bug.cgi?id=774222
2017-02-13 14:56:31 +01:00
Georges Basile Stavracas Neto
14d0988208 online-accounts: Bring back account removal
Following the previous commit, this commit effectively brings
back the account removal feature that was temporarily removed
by 4e197b491f.

This is now reimplemented as an in-app notification, and users
now have the option to undo an accidentally removed account.

Some changes by Debarshi Ray.

https://bugzilla.gnome.org/show_bug.cgi?id=774222
2017-02-13 14:37:08 +01:00
Georges Basile Stavracas Neto
20216c09f9 online-accounts: Add a remove button to the account dialog
After temporarily removing the ability to delete accounts in
4e197b491f, let's start bringing it back again by adding a Remove
Account button to the account editor dialog, as per the recent mockups.

https://bugzilla.gnome.org/show_bug.cgi?id=774222
2017-02-08 18:28:00 +01:00
Georges Basile Stavracas Neto
4f1e27e3ba online-accounts: Explicitly remove the dialog's border width
Looks like Gtk+ assumes all dialogs' internal-vbox widgets have a
2px border, so explicitly set it to 0.

https://bugzilla.gnome.org/show_bug.cgi?id=774222
2017-02-08 17:33:46 +01:00
Georges Basile Stavracas Neto
d50a07da56 online-accounts: Make adding an account inline to the edit dialog
When adding an account, the old proccess was: use the (removed) toolbar
to open the New Account dialog, select a provider in that dialog, add
the account and see the newly created account in the panel itself.

That approach had issues, e.g. the user would have to close the dialog
if she mistakenly selected a provider. After moving the provider list
to the panel itself, it doesn't make sense anymore to have another
provider list inside the dialog.

Fix this by moving the new account view to the accounts dialog.

https://bugzilla.gnome.org/show_bug.cgi?id=774222
2017-02-08 17:33:46 +01:00
Georges Basile Stavracas Neto
76062e1106 online-accounts: Add a stack to the account dialog
This will be used to unify the account creation proccess and the
account editor.

https://bugzilla.gnome.org/show_bug.cgi?id=774222
2017-01-03 18:50:23 +01:00
Georges Basile Stavracas Neto
dce3e168d2 online-accounts: Remove unused widgets
These widgets are not used anymore, and they're not present in the
latest designs.

https://bugzilla.gnome.org/show_bug.cgi?id=774222
2017-01-03 18:36:41 +01:00
Georges Basile Stavracas Neto
c26f8ae018 online-accounts: Add a providers listbox to the panel
This commit starts moving the contents of the add account dialog
class to the panel itself, by adding a providers listbox below
the list of available account as per the new mockups. As a side effect,
this commit temporarily makes removing an account non-functional.

The next commits are focused on finishing this move and removing
the add account dialog.

https://bugzilla.gnome.org/show_bug.cgi?id=774222
2017-01-03 17:52:07 +01:00
Georges Basile Stavracas Neto
7117f63718 online-accounts: Make the entire panel scrollable
The current implementation of the Online Accounts panel allows only
the account list to scroll. To prepare ouselves for the future
changes, let's make the entire panel scrollable.

https://bugzilla.gnome.org/show_bug.cgi?id=774222
2017-01-03 17:03:49 +01:00
Georges Basile Stavracas Neto
d925774a88 online-accounts: Remove unused 'id'
https://bugzilla.gnome.org/show_bug.cgi?id=774222
2017-01-03 17:00:52 +01:00
Georges Basile Stavracas Neto
be9687ce94 online-accounts: Simplify setting the margin
https://bugzilla.gnome.org/show_bug.cgi?id=774222
2017-01-03 15:03:18 +01:00
Georges Basile Stavracas Neto
8b56b9d1d8 online-accounts: Add a header label as per the latest mockups
https://bugzilla.gnome.org/show_bug.cgi?id=774222
2017-01-03 15:00:04 +01:00
Georges Basile Stavracas Neto
4e197b491f online-accounts: Make the main listbox non-selectable
Instead of selecting an account, this commit makes the account
editor dialog only visible through explicit activation of the
account row.

As a side effect, this commit temporarily makes removing an
account non-functional.

https://bugzilla.gnome.org/show_bug.cgi?id=774222
2016-12-15 19:40:28 +01:00
Georges Basile Stavracas Neto
1a427a8ac3 online-accounts: Use a dialog to manage the online account
Following the mockups, the Online Accounts panel shall use a modal
dialog to edit online accounts.

This commit moves the current widgets to a dialog, and shows this
dialog whenever an account is selected.

Some changes by Debarshi Ray.

https://bugzilla.gnome.org/show_bug.cgi?id=774222
2016-12-15 17:51:59 +01:00
Georges Basile Stavracas Neto
54df308648 online-accounts: Use the ui file to connect to signals
Simplify the code by using the GtkBuilder file to connect to the
signals instead of manually doing it in the code.

https://bugzilla.gnome.org/show_bug.cgi?id=774222
2016-11-30 17:23:10 +01:00
Georges Basile Stavracas Neto
bdde40ac15 online-accounts: Use a listbox instead of a treeview
As part of the port to the redesigned Online Accounts panel,
the main widget to be displayed is a GtkListBox, so we can have
finer control of the UI elements and eventually be able to put
real widgets instead of using cell renderers.

This commit, then, makes the Online Account panel use a listbox
widget in the sidebar. The behavior of the panel was not changed.

Since its using a listbox now, we can drop the custom GoaPanelAccountsModel
class.

https://bugzilla.gnome.org/show_bug.cgi?id=774222
2016-11-30 17:16:35 +01:00
Georges Basile Stavracas Neto
902ab4e448 online-accounts: Turn into a template class
https://bugzilla.gnome.org/show_bug.cgi?id=774222
2016-11-30 17:16:35 +01:00
Debarshi Ray
d45f093fbf online-accounts: Widen the accounts list
https://bugzilla.gnome.org/show_bug.cgi?id=746538
2015-04-13 15:05:40 +02:00
Arnaud Bonatti
eb6a9c656a online-accounts: Increase the height of the panel
https://bugzilla.gnome.org/show_bug.cgi?id=732636
2014-07-22 11:58:33 +02:00
Volker Sobek
f4dcf9984e online-accounts: Set max width in chars for label
Set a limit of 40 chars to the label explaining the panel when no
accounts have been added yet. This prevents the label from expanding
itself and the whole window arbitrarily.

https://bugzilla.gnome.org/show_bug.cgi?id=720188
2014-03-03 10:51:11 +01:00
Yosef Or Boczko
6e8a7e942f online-accounts: Use margin-start/end instead of margin-left/right
https://bugzilla.gnome.org/show_bug.cgi?id=712661
2013-11-19 22:30:42 +02:00
Rui Matos
9288bbbffc online-accounts: Remove unused toplevel window from .ui file
https://bugzilla.gnome.org/show_bug.cgi?id=708286
2013-10-01 10:05:03 +02:00
Jonh Wendell
88bdd191a3 online-accounts: proper align the 'No accounts' label
use the default label align, "FILL", instead of "CENTER". this
fixes some issues in languages like zh_TW.

https://bugzilla.gnome.org/show_bug.cgi?id=705354
2013-08-02 13:38:31 -03:00
Ebru Akagunduz
f2818405ab online-accounts: Nicer error states
https://bugzilla.gnome.org/show_bug.cgi?id=689645
2013-02-27 17:27:34 +01:00
Matthias Clasen
3d27d8caaf shell: Fittsify panels
Make it possible for panels to go all the way to the edge of the
shell. This is particularly important for panels that scroll, such
as the new power panel. All other panels are changed to compensate
for the loss of external padding.

https://bugzilla.gnome.org/show_bug.cgi?id=691229
2013-01-07 10:51:29 +01:00
Debarshi Ray
9b26f2410a online-accounts: Align the accounts list with the all settings button
Fixes: https://bugzilla.gnome.org/668312
2012-11-10 18:42:01 +01:00
Debarshi Ray
8138227ae3 online-accounts: Improve the layout when there is no configured account
Use a GtkButton instead of a GtkLabel to incite the user to configure
a new account, and insensitize the GtkBox on the left.

Fixes: https://bugzilla.gnome.org/672421
2012-06-25 16:18:39 +02:00
Debarshi Ray
c920ba6d4f online-accounts: The treeview should be in BROWSE mode and not SINGLE
This ensures that if there are configured accounts, then atleast one
of them will stay selected.

Fixes: https://bugzilla.gnome.org/672421
2012-06-21 14:48:51 +02:00
Debarshi Ray
f86d8eb26c online-accounts: Remove horizontal scrolling from accounts list
We have enough space. Therefore, instead of having horizontal
scrollbars, widen the text renderer and then ellipsize, if required.

Implemented design:
https://live.gnome.org/Design/SystemSettings/OnlineAccounts

Fixes: https://bugzilla.gnome.org/671980
2012-06-06 14:24:31 +02:00
Bastien Nocera
ce58a78d26 online-accounts: Add label to toolbar items 2011-10-25 17:38:55 +01:00