0f18a662be
In the ubuntu 20.04, we met an issue about the output volume-slider on the machine with the legacy HDA audio driver, the output device is the Speaker first (analog-stereo pa sink), then we connect a hdmi monitor, the HDMI audio is in the output combo-box, we select the hdmi audio (hdmi-stereo pa sink) from the combo-box, the hdmi audio becomes the active output device now, we adjust the output volume from the volume-slider, the slider UI is changed, but the output sound is not changed with the UI. The root cause is when the speaker is active, the pulseaudio only keeps the analog-stereo sink, the sink hdmi-stereo is unlinked, when users select the hdmi audio from UI, the pulseaudio will unlink analo-stereo sink and create hdmi-stereo sink, but before hdmi-stereo is created, the output_device_changed_cb() is called and gvc_mixer_control_get_stream_from_device() returns a NULL since the hdmi-stereo sink is not created yet in the pulseaudio. Because stream is NULL, the output_volume_slider->stream is NULL, users can't change the output volume via the volume-slider. To fix it, we add a output_volume_slider->stream check in the device_update_cb(), if it is NULL, get the stream and set it to volume-slider. In this function, the sink hdmi-stereo is created already, so the stream is not NULL. And this change also applies to input as well. Signed-off-by: Hui Wang <hui.wang@canonical.com> |
||
|---|---|---|
| .gitlab/issue_templates | ||
| build-aux | ||
| data/icons | ||
| docs | ||
| gettext/its | ||
| man | ||
| panels | ||
| po | ||
| search-provider | ||
| shell | ||
| subprojects | ||
| tests | ||
| .gitignore | ||
| .gitlab-ci.yml | ||
| .gitmodules | ||
| COPYING | ||
| gnome-control-center.doap | ||
| meson.build | ||
| meson_options.txt | ||
| NEWS | ||
| README.md | ||
GNOME Settings
GNOME Settings is GNOME's main interface for configuration of various aspects of your desktop.
Contributing
See docs/CONTRIBUTING.md for details on the contribution process, and docs/HACKING.md
for the coding style guidelines.
Reporting Bugs
Before reporting any bugs or opening feature requests, read the communication guidelines.
Bugs should be reported to the GNOME bug tracking system under the product gnome-control-center. It is available at GitLab Issues.
In the report please include the following information:
- Operating system and version
- For Linux, version of the C library
- Exact error message
- Steps to reproduce the bug
- If the bug is a visual defect, attach a screenshot
- If the bug is a crash, attach a backtrace if possible [see below]
How to get a backtrace
If the crash is reproducible, follow the steps to obtain a backtrace:
Install debug symbols for gnome-control-center.
Run the program in gdb [the GNU debugger] or any other debugger.
gdb gnome-control-center
Start the program.
(gdb) run
Reproduce the crash and when the program exits to (gdb) prompt, get the backtrace.
(gdb) bt full
Once you have the backtrace, copy and paste it into the 'Comments' field or attach it as a file to the bug report.
Testing Unstable Settings
It is quite easy to test and give feedback about the development version of GNOME Settings. Just access https://gitlab.gnome.org/GNOME/gnome-control-center/environments, get the latest version, download it, double-click the file, install and run.
Note that GNOME Settings Flatpak will only work if you are running the latest GNOME version in your host system.