0f18a662be
In the ubuntu 20.04, we met an issue about the output volume-slider on the machine with the legacy HDA audio driver, the output device is the Speaker first (analog-stereo pa sink), then we connect a hdmi monitor, the HDMI audio is in the output combo-box, we select the hdmi audio (hdmi-stereo pa sink) from the combo-box, the hdmi audio becomes the active output device now, we adjust the output volume from the volume-slider, the slider UI is changed, but the output sound is not changed with the UI. The root cause is when the speaker is active, the pulseaudio only keeps the analog-stereo sink, the sink hdmi-stereo is unlinked, when users select the hdmi audio from UI, the pulseaudio will unlink analo-stereo sink and create hdmi-stereo sink, but before hdmi-stereo is created, the output_device_changed_cb() is called and gvc_mixer_control_get_stream_from_device() returns a NULL since the hdmi-stereo sink is not created yet in the pulseaudio. Because stream is NULL, the output_volume_slider->stream is NULL, users can't change the output volume via the volume-slider. To fix it, we add a output_volume_slider->stream check in the device_update_cb(), if it is NULL, get the stream and set it to volume-slider. In this function, the sink hdmi-stereo is created already, so the stream is not NULL. And this change also applies to input as well. Signed-off-by: Hui Wang <hui.wang@canonical.com>
45 lines
1.6 KiB
C
45 lines
1.6 KiB
C
/* -*- Mode: C; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 8 -*-
|
|
*
|
|
* Copyright (C) 2018 Canonical Ltd.
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public License as
|
|
* published by the Free Software Foundation; either version 2 of the
|
|
* License, or (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful, but
|
|
* WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* Lesser General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program; if not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include <gtk/gtk.h>
|
|
#include <pulse/pulseaudio.h>
|
|
#include <gvc-mixer-control.h>
|
|
#include <gvc-mixer-stream.h>
|
|
|
|
#include "cc-sound-enums.h"
|
|
|
|
G_BEGIN_DECLS
|
|
|
|
#define CC_TYPE_VOLUME_SLIDER (cc_volume_slider_get_type ())
|
|
G_DECLARE_FINAL_TYPE (CcVolumeSlider, cc_volume_slider, CC, VOLUME_SLIDER, GtkBox)
|
|
|
|
void cc_volume_slider_set_mixer_control (CcVolumeSlider *slider,
|
|
GvcMixerControl *mixer_control);
|
|
|
|
void cc_volume_slider_set_stream (CcVolumeSlider *slider,
|
|
GvcMixerStream *stream,
|
|
CcStreamType type);
|
|
|
|
void cc_volume_slider_set_is_amplified (CcVolumeSlider *slider,
|
|
gboolean is_amplified);
|
|
|
|
GvcMixerStream *cc_volume_slider_get_stream (CcVolumeSlider *slider);
|
|
|
|
G_END_DECLS
|