A fork of Gnome-control-center with some tweaks
Find a file
Michael Catanzaro 3f6737dbf7 network: fix criticals when updating connection
If the operation is cancelled (because the dialog was closed, because
the Apply button was pressed), then trying to make further use of the
source_object is a use after free, which is bad. At first I tried to fix
this by simply avoiding the use after free when the operation is
canceled, but then I realized it is ridiculous to always try committing
connection changes when closing the dialog, then immediately cancel the
operation by destroying the dialog.

So instead I've decided to not pass the cancellable along to these
operations, and instead ref the dialog to keep it alive until the
operations complete. Instead, let's just hide the window.

This commit also removes an inaccurate comment /* Leave the editor open
*/ placed right before the call to the function that hides the editor.
There's no need to leave the editor open when updating the device fails.
The connection properties at least are still saved.

Fixes #2618
2023-08-30 08:44:55 +00:00
.gitlab/issue_templates README, gitlab: Simplifly README file 2023-08-15 13:24:26 +02:00
build-aux build-aux: Fix flatpak build manifest 2023-03-28 08:01:25 +00:00
data/icons icon: Remove circle outside of drawing area 2022-01-01 18:26:49 +00:00
docs Rename HACKING.md to the more standard CODING_STYLE.md 2022-11-15 13:15:07 +00:00
gettext/its build: Fix translation context missing from keyboard entries 2018-01-24 20:43:34 +01:00
man Updating "info" to "info-overview" in man page 2020-03-15 08:07:51 +00:00
panels network: fix criticals when updating connection 2023-08-30 08:44:55 +00:00
po Update Indonesian translation 2023-08-30 07:06:54 +00:00
search-provider search-provider: Connect signal handlers in swapped form 2023-06-07 09:14:28 +12:00
shell window: Null check panel before embedding its sidebar widget 2023-08-28 08:19:45 +00:00
subprojects subprojects: Update gvc 2023-07-29 09:09:23 +00:00
tests build: Require setxkbmap in tests/keyboard 2023-08-25 09:13:26 +00:00
.gitignore gitignore: Add flatpak-builder directory to .gitignore 2023-03-28 07:53:40 +00:00
.gitlab-ci.yml ci: Use JUnit reports from Meson 2023-08-23 23:56:41 +02:00
.gitmodules Switch to GTK4 & libadwaita 2021-12-14 22:34:21 -03:00
COPYING build: Update COPYING with new mailing address 2012-08-22 15:33:18 +01:00
gnome-control-center.doap doap: Mark my responsibilities as simply "General" 2023-08-16 16:27:17 +02:00
meson.build Post-release version bump 2023-08-25 11:47:03 +02:00
meson_options.txt log: Improve logging 2022-12-01 11:44:17 +00:00
NEWS 45.rc 2023-08-25 11:39:43 +02:00
README.md README, gitlab: Simplifly README file 2023-08-15 13:24:26 +02:00

Build Status Coverage report License

GNOME Settings

GNOME Settings is GNOME's main interface for configuration of various aspects of your desktop.

If you are looking for usage tips and instructions, you can find it at the User Documentation (translated in various languages).

Reporting Issues

Before reporting any bugs or opening feature requests, read the communication guidelines.

Report issues to the GNOME issue tracking system.

Feature Requests

For feature requests or conceptual changes, please start a topic on GNOME Discourse.

Contributing

See docs/CONTRIBUTING.md for details on the contribution process, and docs/CODING_STYLE.md for the coding style guidelines.

Visit the Settings development wiki for more information.