A fork of Gnome-control-center with some tweaks
If the operation is cancelled (because the dialog was closed, because the Apply button was pressed), then trying to make further use of the source_object is a use after free, which is bad. At first I tried to fix this by simply avoiding the use after free when the operation is canceled, but then I realized it is ridiculous to always try committing connection changes when closing the dialog, then immediately cancel the operation by destroying the dialog. So instead I've decided to not pass the cancellable along to these operations, and instead ref the dialog to keep it alive until the operations complete. Instead, let's just hide the window. This commit also removes an inaccurate comment /* Leave the editor open */ placed right before the call to the function that hides the editor. There's no need to leave the editor open when updating the device fails. The connection properties at least are still saved. Fixes #2618 |
||
---|---|---|
.gitlab/issue_templates | ||
build-aux | ||
data/icons | ||
docs | ||
gettext/its | ||
man | ||
panels | ||
po | ||
search-provider | ||
shell | ||
subprojects | ||
tests | ||
.gitignore | ||
.gitlab-ci.yml | ||
.gitmodules | ||
COPYING | ||
gnome-control-center.doap | ||
meson.build | ||
meson_options.txt | ||
NEWS | ||
README.md |
GNOME Settings
GNOME Settings is GNOME's main interface for configuration of various aspects of your desktop.
If you are looking for usage tips and instructions, you can find it at the User Documentation (translated in various languages).
Reporting Issues
Before reporting any bugs or opening feature requests, read the communication guidelines.
Report issues to the GNOME issue tracking system.
Feature Requests
For feature requests or conceptual changes, please start a topic on GNOME Discourse.
Contributing
See docs/CONTRIBUTING.md
for details on the contribution process, and docs/CODING_STYLE.md
for the coding style guidelines.
Visit the Settings development wiki for more information.