62db29b387
When a configuration setting is wrong, set the entry or file chooser that contains the incorrect information to be surrounded by red. This makes it easier for users to find where the error was made that disallows them to click the "Apply" button. https://bugzilla.gnome.org/show_bug.cgi?id=734446
234 lines
9 KiB
C
234 lines
9 KiB
C
/* -*- Mode: C; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 8 -*-
|
|
*
|
|
* Copyright (C) 2012 Red Hat, Inc
|
|
*
|
|
* Licensed under the GNU General Public License Version 2
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program; if not, write to the Free Software
|
|
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
|
|
*/
|
|
|
|
#include "config.h"
|
|
|
|
#include <glib-object.h>
|
|
#include <glib/gi18n.h>
|
|
|
|
#include <nm-utils.h>
|
|
#include <nm-device-ethernet.h>
|
|
|
|
#include <net/if_arp.h>
|
|
|
|
#include "firewall-helpers.h"
|
|
#include "ce-page-ethernet.h"
|
|
#include "ui-helpers.h"
|
|
|
|
G_DEFINE_TYPE (CEPageEthernet, ce_page_ethernet, CE_TYPE_PAGE)
|
|
|
|
static void
|
|
all_user_changed (GtkToggleButton *b, CEPageEthernet *page)
|
|
{
|
|
gboolean all_users;
|
|
NMSettingConnection *sc;
|
|
|
|
sc = nm_connection_get_setting_connection (CE_PAGE (page)->connection);
|
|
all_users = gtk_toggle_button_get_active (b);
|
|
|
|
g_object_set (sc, "permissions", NULL, NULL);
|
|
if (!all_users)
|
|
nm_setting_connection_add_permission (sc, "user", g_get_user_name (), NULL);
|
|
}
|
|
|
|
static void
|
|
mtu_changed (GtkSpinButton *mtu, CEPageEthernet *page)
|
|
{
|
|
if (gtk_spin_button_get_value_as_int (mtu) == 0)
|
|
gtk_widget_hide (page->mtu_label);
|
|
else
|
|
gtk_widget_show (page->mtu_label);
|
|
}
|
|
|
|
static void
|
|
connect_ethernet_page (CEPageEthernet *page)
|
|
{
|
|
NMSettingWired *setting = page->setting_wired;
|
|
NMSettingConnection *sc;
|
|
int mtu_def;
|
|
char **mac_list;
|
|
const GByteArray *s_mac;
|
|
char *s_mac_str;
|
|
GtkWidget *widget;
|
|
const gchar *name;
|
|
|
|
name = nm_setting_connection_get_id (page->setting_connection);
|
|
gtk_entry_set_text (page->name, name);
|
|
|
|
/* Device MAC address */
|
|
mac_list = ce_page_get_mac_list (CE_PAGE (page)->client, NM_TYPE_DEVICE_ETHERNET,
|
|
NM_DEVICE_ETHERNET_PERMANENT_HW_ADDRESS);
|
|
s_mac = nm_setting_wired_get_mac_address (setting);
|
|
s_mac_str = s_mac ? nm_utils_hwaddr_ntoa (s_mac->data, ARPHRD_ETHER) : NULL;
|
|
ce_page_setup_mac_combo (page->device_mac, s_mac_str, mac_list);
|
|
g_free (s_mac_str);
|
|
g_strfreev (mac_list);
|
|
g_signal_connect_swapped (page->device_mac, "changed", G_CALLBACK (ce_page_changed), page);
|
|
|
|
/* Cloned MAC address */
|
|
ce_page_mac_to_entry (nm_setting_wired_get_cloned_mac_address (setting),
|
|
ARPHRD_ETHER, page->cloned_mac);
|
|
g_signal_connect_swapped (page->cloned_mac, "changed", G_CALLBACK (ce_page_changed), page);
|
|
|
|
/* MTU */
|
|
mtu_def = ce_get_property_default (NM_SETTING (setting), NM_SETTING_WIRED_MTU);
|
|
g_signal_connect (page->mtu, "output",
|
|
G_CALLBACK (ce_spin_output_with_default),
|
|
GINT_TO_POINTER (mtu_def));
|
|
gtk_spin_button_set_value (page->mtu, (gdouble) nm_setting_wired_get_mtu (setting));
|
|
g_signal_connect (page->mtu, "value-changed",
|
|
G_CALLBACK (mtu_changed), page);
|
|
mtu_changed (page->mtu, page);
|
|
|
|
g_signal_connect_swapped (page->name, "changed", G_CALLBACK (ce_page_changed), page);
|
|
g_signal_connect_swapped (page->mtu, "value-changed", G_CALLBACK (ce_page_changed), page);
|
|
|
|
widget = GTK_WIDGET (gtk_builder_get_object (CE_PAGE (page)->builder,
|
|
"auto_connect_check"));
|
|
sc = nm_connection_get_setting_connection (CE_PAGE (page)->connection);
|
|
g_object_bind_property (sc, "autoconnect",
|
|
widget, "active",
|
|
G_BINDING_BIDIRECTIONAL | G_BINDING_SYNC_CREATE);
|
|
g_signal_connect_swapped (widget, "toggled", G_CALLBACK (ce_page_changed), page);
|
|
|
|
widget = GTK_WIDGET (gtk_builder_get_object (CE_PAGE (page)->builder,
|
|
"all_user_check"));
|
|
gtk_toggle_button_set_active (GTK_TOGGLE_BUTTON (widget),
|
|
nm_setting_connection_get_num_permissions (sc) == 0);
|
|
g_signal_connect (widget, "toggled",
|
|
G_CALLBACK (all_user_changed), page);
|
|
g_signal_connect_swapped (widget, "toggled", G_CALLBACK (ce_page_changed), page);
|
|
|
|
widget = GTK_WIDGET (gtk_builder_get_object (CE_PAGE (page)->builder, "combo_zone"));
|
|
firewall_ui_setup (sc, widget, CE_PAGE (page)->cancellable);
|
|
g_signal_connect_swapped (widget, "changed", G_CALLBACK (ce_page_changed), page);
|
|
|
|
}
|
|
|
|
static void
|
|
ui_to_setting (CEPageEthernet *page)
|
|
{
|
|
GByteArray *device_mac = NULL;
|
|
GByteArray *cloned_mac = NULL;
|
|
GtkWidget *entry;
|
|
|
|
entry = gtk_bin_get_child (GTK_BIN (page->device_mac));
|
|
if (entry)
|
|
device_mac = ce_page_entry_to_mac (GTK_ENTRY (entry), ARPHRD_ETHER, NULL);
|
|
cloned_mac = ce_page_entry_to_mac (page->cloned_mac, ARPHRD_ETHER, NULL);
|
|
|
|
g_object_set (page->setting_wired,
|
|
NM_SETTING_WIRED_MAC_ADDRESS, device_mac,
|
|
NM_SETTING_WIRED_CLONED_MAC_ADDRESS, cloned_mac,
|
|
NM_SETTING_WIRED_MTU, (guint32) gtk_spin_button_get_value_as_int (page->mtu),
|
|
NULL);
|
|
|
|
if (device_mac)
|
|
g_byte_array_free (device_mac, TRUE);
|
|
if (cloned_mac)
|
|
g_byte_array_free (cloned_mac, TRUE);
|
|
|
|
g_object_set (page->setting_connection,
|
|
NM_SETTING_CONNECTION_ID, gtk_entry_get_text (page->name),
|
|
NULL);
|
|
|
|
entry = GTK_WIDGET (gtk_builder_get_object (CE_PAGE (page)->builder, "combo_zone"));
|
|
firewall_ui_to_setting (page->setting_connection, entry);
|
|
|
|
}
|
|
|
|
static gboolean
|
|
validate (CEPage *page,
|
|
NMConnection *connection,
|
|
GError **error)
|
|
{
|
|
CEPageEthernet *self = CE_PAGE_ETHERNET (page);
|
|
gboolean invalid = FALSE;
|
|
GByteArray *ignore;
|
|
GtkWidget *entry;
|
|
|
|
entry = gtk_bin_get_child (GTK_BIN (self->device_mac));
|
|
if (entry) {
|
|
ignore = ce_page_entry_to_mac (GTK_ENTRY (entry), ARPHRD_ETHER, &invalid);
|
|
if (invalid) {
|
|
widget_set_error (entry);
|
|
return FALSE;
|
|
}
|
|
if (ignore)
|
|
g_byte_array_free (ignore, TRUE);
|
|
widget_unset_error (entry);
|
|
}
|
|
|
|
ignore = ce_page_entry_to_mac (self->cloned_mac, ARPHRD_ETHER, &invalid);
|
|
if (invalid) {
|
|
widget_set_error (GTK_WIDGET (self->cloned_mac));
|
|
return FALSE;
|
|
}
|
|
if (ignore)
|
|
g_byte_array_free (ignore, TRUE);
|
|
widget_unset_error (GTK_WIDGET (self->cloned_mac));
|
|
|
|
ui_to_setting (self);
|
|
|
|
return nm_setting_verify (NM_SETTING (self->setting_connection), NULL, error) &&
|
|
nm_setting_verify (NM_SETTING (self->setting_wired), NULL, error);
|
|
}
|
|
|
|
static void
|
|
ce_page_ethernet_init (CEPageEthernet *page)
|
|
{
|
|
}
|
|
|
|
static void
|
|
ce_page_ethernet_class_init (CEPageEthernetClass *class)
|
|
{
|
|
CEPageClass *page_class= CE_PAGE_CLASS (class);
|
|
|
|
page_class->validate = validate;
|
|
}
|
|
|
|
CEPage *
|
|
ce_page_ethernet_new (NMConnection *connection,
|
|
NMClient *client,
|
|
NMRemoteSettings *settings)
|
|
{
|
|
CEPageEthernet *page;
|
|
|
|
page = CE_PAGE_ETHERNET (ce_page_new (CE_TYPE_PAGE_ETHERNET,
|
|
connection,
|
|
client,
|
|
settings,
|
|
"/org/gnome/control-center/network/ethernet-page.ui",
|
|
_("Identity")));
|
|
|
|
page->name = GTK_ENTRY (gtk_builder_get_object (CE_PAGE (page)->builder, "entry_name"));
|
|
page->device_mac = GTK_COMBO_BOX_TEXT (gtk_builder_get_object (CE_PAGE (page)->builder, "combo_mac"));
|
|
page->cloned_mac = GTK_ENTRY (gtk_builder_get_object (CE_PAGE (page)->builder, "entry_cloned_mac"));
|
|
page->mtu = GTK_SPIN_BUTTON (gtk_builder_get_object (CE_PAGE (page)->builder, "spin_mtu"));
|
|
page->mtu_label = GTK_WIDGET (gtk_builder_get_object (CE_PAGE (page)->builder, "label_mtu"));
|
|
|
|
page->setting_connection = nm_connection_get_setting_connection (connection);
|
|
page->setting_wired = nm_connection_get_setting_wired (connection);
|
|
|
|
connect_ethernet_page (page);
|
|
|
|
return CE_PAGE (page);
|
|
}
|