a2b9620b1b
Hooking to all the toggled signals from all the buttons for executing the same action is inneficient, and can potenticall end up in a segmentation fault due to some race in the signal emmission, where the active button gets deactivated before the clicked button is activated Looking at the GTK4 code, in a radio group: - The button which was previously active gets de-activated, emitting its corresponding toggled signal. - The active property for the clicked button gets set. - The clicked button emits its toggled signal. Therefore, if the first toggle signal gets processed before the active property is set, there can be a race condition. We are seeing this downstream at pmOS: https://gitlab.com/postmarketOS/pmaports/-/issues/1816 Instead of this racy behavior, follow upstream recommendation and keep track of the state through a stateful signal. |
||
|---|---|---|
| .gitlab/issue_templates | ||
| build-aux | ||
| data/icons | ||
| docs | ||
| gettext/its | ||
| man | ||
| panels | ||
| po | ||
| search-provider | ||
| shell | ||
| subprojects | ||
| tests | ||
| .gitignore | ||
| .gitlab-ci.yml | ||
| .gitmodules | ||
| COPYING | ||
| gnome-control-center.doap | ||
| meson.build | ||
| meson_options.txt | ||
| NEWS | ||
| README.md | ||
GNOME Settings
GNOME Settings is GNOME's main interface for configuration of various aspects of your desktop.
Contributing
See docs/CONTRIBUTING.md for details on the contribution process, and docs/CODING_STYLE.md
for the coding style guidelines.
Reporting Bugs
Before reporting any bugs or opening feature requests, read the communication guidelines.
Bugs should be reported to the GNOME bug tracking system under the product gnome-control-center. It is available at GitLab Issues.
In the report please include the following information:
- Operating system and version
- For Linux, version of the C library
- Exact error message
- Steps to reproduce the bug
- If the bug is a visual defect, attach a screenshot
- If the bug is a crash, attach a backtrace if possible [see below]
How to get a backtrace
If the crash is reproducible, follow the steps to obtain a backtrace:
Install debug symbols for gnome-control-center.
Run the program in gdb [the GNU debugger] or any other debugger.
gdb gnome-control-center
Start the program.
(gdb) run
Reproduce the crash and when the program exits to (gdb) prompt, get the backtrace.
(gdb) bt full
Once you have the backtrace, copy and paste it into the 'Comments' field or attach it as a file to the bug report.
Testing Unstable Settings
It is quite easy to test and give feedback about the development version of GNOME Settings. Just access https://gitlab.gnome.org/GNOME/gnome-control-center/environments, get the latest version, download it, double-click the file, install and run.
Note that GNOME Settings Flatpak will only work if you are running the latest GNOME version in your host system.