81c1bf437c
We pass to the setter a const char* but we don't control the ownership of that and it may be returned later from the property getter. While this is not causing any crash right now, going in the inspector and try to check the property leads to some scrambled chars which seems an indication of a memory error. In general the string passed to these APIs could come from anywhere and it's not guaranteed that it's always a constant string (and in fact is not in some cases).
162 lines
4.9 KiB
C
162 lines
4.9 KiB
C
/* cc-illustrated-row.c
|
|
*
|
|
* Copyright 2018 Purism SPC
|
|
* 2021 Georges Basile Stavracas Neto <georges.stavracas@gmail.com>
|
|
* 2023 Red Hat, Inc
|
|
*
|
|
* This program is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation, either version 3 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*
|
|
* SPDX-License-Identifier: GPL-3.0-or-later
|
|
*/
|
|
|
|
#include "cc-illustrated-row.h"
|
|
|
|
struct _CcIllustratedRow
|
|
{
|
|
CcVerticalRow parent;
|
|
|
|
GtkBox *picture_box;
|
|
GtkPicture *picture;
|
|
gchar *resource_path;
|
|
|
|
GtkMediaStream *media_stream;
|
|
};
|
|
|
|
G_DEFINE_FINAL_TYPE (CcIllustratedRow, cc_illustrated_row, CC_TYPE_VERTICAL_ROW);
|
|
|
|
enum
|
|
{
|
|
PROP_0,
|
|
PROP_RESOURCE,
|
|
N_PROPS,
|
|
};
|
|
|
|
static GParamSpec *props[N_PROPS] = { NULL, };
|
|
|
|
static void
|
|
on_picture_leave_cb (CcIllustratedRow *self)
|
|
{
|
|
GtkMediaStream *stream = GTK_MEDIA_STREAM (gtk_picture_get_paintable (self->picture));
|
|
|
|
gtk_media_stream_set_loop (stream, FALSE);
|
|
gtk_media_stream_pause (stream);
|
|
}
|
|
|
|
static void
|
|
on_picture_hover_cb (CcIllustratedRow *self)
|
|
{
|
|
GtkMediaStream *stream = GTK_MEDIA_STREAM (gtk_picture_get_paintable (self->picture));
|
|
|
|
gtk_media_stream_set_loop (stream, TRUE);
|
|
gtk_media_stream_play (stream);
|
|
}
|
|
|
|
static void
|
|
cc_illustrated_row_get_property (GObject *object,
|
|
guint prop_id,
|
|
GValue *value,
|
|
GParamSpec *pspec)
|
|
{
|
|
CcIllustratedRow *self = CC_ILLUSTRATED_ROW (object);
|
|
|
|
switch (prop_id)
|
|
{
|
|
case PROP_RESOURCE:
|
|
g_value_set_string (value, self->resource_path);
|
|
break;
|
|
default:
|
|
G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);
|
|
}
|
|
}
|
|
|
|
static void
|
|
cc_illustrated_row_set_property (GObject *object,
|
|
guint prop_id,
|
|
const GValue *value,
|
|
GParamSpec *pspec)
|
|
{
|
|
CcIllustratedRow *self = CC_ILLUSTRATED_ROW (object);
|
|
|
|
switch (prop_id)
|
|
{
|
|
case PROP_RESOURCE:
|
|
cc_illustrated_row_set_resource (self, g_value_get_string (value));
|
|
break;
|
|
default:
|
|
G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);
|
|
}
|
|
}
|
|
|
|
static void
|
|
cc_illustrated_row_finalize (GObject *object)
|
|
{
|
|
CcIllustratedRow *self = CC_ILLUSTRATED_ROW (object);
|
|
|
|
g_clear_pointer (&self->resource_path, g_free);
|
|
G_OBJECT_CLASS (cc_illustrated_row_parent_class)->finalize (object);
|
|
}
|
|
|
|
static void
|
|
cc_illustrated_row_class_init (CcIllustratedRowClass *klass)
|
|
{
|
|
GObjectClass *object_class = G_OBJECT_CLASS (klass);
|
|
GtkWidgetClass *widget_class = GTK_WIDGET_CLASS (klass);
|
|
|
|
object_class->get_property = cc_illustrated_row_get_property;
|
|
object_class->set_property = cc_illustrated_row_set_property;
|
|
object_class->finalize = cc_illustrated_row_finalize;
|
|
|
|
props[PROP_RESOURCE] =
|
|
g_param_spec_string ("resource",
|
|
"Resource",
|
|
"Resource",
|
|
"",
|
|
G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS | G_PARAM_EXPLICIT_NOTIFY);
|
|
|
|
g_object_class_install_properties (object_class, N_PROPS, props);
|
|
|
|
gtk_widget_class_set_template_from_resource (widget_class, "/org/gnome/control-center/common/cc-illustrated-row.ui");
|
|
|
|
gtk_widget_class_bind_template_child (widget_class, CcIllustratedRow, picture);
|
|
gtk_widget_class_bind_template_child (widget_class, CcIllustratedRow, picture_box);
|
|
|
|
gtk_widget_class_bind_template_callback (widget_class, on_picture_hover_cb);
|
|
gtk_widget_class_bind_template_callback (widget_class, on_picture_leave_cb);
|
|
}
|
|
|
|
static void
|
|
cc_illustrated_row_init (CcIllustratedRow *self)
|
|
{
|
|
gtk_widget_init_template (GTK_WIDGET (self));
|
|
}
|
|
|
|
void
|
|
cc_illustrated_row_set_resource (CcIllustratedRow *self,
|
|
const gchar *resource_path)
|
|
{
|
|
g_return_if_fail (CC_IS_ILLUSTRATED_ROW (self));
|
|
|
|
if (self->media_stream != NULL)
|
|
g_clear_object (&self->media_stream);
|
|
|
|
g_set_str (&self->resource_path, resource_path);
|
|
self->media_stream = gtk_media_file_new_for_resource (self->resource_path);
|
|
|
|
gtk_picture_set_paintable (self->picture, GDK_PAINTABLE (self->media_stream));
|
|
gtk_widget_set_visible (GTK_WIDGET (self->picture_box),
|
|
self->resource_path != NULL &&
|
|
g_strcmp0 (self->resource_path, "") != 0);
|
|
|
|
g_object_notify_by_pspec (G_OBJECT (self), props[PROP_RESOURCE]);
|
|
}
|