applications/gnome-control-center
3
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
gnome-control-center/panels/network/connection-editor
History
Pablo Correa Gómez a2b9620b1b network: keep track of radio buttons in connection editor with action 
Hooking to all the toggled signals from all the buttons for executing
the same action is inneficient, and can potenticall end up in a segmentation
 fault due to some race in the signal emmission, where the active button
 gets deactivated before the clicked button is activated

Looking at the GTK4 code, in a radio group:

- The button which was previously active gets de-activated, emitting its
corresponding toggled signal.
- The active property for the clicked button gets set.
- The clicked button emits its toggled signal.

Therefore, if the first toggle signal gets processed before the active
property is set, there can be a race condition. We are seeing this downstream
at pmOS: https://gitlab.com/postmarketOS/pmaports/-/issues/1816

Instead of this racy behavior, follow upstream recommendation and keep track
of the state through a stateful signal.
2023-05-24 08:54:06 +00:00
..
8021x-security-page.ui network: Port to GTK4 2021-12-14 22:34:21 -03:00
ce-ip-address-entry.c Drop most uses of deprecated gtk_style_context_add/remove_class 2023-01-05 18:55:51 +00:00
ce-ip-address-entry.h network: Make CEIPAddressEntry 2020-12-11 19:06:48 +00:00
ce-netmask-entry.c Drop most uses of deprecated gtk_style_context_add/remove_class 2023-01-05 18:55:51 +00:00
ce-netmask-entry.h network: Make CENetmaskEntry 2020-12-11 19:06:48 +00:00
ce-page-8021x-security.c network: replace wireless-security with libnma's NMAWs 2022-11-30 13:40:09 +01:00
ce-page-8021x-security.h network: Convert CEPage widgets to GtkTemplate 2019-11-06 22:04:15 +13:00
ce-page-details.c network: Add quotes to network name in Forget Connection dialog 2023-04-20 17:30:55 +02:00
ce-page-details.h wifi: Add a confirmation dialog when forgetting a connection 2023-04-11 11:28:26 +00:00
ce-page-ethernet.c Resolving suggestions 2023-03-29 14:26:55 +13:00
ce-page-ethernet.h Fix license headers that must have got search and replaced 2020-07-17 09:24:32 +12:00
ce-page-ip4.c network: keep track of radio buttons in connection editor with action 2023-05-24 08:54:06 +00:00
ce-page-ip4.h network: Port to GTK4 2021-12-14 22:34:21 -03:00
ce-page-ip6.c network: keep track of radio buttons in connection editor with action 2023-05-24 08:54:06 +00:00
ce-page-ip6.h network: Port to GTK4 2021-12-14 22:34:21 -03:00
ce-page-security.c network: replace wireless-security with libnma's NMAWs 2022-11-30 13:40:09 +01:00
ce-page-security.h Fix license headers that must have got search and replaced 2020-07-17 09:24:32 +12:00
ce-page-vpn.c network: Port to GTK4 2021-12-14 22:34:21 -03:00
ce-page-vpn.h Fix license headers that must have got search and replaced 2020-07-17 09:24:32 +12:00
ce-page-wifi.c network: Port to GTK4 2021-12-14 22:34:21 -03:00
ce-page-wifi.h Fix license headers that must have got search and replaced 2020-07-17 09:24:32 +12:00
ce-page-wireguard.c network: Add support for WireGuard (GNOME/gnome-control-center#982) 2023-01-16 20:35:02 +00:00
ce-page-wireguard.h network: Add support for WireGuard (GNOME/gnome-control-center#982) 2023-01-16 20:35:02 +00:00
ce-page.c network: Port to GTK4 2021-12-14 22:34:21 -03:00
ce-page.h network: Convert CEPage widgets to GtkTemplate 2019-11-06 22:04:15 +13:00
connection-editor.gresource.xml network: Add support for WireGuard (GNOME/gnome-control-center#982) 2023-01-16 20:35:02 +00:00
connection-editor.ui connection-editor: Set default height to 600 2022-06-20 00:30:58 +00:00
details-page.ui network: Make metered connection label a child of its check button 2023-01-30 11:47:02 +00:00
ethernet-page.ui network: Increase maximum MTU value from 10000 to 65536 2023-03-24 01:47:09 +00:00
ip4-page.ui network: keep track of radio buttons in connection editor with action 2023-05-24 08:54:06 +00:00
ip6-page.ui network: keep track of radio buttons in connection editor with action 2023-05-24 08:54:06 +00:00
meson.build all: meson: do not specify resources from gresource files as dependencies 2023-05-24 08:34:14 +00:00
net-connection-editor.c network/connection-editor: fix crash when removing a connection 2023-04-12 16:01:51 +08:00
net-connection-editor.h network: Show spinner instead of delaying dialog 2020-12-17 21:27:51 +00:00
security-page.ui network: Port to GTK4 2021-12-14 22:34:21 -03:00
vpn-helpers.c network: Remove "close-request" signal handler for VPN file import dialog 2023-01-30 11:39:11 +00:00
vpn-helpers.h network: Remove unused function 2019-11-06 22:04:15 +13:00
vpn-page.ui network: Port to GTK4 2021-12-14 22:34:21 -03:00
wifi-page.ui network: Port to GTK4 2021-12-14 22:34:21 -03:00
wireguard-page.ui network: Increase maximum MTU value from 10000 to 65536 2023-03-24 01:47:09 +00:00
wireguard-peer.ui network: Add support for WireGuard (GNOME/gnome-control-center#982) 2023-01-16 20:35:02 +00:00