Don't gitignore tags/ directories (#677)

* Don't gitignore tags/ directories

For example, the [rails/rails][] project has an entire directory of
classes with `tags` in the name, which hides it from search tools (like
[`ag` The Silver Searcher][ag]) and prevents committing changes or
introducing new files.

Support for ignoring [files named `tags`][git_template/hooks], but
including _directories_ named `tags/` was originally introduced in
[a99fbb0][], but was subsequently broken when the [negative `!tags/`
pattern declaration][] was moved _above_ the `tags` line that it
negated.

Instead of fighting the ignore patterns, this commit removes both lines.
We currently ignore the contents of the [`.git/` directory][.git/],
which is where [we store the `tags` file generated in our
`git_template/hooks/ctags` command][git_template/hooks], so we should be
covered without explicit declarations.

[rails/rails]: https://github.com/rails/rails/tree/master/actionview/lib/action_view/helpers/tags
[ag]: https://github.com/ggreer/the_silver_searcher/tree/2.2.0#whats-so-great-about-ag
[a99fbb0]: a99fbb0f57
[gitignore-pattern]: https://git-scm.com/docs/gitignore#_pattern_format
[git_template/hooks]: 56d614f806/git_template/hooks/ctags (L10)
[.git/]: 56d614f806/gitignore (L8)

* Ignore `tags` file

In case a `tags` file is declared outside `.git/tags`, continue to
ignore it, while still supporting `tags/` directories.
This commit is contained in:
Sean Doyle 2020-10-09 12:12:36 -04:00 committed by GitHub
parent e5c5ff3ebd
commit de02da4fc6
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -1,4 +1,3 @@
!tags/
*.pyc *.pyc
*.sw[nop] *.sw[nop]
.DS_Store .DS_Store
@ -14,5 +13,5 @@
db/*.sqlite3 db/*.sqlite3
log/*.log log/*.log
rerun.txt rerun.txt
tags
tmp/**/* tmp/**/*
/tags