mirror of
https://github.com/parchlinuxB/Gitee.git
synced 2025-02-23 18:35:43 -05:00
Typification of SearXNG ======================= This patch introduces the typing of the results. The why and how is described in the documentation, please generate the documentation .. $ make docs.clean docs.live and read the following articles in the "Developer documentation": - result types --> http://0.0.0.0:8000/dev/result_types/index.html The result types are available from the `searx.result_types` module. The following have been implemented so far: - base result type: `searx.result_type.Result` --> http://0.0.0.0:8000/dev/result_types/base_result.html - answer results --> http://0.0.0.0:8000/dev/result_types/answer.html including the type for translations (inspired by #3925). For all other types (which still need to be set up in subsequent PRs), template documentation has been created for the transition period. Doc of the fields used in Templates =================================== The template documentation is the basis for the typing and is the first complete documentation of the results (needed for engine development). It is the "working paper" (the plan) with which further typifications can be implemented in subsequent PRs. - https://github.com/searxng/searxng/issues/357 Answer Templates ================ With the new (sub) types for `Answer`, the templates for the answers have also been revised, `Translation` are now displayed with collapsible entries (inspired by #3925). !en-de dog Plugins & Answerer ================== The implementation for `Plugin` and `Answer` has been revised, see documentation: - Plugin: http://0.0.0.0:8000/dev/plugins/index.html - Answerer: http://0.0.0.0:8000/dev/answerers/index.html With `AnswerStorage` and `AnswerStorage` to manage those items (in follow up PRs, `ArticleStorage`, `InfoStorage` and .. will be implemented) Autocomplete ============ The autocompletion had a bug where the results from `Answer` had not been shown in the past. To test activate autocompletion and try search terms for which we have answerers - statistics: type `min 1 2 3` .. in the completion list you should find an entry like `[de] min(1, 2, 3) = 1` - random: type `random uuid` .. in the completion list, the first item is a random UUID Extended Types ============== SearXNG extends e.g. the request and response types of flask and httpx, a module has been set up for type extensions: - Extended Types --> http://0.0.0.0:8000/dev/extended_types.html Unit-Tests ========== The unit tests have been completely revised. In the previous implementation, the runtime (the global variables such as `searx.settings`) was not initialized before each test, so the runtime environment with which a test ran was always determined by the tests that ran before it. This was also the reason why we sometimes had to observe non-deterministic errors in the tests in the past: - https://github.com/searxng/searxng/issues/2988 is one example for the Runtime issues, with non-deterministic behavior .. - https://github.com/searxng/searxng/pull/3650 - https://github.com/searxng/searxng/pull/3654 - https://github.com/searxng/searxng/pull/3642#issuecomment-2226884469 - https://github.com/searxng/searxng/pull/3746#issuecomment-2300965005 Why msgspec.Struct ================== We have already discussed typing based on e.g. `TypeDict` or `dataclass` in the past: - https://github.com/searxng/searxng/pull/1562/files - https://gist.github.com/dalf/972eb05e7a9bee161487132a7de244d2 - https://github.com/searxng/searxng/pull/1412/files - https://github.com/searxng/searxng/pull/1356 In my opinion, TypeDict is unsuitable because the objects are still dictionaries and not instances of classes / the `dataclass` are classes but ... The `msgspec.Struct` combine the advantages of typing, runtime behaviour and also offer the option of (fast) serializing (incl. type check) the objects. Currently not possible but conceivable with `msgspec`: Outsourcing the engines into separate processes, what possibilities this opens up in the future is left to the imagination! Internally, we have already defined that it is desirable to decouple the development of the engines from the development of the SearXNG core / The serialization of the `Result` objects is a prerequisite for this. HINT: The threads listed above were the template for this PR, even though the implementation here is based on msgspec. They should also be an inspiration for the following PRs of typification, as the models and implementations can provide a good direction. Why just one commit? ==================== I tried to create several (thematically separated) commits, but gave up at some point ... there are too many things to tackle at once / The comprehensibility of the commits would not be improved by a thematic separation. On the contrary, we would have to make multiple changes at the same places and the goal of a change would be vaguely recognizable in the fog of the commits. Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
260 lines
9.8 KiB
Python
260 lines
9.8 KiB
Python
# SPDX-License-Identifier: AGPL-3.0-or-later
|
|
# pylint: disable=missing-module-docstring,disable=missing-class-docstring,invalid-name
|
|
|
|
import json
|
|
from urllib.parse import ParseResult
|
|
import babel
|
|
from mock import Mock
|
|
|
|
import searx.webapp
|
|
import searx.search
|
|
import searx.search.processors
|
|
|
|
from searx.results import Timing
|
|
from searx.preferences import Preferences
|
|
from tests import SearxTestCase
|
|
|
|
|
|
class ViewsTestCase(SearxTestCase): # pylint: disable=too-many-public-methods
|
|
|
|
def setUp(self):
|
|
super().setUp()
|
|
|
|
# skip init function (no external HTTP request)
|
|
def dummy(*args, **kwargs): # pylint: disable=unused-argument
|
|
pass
|
|
|
|
self.setattr4test(searx.search.processors, 'initialize_processor', dummy)
|
|
# remove sha for the static file so the tests don't have to care about
|
|
# the changing URLs
|
|
self.setattr4test(searx.webapp, 'static_files', {})
|
|
|
|
# set some defaults
|
|
test_results = [
|
|
{
|
|
'content': 'first test content',
|
|
'title': 'First Test',
|
|
'url': 'http://first.test.xyz',
|
|
'engines': ['youtube', 'startpage'],
|
|
'engine': 'startpage',
|
|
'parsed_url': ParseResult(
|
|
scheme='http', netloc='first.test.xyz', path='/', params='', query='', fragment=''
|
|
),
|
|
'template': 'default.html',
|
|
},
|
|
{
|
|
'content': 'second test content',
|
|
'title': 'Second Test',
|
|
'url': 'http://second.test.xyz',
|
|
'engines': ['youtube', 'startpage'],
|
|
'engine': 'youtube',
|
|
'parsed_url': ParseResult(
|
|
scheme='http', netloc='second.test.xyz', path='/', params='', query='', fragment=''
|
|
),
|
|
'template': 'default.html',
|
|
},
|
|
]
|
|
|
|
timings = [
|
|
Timing(engine='startpage', total=0.8, load=0.7),
|
|
Timing(engine='youtube', total=0.9, load=0.6),
|
|
]
|
|
|
|
def search_mock(search_self, *args): # pylint: disable=unused-argument
|
|
search_self.result_container = Mock(
|
|
get_ordered_results=lambda: test_results,
|
|
answers={},
|
|
corrections=set(),
|
|
suggestions=set(),
|
|
infoboxes=[],
|
|
unresponsive_engines=set(),
|
|
results=test_results,
|
|
number_of_results=3,
|
|
results_length=lambda: len(test_results),
|
|
get_timings=lambda: timings,
|
|
redirect_url=None,
|
|
engine_data={},
|
|
)
|
|
search_self.search_query.locale = babel.Locale.parse("en-US", sep='-')
|
|
|
|
self.setattr4test(searx.search.Search, 'search', search_mock)
|
|
|
|
original_preferences_get_value = Preferences.get_value
|
|
|
|
def preferences_get_value(preferences_self, user_setting_name: str):
|
|
if user_setting_name == 'theme':
|
|
return 'simple'
|
|
return original_preferences_get_value(preferences_self, user_setting_name)
|
|
|
|
self.setattr4test(Preferences, 'get_value', preferences_get_value)
|
|
|
|
# to see full diffs
|
|
self.maxDiff = None # pylint: disable=invalid-name
|
|
|
|
def test_index_empty(self):
|
|
result = self.client.post('/')
|
|
self.assertEqual(result.status_code, 200)
|
|
self.assertIn(
|
|
b'<div class="title"><h1>SearXNG</h1></div>',
|
|
result.data,
|
|
)
|
|
|
|
def test_index_html_post(self):
|
|
result = self.client.post('/', data={'q': 'test'})
|
|
self.assertEqual(result.status_code, 308)
|
|
self.assertEqual(result.location, '/search')
|
|
|
|
def test_index_html_get(self):
|
|
result = self.client.post('/?q=test')
|
|
self.assertEqual(result.status_code, 308)
|
|
self.assertEqual(result.location, '/search?q=test')
|
|
|
|
def test_search_empty_html(self):
|
|
result = self.client.post('/search', data={'q': ''})
|
|
self.assertEqual(result.status_code, 200)
|
|
self.assertIn(b'<div class="title"><h1>SearXNG</h1></div>', result.data)
|
|
|
|
def test_search_empty_json(self):
|
|
result = self.client.post('/search', data={'q': '', 'format': 'json'})
|
|
self.assertEqual(result.status_code, 400)
|
|
|
|
def test_search_empty_csv(self):
|
|
result = self.client.post('/search', data={'q': '', 'format': 'csv'})
|
|
self.assertEqual(result.status_code, 400)
|
|
|
|
def test_search_empty_rss(self):
|
|
result = self.client.post('/search', data={'q': '', 'format': 'rss'})
|
|
self.assertEqual(result.status_code, 400)
|
|
|
|
def test_search_html(self):
|
|
result = self.client.post('/search', data={'q': 'test'})
|
|
|
|
self.assertIn(
|
|
b'<span class="url_o1"><span class="url_i1">http://second.test.xyz</span></span>',
|
|
result.data,
|
|
)
|
|
self.assertIn(
|
|
b'<p class="content">\n second <span class="highlight">test</span> ',
|
|
result.data,
|
|
)
|
|
|
|
def test_index_json(self):
|
|
result = self.client.post('/', data={'q': 'test', 'format': 'json'})
|
|
self.assertEqual(result.status_code, 308)
|
|
|
|
def test_search_json(self):
|
|
result = self.client.post('/search', data={'q': 'test', 'format': 'json'})
|
|
result_dict = json.loads(result.data.decode())
|
|
|
|
self.assertEqual('test', result_dict['query'])
|
|
self.assertEqual(len(result_dict['results']), 2)
|
|
self.assertEqual(result_dict['results'][0]['content'], 'first test content')
|
|
self.assertEqual(result_dict['results'][0]['url'], 'http://first.test.xyz')
|
|
|
|
def test_index_csv(self):
|
|
result = self.client.post('/', data={'q': 'test', 'format': 'csv'})
|
|
self.assertEqual(result.status_code, 308)
|
|
|
|
def test_search_csv(self):
|
|
result = self.client.post('/search', data={'q': 'test', 'format': 'csv'})
|
|
|
|
self.assertEqual(
|
|
b'title,url,content,host,engine,score,type\r\n'
|
|
b'First Test,http://first.test.xyz,first test content,first.test.xyz,startpage,,result\r\n' # noqa
|
|
b'Second Test,http://second.test.xyz,second test content,second.test.xyz,youtube,,result\r\n', # noqa
|
|
result.data,
|
|
)
|
|
|
|
def test_index_rss(self):
|
|
result = self.client.post('/', data={'q': 'test', 'format': 'rss'})
|
|
self.assertEqual(result.status_code, 308)
|
|
|
|
def test_search_rss(self):
|
|
result = self.client.post('/search', data={'q': 'test', 'format': 'rss'})
|
|
|
|
self.assertIn(b'<description>Search results for "test" - SearXNG</description>', result.data)
|
|
|
|
self.assertIn(b'<opensearch:totalResults>3</opensearch:totalResults>', result.data)
|
|
|
|
self.assertIn(b'<title>First Test</title>', result.data)
|
|
|
|
self.assertIn(b'<link>http://first.test.xyz</link>', result.data)
|
|
|
|
self.assertIn(b'<description>first test content</description>', result.data)
|
|
|
|
def test_redirect_about(self):
|
|
result = self.client.get('/about')
|
|
self.assertEqual(result.status_code, 302)
|
|
|
|
def test_info_page(self):
|
|
result = self.client.get('/info/en/search-syntax')
|
|
self.assertEqual(result.status_code, 200)
|
|
self.assertIn(b'<h1>Search syntax</h1>', result.data)
|
|
|
|
def test_health(self):
|
|
result = self.client.get('/healthz')
|
|
self.assertEqual(result.status_code, 200)
|
|
self.assertIn(b'OK', result.data)
|
|
|
|
def test_preferences(self):
|
|
result = self.client.get('/preferences')
|
|
self.assertEqual(result.status_code, 200)
|
|
self.assertIn(b'<form id="search_form" method="post" action="/preferences"', result.data)
|
|
self.assertIn(b'<div id="categories_container">', result.data)
|
|
self.assertIn(b'<legend id="pref_ui_locale">Interface language</legend>', result.data)
|
|
|
|
def test_browser_locale(self):
|
|
result = self.client.get('/preferences', headers={'Accept-Language': 'zh-tw;q=0.8'})
|
|
self.assertEqual(result.status_code, 200)
|
|
self.assertIn(
|
|
b'<option value="zh-Hant-TW" selected="selected">',
|
|
result.data,
|
|
'Interface locale ignored browser preference.',
|
|
)
|
|
self.assertIn(
|
|
b'<option value="zh-Hant-TW" selected="selected">',
|
|
result.data,
|
|
'Search language ignored browser preference.',
|
|
)
|
|
|
|
def test_browser_empty_locale(self):
|
|
result = self.client.get('/preferences', headers={'Accept-Language': ''})
|
|
self.assertEqual(result.status_code, 200)
|
|
self.assertIn(
|
|
b'<option value="en" selected="selected">', result.data, 'Interface locale ignored browser preference.'
|
|
)
|
|
|
|
def test_locale_occitan(self):
|
|
result = self.client.get('/preferences?locale=oc')
|
|
self.assertEqual(result.status_code, 200)
|
|
self.assertIn(
|
|
b'<option value="oc" selected="selected">', result.data, 'Interface locale ignored browser preference.'
|
|
)
|
|
|
|
def test_stats(self):
|
|
result = self.client.get('/stats')
|
|
self.assertEqual(result.status_code, 200)
|
|
self.assertIn(b'<h1>Engine stats</h1>', result.data)
|
|
|
|
def test_robots_txt(self):
|
|
result = self.client.get('/robots.txt')
|
|
self.assertEqual(result.status_code, 200)
|
|
self.assertIn(b'Allow: /', result.data)
|
|
|
|
def test_opensearch_xml(self):
|
|
result = self.client.get('/opensearch.xml')
|
|
self.assertEqual(result.status_code, 200)
|
|
self.assertIn(
|
|
b'<Description>SearXNG is a metasearch engine that respects your privacy.</Description>', result.data
|
|
)
|
|
|
|
def test_favicon(self):
|
|
result = self.client.get('/favicon.ico')
|
|
result.close()
|
|
self.assertEqual(result.status_code, 200)
|
|
|
|
def test_config(self):
|
|
result = self.client.get('/config')
|
|
self.assertEqual(result.status_code, 200)
|
|
json_result = result.get_json()
|
|
self.assertTrue(json_result)
|