From a9edbfd07dde43790074726d1727955ef864002a Mon Sep 17 00:00:00 2001
From: InsanePrawn <insane.prawny@gmail.com>
Date: Sun, 4 Sep 2022 02:13:08 +0200
Subject: [PATCH] exec/file: document symlink() and check return code

---
 exec/file.py | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/exec/file.py b/exec/file.py
index 7eeadc1..8471288 100644
--- a/exec/file.py
+++ b/exec/file.py
@@ -161,10 +161,14 @@ def root_makedir(path, parents: bool = True):
 
 
 def symlink(source, target):
+    "Create a symlink at `target`, pointing at `source`"
     try:
         os.symlink(source, target)
     except:
-        run_root_cmd(['ln', '-s', source, target])
+        result = run_root_cmd(['ln', '-s', source, target])
+        assert isinstance(result, subprocess.CompletedProcess)
+        if result.returncode:
+            raise Exception(f'Symlink creation of {target} pointing at {source} failed')
 
 
 def get_temp_dir(register_cleanup=True, mode: int = 0o0755):