Make the github migration less rate limit waiting to get comment per page from repository but not per issue (#16070)
* Make the github migration less rate limit waiting to get comment per page from repository but not per issue * Fix lint * adjust Downloader interface * Fix missed reviews * Fix test * Remove unused struct
This commit is contained in:
parent
e8c6cead0f
commit
0966349354
13 changed files with 194 additions and 56 deletions
|
@ -224,7 +224,9 @@ func TestGiteaDownloadRepo(t *testing.T) {
|
|||
Closed: &closed2,
|
||||
}, issues[1])
|
||||
|
||||
comments, err := downloader.GetComments(4)
|
||||
comments, _, err := downloader.GetComments(base.GetCommentOptions{
|
||||
IssueNumber: 4,
|
||||
})
|
||||
assert.NoError(t, err)
|
||||
assert.Len(t, comments, 2)
|
||||
assert.EqualValues(t, 1598975370, comments[0].Created.Unix())
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue