From a40284bec4b1c31b015f59e09b83c22e077ed14a Mon Sep 17 00:00:00 2001 From: 0ko <0ko@noreply.codeberg.org> Date: Wed, 22 Jan 2025 03:56:36 +0000 Subject: [PATCH] fix(tests): prevent frontend test dependency on system locale (#6649) This test depended on system locale. It always failed with `LANG=fr_FR make test-frontend` and always passed with `LANG=C make test-frontend`. - prevent this dependency by explicitly passing 'en-US' - avoid process.env.TZ boilerplate with vi.stubEnv Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/6649 Reviewed-by: Gusted Reviewed-by: Beowulf --- web_src/js/webcomponents/absolute-date.test.js | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/web_src/js/webcomponents/absolute-date.test.js b/web_src/js/webcomponents/absolute-date.test.js index dfd82e3cf1..95fb1a9017 100644 --- a/web_src/js/webcomponents/absolute-date.test.js +++ b/web_src/js/webcomponents/absolute-date.test.js @@ -18,9 +18,7 @@ test('toAbsoluteLocaleDate', () => { expect(toAbsoluteLocaleDate('10000-01-01', '', {})).toEqual('Invalid Date'); // test different timezone - const oldTZ = process.env.TZ; - process.env.TZ = 'America/New_York'; - expect(new Date('2024-03-15').toLocaleString()).toEqual('3/14/2024, 8:00:00 PM'); - expect(toAbsoluteLocaleDate('2024-03-15')).toEqual('3/15/2024, 12:00:00 AM'); - process.env.TZ = oldTZ; + vi.stubEnv('TZ', 'America/New_York'); + expect(new Date('2024-03-15').toLocaleString('en-US')).toEqual('3/14/2024, 8:00:00 PM'); + expect(toAbsoluteLocaleDate('2024-03-15', 'en-US')).toEqual('3/15/2024, 12:00:00 AM'); });