fix(ui): hide extra PR property labels on title edit (#6898)

* hide labels [AGit](https://codeberg.org/forgejo/forgejo/pulls/2444) and [Editable](https://codeberg.org/forgejo/forgejo/pulls/6863) on title edit mode: they make layout broken and are not really needed at edit state
* make the code slightly less boring

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/6898
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
Reviewed-by: Panagiotis "Ivory" Vasilopoulos <git@n0toose.net>
Co-authored-by: 0ko <0ko@noreply.codeberg.org>
Co-committed-by: 0ko <0ko@noreply.codeberg.org>

models/fixtures/pull_request.yml

@@ -64,6 +64,7 @@
   base_branch: branch2
   merge_base: 985f0301dba5e7b34be866819cd15ad3d8f508ee
   has_merged: false
+  allow_maintainer_edit: true
 
 -
   id: 6

tests/e2e/pr-title.test.e2e.ts

@@ -0,0 +1,25 @@
+// Copyright 2025 The Forgejo Authors. All rights reserved.
+// SPDX-License-Identifier: GPL-3.0-or-later
+
+// @watch start
+// templates/repo/issue/view_title.tmpl
+// web_src/js/features/repo-issue.js
+// @watch end
+
+import {expect} from '@playwright/test';
+import {save_visual, test} from './utils_e2e.ts';
+
+test.use({user: 'user2'});
+
+test('PR: title edit', async ({page}) => {
+  const response = await page.goto('/user2/repo1/pulls/5');
+  expect(response?.status()).toBe(200);
+
+  await expect(page.locator('#editable-label')).toBeVisible();
+  await save_visual(page);
+
+  // Labels AGit and Editable are hidden when title is in edit mode
+  await page.locator('#issue-title-edit-show').click();
+  await expect(page.locator('#editable-label')).toBeHidden();
+  await save_visual(page);
+});

web_src/js/features/repo-issue.js

@@ -631,9 +631,11 @@ export function initRepoIssueTitleEdit() {
 
   const issueTitleInput = issueTitleEditor.querySelector('input');
   const oldTitle = issueTitleInput.getAttribute('data-old-title');
+  const normalModeElements = [issueTitleDisplay, '#pull-desc-display', '#agit-label', '#editable-label'];
   issueTitleDisplay.querySelector('#issue-title-edit-show').addEventListener('click', () => {
-    hideElem(issueTitleDisplay);
+    for (const element of normalModeElements) {
-    hideElem('#pull-desc-display');
+      hideElem(element);
+    }
     showElem(issueTitleEditor);
     showElem('#pull-desc-editor');
     if (!issueTitleInput.value.trim()) {
@@ -644,8 +646,9 @@ export function initRepoIssueTitleEdit() {
   issueTitleEditor.querySelector('.ui.cancel.button').addEventListener('click', () => {
     hideElem(issueTitleEditor);
     hideElem('#pull-desc-editor');
-    showElem(issueTitleDisplay);
+    for (const element of normalModeElements) {
-    showElem('#pull-desc-display');
+      showElem(element);
+    }
   });
 
   const pullDescEditor = document.querySelector('#pull-desc-editor'); // it may not exist for a merged PR