web/forgejo
10
0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2025-06-01 06:34:36 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

tests: add coverage for models migration helpers (#18162)

Browse source 
They were previously not covered at all, either by integration tests or unit tests.

This PR also fixes a bug where the `num_comments` field was incorrectly set to include all types of comments.

It sets num_closed_issues: 0 as default in milestone unit test fixtures. If they are not set, Incr("num_closed_issues") will be a noop because the field is null.
This commit is contained in:
Aravinth Manivannan 2022-01-03 15:35:01 +00:00 • committed by GitHub
parent f499f23039
commit ade41f3f04
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 173 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
models/migrate.go
View file

@ -166,7 +166,7 @@ func InsertIssueComments(comments []*Comment) error {
}
for issueID := range issueIDs {
if _, err := db.Exec(ctx, "UPDATE issue set num_comments = (SELECT count(*) FROM comment WHERE issue_id = ?) WHERE id = ?", issueID, issueID); err != nil {
if _, err := db.Exec(ctx, "UPDATE issue set num_comments = (SELECT count(*) FROM comment WHERE issue_id = ? AND `type`=?) WHERE id = ?", issueID, CommentTypeComment, issueID); err != nil {
return err
}
}