web/forgejo
9
0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2025-06-22 11:18:30 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

Remove Fomantic-UI's .hidden CSS class for checkbox elements (#22851)

Browse source 
Fomantic-UI's `.hidden` CSS class is badly designed.

* Checkbox elements do not need it in HTML, so this PR removes it (JS
adds the `.hidden` class back by `$('.ui.checkbox').checkbox()`)
* `menu transaction hidden` is still needed, and it should be the only
usage for the `.hidden` from now on (until they get refactored properly)

Co-authored-by: zeripath <art27@cantab.net>
This commit is contained in:
wxiaoguang 2023-02-13 11:16:59 +08:00 • committed by GitHub
parent c8093a13ff
commit eb5e1bcd21
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
8 changed files with 50 additions and 50 deletions
Download patch file Download diff file Expand all files Collapse all files

2
templates/repo/editor/commit_form.tmpl
View file

@ -16,7 +16,7 @@
</div>
<div class="inline field">
<div class="ui checkbox">
<input name="signoff" type="checkbox" tabindex="0" class="hidden">
<input name="signoff" type="checkbox" tabindex="0">
<label>{{.locale.Tr "repo.editor.signoff_desc"}}</label>
</div>
</div>