mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2025-02-22 03:15:48 -05:00
Fix invalid swagger syntax of $ref with sibling (#7019)
Ticket #5676 states that the output from `make generate-swagger` is not valid according to the current [OpenAPI specification](https://swagger.io/specification/#path-item-object). In future this [may change](https://swagger.io/specification/#reference-object) but currently this has the effect that the `description` field will be ignored. Removing the description from the type definition of the offending entry will fix the invalid output and have the same end result as before, as the description would have been ignored anyway. ## Checklist ### Tests No changes to Go (except removal of comment) or Javascript code. Have added the `lint-swagger` task to the CI test run however. ### Documentation - [ ] I created a pull request [to the documentation](https://codeberg.org/forgejo/docs) to explain to Forgejo users how to use this change. - [x] I did not document these changes and I do not expect someone else to do it. ### Release notes - [x] I do not want this change to show in the release notes. - [ ] I want the title to show in the release notes with a link to this pull request. - [ ] I want the content of the `release-notes/<pull request number>.md` to be be used for the release notes instead of the title. Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/7019 Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org> Co-authored-by: Sven Steinbauer <sven@unlogic.co.uk> Co-committed-by: Sven Steinbauer <sven@unlogic.co.uk>
This commit is contained in:
parent
3ba7445d81
commit
f05b960494
3 changed files with 1 additions and 3 deletions
|
@ -24,7 +24,7 @@ jobs:
|
|||
- uses: https://data.forgejo.org/actions/checkout@v4
|
||||
- uses: ./.forgejo/workflows-composite/setup-env
|
||||
- run: su forgejo -c 'make deps-backend deps-tools'
|
||||
- run: su forgejo -c 'make --always-make -j$(nproc) lint-backend tidy-check swagger-check fmt-check swagger-validate' # ensure the "go-licenses" make target runs
|
||||
- run: su forgejo -c 'make --always-make -j$(nproc) lint-backend tidy-check swagger-check lint-swagger fmt-check swagger-validate' # ensure the "go-licenses" make target runs
|
||||
- uses: ./.forgejo/workflows-composite/build-backend
|
||||
frontend-checks:
|
||||
if: vars.ROLE == 'forgejo-coding' || vars.ROLE == 'forgejo-testing'
|
||||
|
|
|
@ -89,7 +89,6 @@ type CreatePullReviewComment struct {
|
|||
NewLineNum int64 `json:"new_position"`
|
||||
}
|
||||
|
||||
// CreatePullReviewCommentOptions are options to create a pull review comment
|
||||
type CreatePullReviewCommentOptions CreatePullReviewComment
|
||||
|
||||
// SubmitPullReviewOptions are options to submit a pending pull review
|
||||
|
|
1
templates/swagger/v1_json.tmpl
generated
1
templates/swagger/v1_json.tmpl
generated
|
@ -22411,7 +22411,6 @@
|
|||
"x-go-package": "code.gitea.io/gitea/modules/structs"
|
||||
},
|
||||
"CreatePullReviewCommentOptions": {
|
||||
"description": "CreatePullReviewCommentOptions are options to create a pull review comment",
|
||||
"$ref": "#/definitions/CreatePullReviewComment"
|
||||
},
|
||||
"CreatePullReviewOptions": {
|
||||
|
|
Loading…
Add table
Reference in a new issue