forgejo/services/context
Matthias Riße 5a2f2229d2
Some checks are pending
/ release (push) Waiting to run
testing / backend-checks (push) Waiting to run
testing / frontend-checks (push) Waiting to run
testing / test-unit (push) Blocked by required conditions
testing / test-e2e (push) Blocked by required conditions
testing / test-remote-cacher (redis) (push) Blocked by required conditions
testing / test-remote-cacher (valkey) (push) Blocked by required conditions
testing / test-remote-cacher (garnet) (push) Blocked by required conditions
testing / test-remote-cacher (redict) (push) Blocked by required conditions
testing / test-mysql (push) Blocked by required conditions
testing / test-pgsql (push) Blocked by required conditions
testing / test-sqlite (push) Blocked by required conditions
testing / security-check (push) Blocked by required conditions
fix: return 404 for empty repositories (#7003)
- Some endpoints (`/api/v1/repos/*/*/raw`, `/api/v1/repos/*/*/media`, ...;
anything that uses both `context.ReferencesGitRepo()` and
`context.RepoRefForAPI` really) returned a 500 when the repository was
completely empty. This resulted in some confusion in
https://github.com/datalad/datalad-usage-dashboard/issues/47 because the
same request for a non-existent file in a repository could sometimes
generate a 404 and sometimes a 500, depending on if the git repository
is initialized at all or not.

Returning a 404 is more appropriate here, since this isn't an
unexpected internal error, but just another way of not finding the
requested data.

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/7003
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
Co-authored-by: Matthias Riße <m.risse@fz-juelich.de>
Co-committed-by: Matthias Riße <m.risse@fz-juelich.de>
2025-02-20 21:50:46 +00:00
..
upload Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
access_log.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
api.go fix: return 404 for empty repositories (#7003) 2025-02-20 21:50:46 +00:00
api_org.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
api_test.go Add testifylint to lint checks (#4535) 2024-07-30 19:41:10 +00:00
base.go Ignore useless error message "broken pipe" (#30801) 2024-05-05 12:15:40 +01:00
base_test.go Use strict protocol check when redirect (#29642) 2024-03-11 23:36:59 +07:00
captcha.go [CHORE] Move cache library 2024-08-27 21:28:56 +02:00
context.go [PORT] Refactor DateUtils and merge TimeSince (gitea#32409) 2024-11-10 22:23:27 +01:00
context_cookie.go fix: extend forgejo_auth_token table 2024-11-15 10:59:36 +01:00
context_model.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
context_request.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
context_response.go Ignore useless error message "broken pipe" (#30801) 2024-05-05 12:15:40 +01:00
context_template.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
context_test.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
csrf.go Update services/context/csrf.go 2024-11-28 10:12:46 +00:00
org.go Calculate PublicOnly for org membership only once (#32234) 2024-11-17 21:57:34 +01:00
package.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
pagination.go Unify search boxes (#29530) 2024-03-20 12:31:05 +00:00
permission.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
private.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
quota.go feat(quota): Quota enforcement 2024-08-02 11:10:34 +02:00
repo.go fix: always set stripped slashes on http request 2025-02-10 12:55:11 +01:00
repository.go feat(federation): validate like activities (#3494) 2024-05-07 07:59:49 +00:00
response.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
user.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
utils.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
xsrf.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
xsrf_test.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00