applications/gnome-control-center
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
gnome-control-center/panels/network/connection-editor/ce-page-ip6.c

840 lines
32 KiB
C
Raw Normal View History

network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
/* -*- Mode: C; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 8 -*-
*
* Copyright (C) 2012 Red Hat, Inc
*
* Licensed under the GNU General Public License Version 2
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, write to the Free Software
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
*/
#include "config.h"
#include <errno.h>
#include <stdlib.h>
network: Port to libnm 1.2 We also remove support for WiMAX (now unsupported by NetworkManager), and InfiniBand (Enterprise feature), and the use of the deprecated NM_SETTING_WIRELESS_SEC property. With help from network-manager-applet patches by Jiří Klimeš and Dan Winship. https://bugzilla.gnome.org/show_bug.cgi?id=765910
2016-04-29 16:05:54 +02:00
#include <arpa/inet.h>
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
#include <glib-object.h>
#include <glib/gi18n.h>
network: Port to libnm 1.2 We also remove support for WiMAX (now unsupported by NetworkManager), and InfiniBand (Enterprise feature), and the use of the deprecated NM_SETTING_WIRELESS_SEC property. With help from network-manager-applet patches by Jiří Klimeš and Dan Winship. https://bugzilla.gnome.org/show_bug.cgi?id=765910
2016-04-29 16:05:54 +02:00
#include <NetworkManager.h>
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
Move common panel code from shell/ to panel/common This creates a new static library called libwidget which the shell links against.
2018-04-06 13:38:40 +02:00
#include "list-box-helper.h"
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
#include "ce-page-ip6.h"
network: Make broken configuration entries red When a configuration setting is wrong, set the entry or file chooser that contains the incorrect information to be surrounded by red. This makes it easier for users to find where the error was made that disallows them to click the "Apply" button. https://bugzilla.gnome.org/show_bug.cgi?id=734446
2014-08-07 18:32:34 +02:00
#include "ui-helpers.h"
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
network: Use radio buttons instead of a combobox in IP pages Per the latest mockups [1], the IP pages use a set of four radio buttons to control the method, rather than a switch + a combobox, which is what the current implementation uses. This patch, then, adapts the IP pages of the connection editor dialog to use a set of radio buttons at the top of the page. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 01:56:08 -03:00
#define RADIO_IS_ACTIVE(x) (gtk_toggle_button_get_active (GTK_TOGGLE_BUTTON (gtk_builder_get_object(CE_PAGE (page)->builder, x))))
network: Use a table-like widget in address editor According to the latest mockups for the connection editor dialog [1], the IPv4 and IPv6 pages are supposed to use a table-like editor to manage the addresses, in a similar fashion of what was done to the routes editor. This way of editing is not only easier to comprehend, but also improves the size of the dialog, requiring much less vertical space to present the routes. The current implementation, however, uses a vertical layout and a toolbar, which is inefficient in its usage of space. Fix that by implementing the table-like editor widget, both in IPv4 and IPv6 pages. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 15:02:45 -03:00
static void ensure_empty_address_row (CEPageIP6 *page);
network: Use a table-like widget to edit routes According to the latest mockups for the connection editor dialog [1], the IPv4 and IPv6 pages are supposed to use a table-like editor to manage the routes. This editor is not only easier to comprehend, but also improves the size of the dialog, requiring much less vertical space to present the routes. The current implementation, however, uses a vertical layout and a toolbar, which is inefficient in its usage of space. Fix that by implementing the table-like editor widget, both in IPv4 and IPv6 pages. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 13:04:52 -03:00
static void ensure_empty_routes_row (CEPageIP6 *page);
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
G_DEFINE_TYPE (CEPageIP6, ce_page_ip6, CE_TYPE_PAGE)
enum {
METHOD_COL_NAME,
METHOD_COL_METHOD
};
enum {
IP6_METHOD_AUTO,
IP6_METHOD_DHCP,
IP6_METHOD_MANUAL,
IP6_METHOD_LINK_LOCAL,
IP6_METHOD_SHARED,
IP6_METHOD_IGNORE
};
static void
network: Use radio buttons instead of a combobox in IP pages Per the latest mockups [1], the IP pages use a set of four radio buttons to control the method, rather than a switch + a combobox, which is what the current implementation uses. This patch, then, adapts the IP pages of the connection editor dialog to use a set of radio buttons at the top of the page. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 01:56:08 -03:00
method_changed (GtkToggleButton *button, CEPageIP6 *page)
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
{
gboolean addr_enabled;
gboolean dns_enabled;
gboolean routes_enabled;
GtkWidget *widget;
network: Use radio buttons instead of a combobox in IP pages Per the latest mockups [1], the IP pages use a set of four radio buttons to control the method, rather than a switch + a combobox, which is what the current implementation uses. This patch, then, adapts the IP pages of the connection editor dialog to use a set of radio buttons at the top of the page. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 01:56:08 -03:00
if (RADIO_IS_ACTIVE ("radio_disabled")) {
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
addr_enabled = FALSE;
dns_enabled = FALSE;
routes_enabled = FALSE;
network: Use radio buttons instead of a combobox in IP pages Per the latest mockups [1], the IP pages use a set of four radio buttons to control the method, rather than a switch + a combobox, which is what the current implementation uses. This patch, then, adapts the IP pages of the connection editor dialog to use a set of radio buttons at the top of the page. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 01:56:08 -03:00
} else {
addr_enabled = RADIO_IS_ACTIVE ("radio_manual");
dns_enabled = !RADIO_IS_ACTIVE ("radio_local");
routes_enabled = !RADIO_IS_ACTIVE ("radio_local");
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
}
widget = GTK_WIDGET (gtk_builder_get_object (CE_PAGE (page)->builder, "address_section"));
gtk_widget_set_visible (widget, addr_enabled);
network: Simplify DNS management in connection editor When editing the DNS servers of a given connection, a simple entry is enough to display and edit the DNS servers. The user can separate IP addresses with commas. This is exemplified by the mockup at [1]. This, however, is not the current implementation, which uses a combination of listbox rows, entries and buttons to manage that with added complexity. Fix that by using an entry to handle the DNS servers. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 02:44:58 -03:00
gtk_widget_set_sensitive (page->dns_entry, dns_enabled);
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
gtk_widget_set_sensitive (page->routes_list, routes_enabled);
gtk_widget_set_sensitive (page->never_default, routes_enabled);
ce_page_changed (CE_PAGE (page));
}
network: mark connection editor changed when editing IPv4/IPv6 pages When this got rewritten to be different from nm-connection-editor's, some of the ce_page_changed() calls accidentally got dropped, so certain changes on these pages would not cause the "Apply" button to become sensitive. https://bugzilla.gnome.org/show_bug.cgi?id=693659
2013-02-13 15:14:24 -05:00
static void
switch_toggled (GObject *object,
GParamSpec *pspec,
CEPage *page)
{
ce_page_changed (page);
}
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
static void
update_row_sensitivity (CEPageIP6 *page, GtkWidget *list)
{
GList *children, *l;
network: Use a table-like widget to edit routes According to the latest mockups for the connection editor dialog [1], the IPv4 and IPv6 pages are supposed to use a table-like editor to manage the routes. This editor is not only easier to comprehend, but also improves the size of the dialog, requiring much less vertical space to present the routes. The current implementation, however, uses a vertical layout and a toolbar, which is inefficient in its usage of space. Fix that by implementing the table-like editor widget, both in IPv4 and IPv6 pages. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 13:04:52 -03:00
gint rows = 0, i = 0;
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
children = gtk_container_get_children (GTK_CONTAINER (list));
for (l = children; l; l = l->next) {
GtkWidget *row = l->data;
GtkWidget *button;
button = GTK_WIDGET (g_object_get_data (G_OBJECT (row), "delete-button"));
if (button != NULL)
rows++;
}
for (l = children; l; l = l->next) {
GtkWidget *row = l->data;
GtkWidget *button;
button = GTK_WIDGET (g_object_get_data (G_OBJECT (row), "delete-button"));
if (button != NULL)
network: Use a table-like widget to edit routes According to the latest mockups for the connection editor dialog [1], the IPv4 and IPv6 pages are supposed to use a table-like editor to manage the routes. This editor is not only easier to comprehend, but also improves the size of the dialog, requiring much less vertical space to present the routes. The current implementation, however, uses a vertical layout and a toolbar, which is inefficient in its usage of space. Fix that by implementing the table-like editor widget, both in IPv4 and IPv6 pages. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 13:04:52 -03:00
gtk_widget_set_sensitive (button, rows > 1 && ++i < rows);
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
}
g_list_free (children);
}
static void
remove_row (GtkButton *button, CEPageIP6 *page)
{
GtkWidget *row;
network: Convert connection editor to GtkListBox https://bugzilla.gnome.org/show_bug.cgi?id=702164
2013-06-21 20:03:53 +02:00
GtkWidget *row_box;
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
GtkWidget *list;
network: Convert connection editor to GtkListBox https://bugzilla.gnome.org/show_bug.cgi?id=702164
2013-06-21 20:03:53 +02:00
row_box = gtk_widget_get_parent (GTK_WIDGET (button));
row = gtk_widget_get_parent (row_box);
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
list = gtk_widget_get_parent (row);
gtk_container_remove (GTK_CONTAINER (list), row);
ce_page_changed (CE_PAGE (page));
update_row_sensitivity (page, list);
}
network: Use a table-like widget to edit routes According to the latest mockups for the connection editor dialog [1], the IPv4 and IPv6 pages are supposed to use a table-like editor to manage the routes. This editor is not only easier to comprehend, but also improves the size of the dialog, requiring much less vertical space to present the routes. The current implementation, however, uses a vertical layout and a toolbar, which is inefficient in its usage of space. Fix that by implementing the table-like editor widget, both in IPv4 and IPv6 pages. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 13:04:52 -03:00
static gboolean
validate_row (GtkWidget *row)
{
GtkWidget *box;
GList *children, *l;
gboolean valid;
valid = FALSE;
box = gtk_bin_get_child (GTK_BIN (row));
children = gtk_container_get_children (GTK_CONTAINER (box));
for (l = children; l != NULL; l = l->next) {
if (!GTK_IS_ENTRY (l->data))
continue;
valid = valid || gtk_entry_get_text_length (l->data) > 0;
}
g_list_free (children);
return valid;
}
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
static gint
sort_first_last (gconstpointer a, gconstpointer b, gpointer data)
{
gboolean afirst, bfirst, alast, blast;
afirst = GPOINTER_TO_INT (g_object_get_data (G_OBJECT (a), "first"));
bfirst = GPOINTER_TO_INT (g_object_get_data (G_OBJECT (b), "first"));
alast = GPOINTER_TO_INT (g_object_get_data (G_OBJECT (a), "last"));
blast = GPOINTER_TO_INT (g_object_get_data (G_OBJECT (b), "last"));
if (afirst)
return -1;
if (bfirst)
return 1;
if (alast)
return 1;
if (blast)
return -1;
return 0;
}
static void
add_address_row (CEPageIP6 *page,
const gchar *address,
const gchar *network,
const gchar *gateway)
{
network: Use a table-like widget in address editor According to the latest mockups for the connection editor dialog [1], the IPv4 and IPv6 pages are supposed to use a table-like editor to manage the addresses, in a similar fashion of what was done to the routes editor. This way of editing is not only easier to comprehend, but also improves the size of the dialog, requiring much less vertical space to present the routes. The current implementation, however, uses a vertical layout and a toolbar, which is inefficient in its usage of space. Fix that by implementing the table-like editor widget, both in IPv4 and IPv6 pages. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 15:02:45 -03:00
GtkSizeGroup *group;
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
GtkWidget *row;
network: Use a table-like widget in address editor According to the latest mockups for the connection editor dialog [1], the IPv4 and IPv6 pages are supposed to use a table-like editor to manage the addresses, in a similar fashion of what was done to the routes editor. This way of editing is not only easier to comprehend, but also improves the size of the dialog, requiring much less vertical space to present the routes. The current implementation, however, uses a vertical layout and a toolbar, which is inefficient in its usage of space. Fix that by implementing the table-like editor widget, both in IPv4 and IPv6 pages. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 15:02:45 -03:00
GtkWidget *row_box;
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
GtkWidget *widget;
GtkWidget *delete_button;
GtkWidget *image;
network: Convert connection editor to GtkListBox https://bugzilla.gnome.org/show_bug.cgi?id=702164
2013-06-21 20:03:53 +02:00
row = gtk_list_box_row_new ();
network: Use a table-like widget in address editor According to the latest mockups for the connection editor dialog [1], the IPv4 and IPv6 pages are supposed to use a table-like editor to manage the addresses, in a similar fashion of what was done to the routes editor. This way of editing is not only easier to comprehend, but also improves the size of the dialog, requiring much less vertical space to present the routes. The current implementation, however, uses a vertical layout and a toolbar, which is inefficient in its usage of space. Fix that by implementing the table-like editor widget, both in IPv4 and IPv6 pages. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 15:02:45 -03:00
row_box = gtk_box_new (GTK_ORIENTATION_HORIZONTAL, 0);
gtk_style_context_add_class (gtk_widget_get_style_context (row_box), "linked");
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
widget = gtk_entry_new ();
g_signal_connect_swapped (widget, "changed", G_CALLBACK (ce_page_changed), page);
network: Use a table-like widget in address editor According to the latest mockups for the connection editor dialog [1], the IPv4 and IPv6 pages are supposed to use a table-like editor to manage the addresses, in a similar fashion of what was done to the routes editor. This way of editing is not only easier to comprehend, but also improves the size of the dialog, requiring much less vertical space to present the routes. The current implementation, however, uses a vertical layout and a toolbar, which is inefficient in its usage of space. Fix that by implementing the table-like editor widget, both in IPv4 and IPv6 pages. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 15:02:45 -03:00
g_signal_connect_swapped (widget, "activate", G_CALLBACK (ensure_empty_address_row), page);
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
g_object_set_data (G_OBJECT (row), "address", widget);
gtk_entry_set_text (GTK_ENTRY (widget), address);
network: Use a table-like widget in address editor According to the latest mockups for the connection editor dialog [1], the IPv4 and IPv6 pages are supposed to use a table-like editor to manage the addresses, in a similar fashion of what was done to the routes editor. This way of editing is not only easier to comprehend, but also improves the size of the dialog, requiring much less vertical space to present the routes. The current implementation, however, uses a vertical layout and a toolbar, which is inefficient in its usage of space. Fix that by implementing the table-like editor widget, both in IPv4 and IPv6 pages. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 15:02:45 -03:00
gtk_entry_set_width_chars (GTK_ENTRY (widget), 16);
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
gtk_widget_set_hexpand (widget, TRUE);
network: Use a table-like widget in address editor According to the latest mockups for the connection editor dialog [1], the IPv4 and IPv6 pages are supposed to use a table-like editor to manage the addresses, in a similar fashion of what was done to the routes editor. This way of editing is not only easier to comprehend, but also improves the size of the dialog, requiring much less vertical space to present the routes. The current implementation, however, uses a vertical layout and a toolbar, which is inefficient in its usage of space. Fix that by implementing the table-like editor widget, both in IPv4 and IPv6 pages. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 15:02:45 -03:00
gtk_container_add (GTK_CONTAINER (row_box), widget);
network: Set mnemonic labels for editable text fields for a11y https://bugzilla.gnome.org/show_bug.cgi?id=693657
2013-02-12 11:33:59 -05:00
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
widget = gtk_entry_new ();
g_signal_connect_swapped (widget, "changed", G_CALLBACK (ce_page_changed), page);
network: Use a table-like widget in address editor According to the latest mockups for the connection editor dialog [1], the IPv4 and IPv6 pages are supposed to use a table-like editor to manage the addresses, in a similar fashion of what was done to the routes editor. This way of editing is not only easier to comprehend, but also improves the size of the dialog, requiring much less vertical space to present the routes. The current implementation, however, uses a vertical layout and a toolbar, which is inefficient in its usage of space. Fix that by implementing the table-like editor widget, both in IPv4 and IPv6 pages. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 15:02:45 -03:00
g_signal_connect_swapped (widget, "activate", G_CALLBACK (ensure_empty_address_row), page);
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
g_object_set_data (G_OBJECT (row), "prefix", widget);
gtk_entry_set_text (GTK_ENTRY (widget), network);
network: Use a table-like widget in address editor According to the latest mockups for the connection editor dialog [1], the IPv4 and IPv6 pages are supposed to use a table-like editor to manage the addresses, in a similar fashion of what was done to the routes editor. This way of editing is not only easier to comprehend, but also improves the size of the dialog, requiring much less vertical space to present the routes. The current implementation, however, uses a vertical layout and a toolbar, which is inefficient in its usage of space. Fix that by implementing the table-like editor widget, both in IPv4 and IPv6 pages. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 15:02:45 -03:00
gtk_entry_set_width_chars (GTK_ENTRY (widget), 16);
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
gtk_widget_set_hexpand (widget, TRUE);
network: Use a table-like widget in address editor According to the latest mockups for the connection editor dialog [1], the IPv4 and IPv6 pages are supposed to use a table-like editor to manage the addresses, in a similar fashion of what was done to the routes editor. This way of editing is not only easier to comprehend, but also improves the size of the dialog, requiring much less vertical space to present the routes. The current implementation, however, uses a vertical layout and a toolbar, which is inefficient in its usage of space. Fix that by implementing the table-like editor widget, both in IPv4 and IPv6 pages. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 15:02:45 -03:00
gtk_container_add (GTK_CONTAINER (row_box), widget);
network: Set mnemonic labels for editable text fields for a11y https://bugzilla.gnome.org/show_bug.cgi?id=693657
2013-02-12 11:33:59 -05:00
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
widget = gtk_entry_new ();
g_signal_connect_swapped (widget, "changed", G_CALLBACK (ce_page_changed), page);
network: Use a table-like widget in address editor According to the latest mockups for the connection editor dialog [1], the IPv4 and IPv6 pages are supposed to use a table-like editor to manage the addresses, in a similar fashion of what was done to the routes editor. This way of editing is not only easier to comprehend, but also improves the size of the dialog, requiring much less vertical space to present the routes. The current implementation, however, uses a vertical layout and a toolbar, which is inefficient in its usage of space. Fix that by implementing the table-like editor widget, both in IPv4 and IPv6 pages. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 15:02:45 -03:00
g_signal_connect_swapped (widget, "activate", G_CALLBACK (ensure_empty_address_row), page);
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
g_object_set_data (G_OBJECT (row), "gateway", widget);
network: Fix warning if IPv6 gateway is empty GtkEntry doesn't like NULL text. https://bugzilla.gnome.org/show_bug.cgi?id=769230
2016-06-14 13:46:16 +02:00
gtk_entry_set_text (GTK_ENTRY (widget), gateway ? gateway : "");
network: Use a table-like widget in address editor According to the latest mockups for the connection editor dialog [1], the IPv4 and IPv6 pages are supposed to use a table-like editor to manage the addresses, in a similar fashion of what was done to the routes editor. This way of editing is not only easier to comprehend, but also improves the size of the dialog, requiring much less vertical space to present the routes. The current implementation, however, uses a vertical layout and a toolbar, which is inefficient in its usage of space. Fix that by implementing the table-like editor widget, both in IPv4 and IPv6 pages. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 15:02:45 -03:00
gtk_entry_set_width_chars (GTK_ENTRY (widget), 16);
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
gtk_widget_set_hexpand (widget, TRUE);
network: Use a table-like widget in address editor According to the latest mockups for the connection editor dialog [1], the IPv4 and IPv6 pages are supposed to use a table-like editor to manage the addresses, in a similar fashion of what was done to the routes editor. This way of editing is not only easier to comprehend, but also improves the size of the dialog, requiring much less vertical space to present the routes. The current implementation, however, uses a vertical layout and a toolbar, which is inefficient in its usage of space. Fix that by implementing the table-like editor widget, both in IPv4 and IPv6 pages. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 15:02:45 -03:00
gtk_container_add (GTK_CONTAINER (row_box), widget);
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
delete_button = gtk_button_new ();
network: Use a table-like widget in address editor According to the latest mockups for the connection editor dialog [1], the IPv4 and IPv6 pages are supposed to use a table-like editor to manage the addresses, in a similar fashion of what was done to the routes editor. This way of editing is not only easier to comprehend, but also improves the size of the dialog, requiring much less vertical space to present the routes. The current implementation, however, uses a vertical layout and a toolbar, which is inefficient in its usage of space. Fix that by implementing the table-like editor widget, both in IPv4 and IPv6 pages. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 15:02:45 -03:00
gtk_widget_set_sensitive (delete_button, FALSE);
network: unfuzzy symbolic buttons and make them square Use the 'image-button' style class to make symbolic buttons square (as supported by latest Adwaita), and make sure to use the correct icon size for all symbolics to avoid fuzzyness. https://bugzilla.gnome.org/show_bug.cgi?id=693357
2013-02-07 16:23:54 -05:00
gtk_style_context_add_class (gtk_widget_get_style_context (delete_button), "image-button");
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
g_signal_connect (delete_button, "clicked", G_CALLBACK (remove_row), page);
network: Use a table-like widget in address editor According to the latest mockups for the connection editor dialog [1], the IPv4 and IPv6 pages are supposed to use a table-like editor to manage the addresses, in a similar fashion of what was done to the routes editor. This way of editing is not only easier to comprehend, but also improves the size of the dialog, requiring much less vertical space to present the routes. The current implementation, however, uses a vertical layout and a toolbar, which is inefficient in its usage of space. Fix that by implementing the table-like editor widget, both in IPv4 and IPv6 pages. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 15:02:45 -03:00
image = gtk_image_new_from_icon_name ("edit-delete-symbolic", GTK_ICON_SIZE_MENU);
network: Add accessibile labels to buttons in the popup dialogs https://bugzilla.gnome.org/show_bug.cgi?id=693657
2013-02-12 11:13:08 -05:00
atk_object_set_name (gtk_widget_get_accessible (delete_button), _("Delete Address"));
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
gtk_button_set_image (GTK_BUTTON (delete_button), image);
network: Use a table-like widget in address editor According to the latest mockups for the connection editor dialog [1], the IPv4 and IPv6 pages are supposed to use a table-like editor to manage the addresses, in a similar fashion of what was done to the routes editor. This way of editing is not only easier to comprehend, but also improves the size of the dialog, requiring much less vertical space to present the routes. The current implementation, however, uses a vertical layout and a toolbar, which is inefficient in its usage of space. Fix that by implementing the table-like editor widget, both in IPv4 and IPv6 pages. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 15:02:45 -03:00
gtk_container_add (GTK_CONTAINER (row_box), delete_button);
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
g_object_set_data (G_OBJECT (row), "delete-button", delete_button);
network: Use a table-like widget in address editor According to the latest mockups for the connection editor dialog [1], the IPv4 and IPv6 pages are supposed to use a table-like editor to manage the addresses, in a similar fashion of what was done to the routes editor. This way of editing is not only easier to comprehend, but also improves the size of the dialog, requiring much less vertical space to present the routes. The current implementation, however, uses a vertical layout and a toolbar, which is inefficient in its usage of space. Fix that by implementing the table-like editor widget, both in IPv4 and IPv6 pages. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 15:02:45 -03:00
group = GTK_SIZE_GROUP (gtk_builder_get_object (CE_PAGE (page)->builder, "address_sizegroup"));
gtk_size_group_add_widget (group, delete_button);
network: Convert connection editor to GtkListBox https://bugzilla.gnome.org/show_bug.cgi?id=702164
2013-06-21 20:03:53 +02:00
network: Use a table-like widget in address editor According to the latest mockups for the connection editor dialog [1], the IPv4 and IPv6 pages are supposed to use a table-like editor to manage the addresses, in a similar fashion of what was done to the routes editor. This way of editing is not only easier to comprehend, but also improves the size of the dialog, requiring much less vertical space to present the routes. The current implementation, however, uses a vertical layout and a toolbar, which is inefficient in its usage of space. Fix that by implementing the table-like editor widget, both in IPv4 and IPv6 pages. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 15:02:45 -03:00
gtk_container_add (GTK_CONTAINER (row), row_box);
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
gtk_widget_show_all (row);
gtk_container_add (GTK_CONTAINER (page->address_list), row);
update_row_sensitivity (page, page->address_list);
}
static void
network: Use a table-like widget in address editor According to the latest mockups for the connection editor dialog [1], the IPv4 and IPv6 pages are supposed to use a table-like editor to manage the addresses, in a similar fashion of what was done to the routes editor. This way of editing is not only easier to comprehend, but also improves the size of the dialog, requiring much less vertical space to present the routes. The current implementation, however, uses a vertical layout and a toolbar, which is inefficient in its usage of space. Fix that by implementing the table-like editor widget, both in IPv4 and IPv6 pages. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 15:02:45 -03:00
ensure_empty_address_row (CEPageIP6 *page)
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
{
network: Use a table-like widget in address editor According to the latest mockups for the connection editor dialog [1], the IPv4 and IPv6 pages are supposed to use a table-like editor to manage the addresses, in a similar fashion of what was done to the routes editor. This way of editing is not only easier to comprehend, but also improves the size of the dialog, requiring much less vertical space to present the routes. The current implementation, however, uses a vertical layout and a toolbar, which is inefficient in its usage of space. Fix that by implementing the table-like editor widget, both in IPv4 and IPv6 pages. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 15:02:45 -03:00
GList *children, *l;
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
network: Use a table-like widget in address editor According to the latest mockups for the connection editor dialog [1], the IPv4 and IPv6 pages are supposed to use a table-like editor to manage the addresses, in a similar fashion of what was done to the routes editor. This way of editing is not only easier to comprehend, but also improves the size of the dialog, requiring much less vertical space to present the routes. The current implementation, however, uses a vertical layout and a toolbar, which is inefficient in its usage of space. Fix that by implementing the table-like editor widget, both in IPv4 and IPv6 pages. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 15:02:45 -03:00
children = gtk_container_get_children (GTK_CONTAINER (page->address_list));
l = children;
while (l && l->next)
l = l->next;
/* Add the last, stub row if needed*/
if (!l || validate_row (l->data))
add_address_row (page, "", "", "");
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
network: Use a table-like widget in address editor According to the latest mockups for the connection editor dialog [1], the IPv4 and IPv6 pages are supposed to use a table-like editor to manage the addresses, in a similar fashion of what was done to the routes editor. This way of editing is not only easier to comprehend, but also improves the size of the dialog, requiring much less vertical space to present the routes. The current implementation, however, uses a vertical layout and a toolbar, which is inefficient in its usage of space. Fix that by implementing the table-like editor widget, both in IPv4 and IPv6 pages. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 15:02:45 -03:00
g_list_free (children);
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
}
static void
add_address_section (CEPageIP6 *page)
{
GtkWidget *widget;
GtkWidget *list;
gint i;
widget = GTK_WIDGET (gtk_builder_get_object (CE_PAGE (page)->builder, "address_section"));
network: Convert connection editor to GtkListBox https://bugzilla.gnome.org/show_bug.cgi?id=702164
2013-06-21 20:03:53 +02:00
page->address_list = list = gtk_list_box_new ();
gtk_list_box_set_selection_mode (GTK_LIST_BOX (list), GTK_SELECTION_NONE);
network: Use new listbox helpers https://bugzilla.gnome.org/show_bug.cgi?id=732106
2014-06-23 15:37:34 +02:00
gtk_list_box_set_header_func (GTK_LIST_BOX (list), cc_list_box_update_header_func, NULL, NULL);
network: Convert connection editor to GtkListBox https://bugzilla.gnome.org/show_bug.cgi?id=702164
2013-06-21 20:03:53 +02:00
gtk_list_box_set_sort_func (GTK_LIST_BOX (list), (GtkListBoxSortFunc)sort_first_last, NULL, NULL);
network: Use a table-like widget in address editor According to the latest mockups for the connection editor dialog [1], the IPv4 and IPv6 pages are supposed to use a table-like editor to manage the addresses, in a similar fashion of what was done to the routes editor. This way of editing is not only easier to comprehend, but also improves the size of the dialog, requiring much less vertical space to present the routes. The current implementation, however, uses a vertical layout and a toolbar, which is inefficient in its usage of space. Fix that by implementing the table-like editor widget, both in IPv4 and IPv6 pages. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 15:02:45 -03:00
gtk_container_add (GTK_CONTAINER (widget), list);
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
network: Port to libnm 1.2 We also remove support for WiMAX (now unsupported by NetworkManager), and InfiniBand (Enterprise feature), and the use of the deprecated NM_SETTING_WIRELESS_SEC property. With help from network-manager-applet patches by Jiří Klimeš and Dan Winship. https://bugzilla.gnome.org/show_bug.cgi?id=765910
2016-04-29 16:05:54 +02:00
for (i = 0; i < nm_setting_ip_config_get_num_addresses (page->setting); i++) {
NMIPAddress *addr;
char *netmask;
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
network: Port to libnm 1.2 We also remove support for WiMAX (now unsupported by NetworkManager), and InfiniBand (Enterprise feature), and the use of the deprecated NM_SETTING_WIRELESS_SEC property. With help from network-manager-applet patches by Jiří Klimeš and Dan Winship. https://bugzilla.gnome.org/show_bug.cgi?id=765910
2016-04-29 16:05:54 +02:00
addr = nm_setting_ip_config_get_address (page->setting, i);
netmask = g_strdup_printf ("%u", nm_ip_address_get_prefix (addr));
add_address_row (page, nm_ip_address_get_address (addr), netmask,
i == 0 ? nm_setting_ip_config_get_gateway (page->setting) : NULL);
g_free (netmask);
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
}
network: Port to libnm 1.2 We also remove support for WiMAX (now unsupported by NetworkManager), and InfiniBand (Enterprise feature), and the use of the deprecated NM_SETTING_WIRELESS_SEC property. With help from network-manager-applet patches by Jiří Klimeš and Dan Winship. https://bugzilla.gnome.org/show_bug.cgi?id=765910
2016-04-29 16:05:54 +02:00
if (nm_setting_ip_config_get_num_addresses (page->setting) == 0)
network: Use a table-like widget in address editor According to the latest mockups for the connection editor dialog [1], the IPv4 and IPv6 pages are supposed to use a table-like editor to manage the addresses, in a similar fashion of what was done to the routes editor. This way of editing is not only easier to comprehend, but also improves the size of the dialog, requiring much less vertical space to present the routes. The current implementation, however, uses a vertical layout and a toolbar, which is inefficient in its usage of space. Fix that by implementing the table-like editor widget, both in IPv4 and IPv6 pages. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 15:02:45 -03:00
ensure_empty_address_row (page);
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
gtk_widget_show_all (widget);
}
static void
add_dns_section (CEPageIP6 *page)
{
network: Simplify DNS management in connection editor When editing the DNS servers of a given connection, a simple entry is enough to display and edit the DNS servers. The user can separate IP addresses with commas. This is exemplified by the mockup at [1]. This, however, is not the current implementation, which uses a combination of listbox rows, entries and buttons to manage that with added complexity. Fix that by using an entry to handle the DNS servers. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 02:44:58 -03:00
GtkEntry *entry;
GString *string;
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
gint i;
page->auto_dns = GTK_SWITCH (gtk_builder_get_object (CE_PAGE (page)->builder, "auto_dns_switch"));
network: Port to libnm 1.2 We also remove support for WiMAX (now unsupported by NetworkManager), and InfiniBand (Enterprise feature), and the use of the deprecated NM_SETTING_WIRELESS_SEC property. With help from network-manager-applet patches by Jiří Klimeš and Dan Winship. https://bugzilla.gnome.org/show_bug.cgi?id=765910
2016-04-29 16:05:54 +02:00
gtk_switch_set_active (page->auto_dns, !nm_setting_ip_config_get_ignore_auto_dns (page->setting));
network: Fix compile-time warnings
2013-02-15 13:44:49 +01:00
g_signal_connect (page->auto_dns, "notify::active", G_CALLBACK (switch_toggled), page);
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
network: Simplify DNS management in connection editor When editing the DNS servers of a given connection, a simple entry is enough to display and edit the DNS servers. The user can separate IP addresses with commas. This is exemplified by the mockup at [1]. This, however, is not the current implementation, which uses a combination of listbox rows, entries and buttons to manage that with added complexity. Fix that by using an entry to handle the DNS servers. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 02:44:58 -03:00
page->dns_entry = GTK_WIDGET (gtk_builder_get_object (CE_PAGE (page)->builder, "dns_entry"));
entry = GTK_ENTRY (page->dns_entry);
string = g_string_new ("");
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
network: Port to libnm 1.2 We also remove support for WiMAX (now unsupported by NetworkManager), and InfiniBand (Enterprise feature), and the use of the deprecated NM_SETTING_WIRELESS_SEC property. With help from network-manager-applet patches by Jiří Klimeš and Dan Winship. https://bugzilla.gnome.org/show_bug.cgi?id=765910
2016-04-29 16:05:54 +02:00
for (i = 0; i < nm_setting_ip_config_get_num_dns (page->setting); i++) {
const char *address;
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
network: Port to libnm 1.2 We also remove support for WiMAX (now unsupported by NetworkManager), and InfiniBand (Enterprise feature), and the use of the deprecated NM_SETTING_WIRELESS_SEC property. With help from network-manager-applet patches by Jiří Klimeš and Dan Winship. https://bugzilla.gnome.org/show_bug.cgi?id=765910
2016-04-29 16:05:54 +02:00
address = nm_setting_ip_config_get_dns (page->setting, i);
network: Simplify DNS management in connection editor When editing the DNS servers of a given connection, a simple entry is enough to display and edit the DNS servers. The user can separate IP addresses with commas. This is exemplified by the mockup at [1]. This, however, is not the current implementation, which uses a combination of listbox rows, entries and buttons to manage that with added complexity. Fix that by using an entry to handle the DNS servers. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 02:44:58 -03:00
if (i > 0)
g_string_append (string, ", ");
g_string_append (string, address);
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
}
network: Simplify DNS management in connection editor When editing the DNS servers of a given connection, a simple entry is enough to display and edit the DNS servers. The user can separate IP addresses with commas. This is exemplified by the mockup at [1]. This, however, is not the current implementation, which uses a combination of listbox rows, entries and buttons to manage that with added complexity. Fix that by using an entry to handle the DNS servers. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 02:44:58 -03:00
gtk_entry_set_text (entry, string->str);
g_signal_connect_swapped (page->dns_entry, "notify::text", G_CALLBACK (ce_page_changed), page);
g_string_free (string, TRUE);
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
}
static void
add_route_row (CEPageIP6 *page,
const gchar *address,
network: Port to libnm 1.2 We also remove support for WiMAX (now unsupported by NetworkManager), and InfiniBand (Enterprise feature), and the use of the deprecated NM_SETTING_WIRELESS_SEC property. With help from network-manager-applet patches by Jiří Klimeš and Dan Winship. https://bugzilla.gnome.org/show_bug.cgi?id=765910
2016-04-29 16:05:54 +02:00
const gchar *prefix,
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
const gchar *gateway,
network: Port to libnm 1.2 We also remove support for WiMAX (now unsupported by NetworkManager), and InfiniBand (Enterprise feature), and the use of the deprecated NM_SETTING_WIRELESS_SEC property. With help from network-manager-applet patches by Jiří Klimeš and Dan Winship. https://bugzilla.gnome.org/show_bug.cgi?id=765910
2016-04-29 16:05:54 +02:00
const gchar *metric)
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
{
network: Use a table-like widget to edit routes According to the latest mockups for the connection editor dialog [1], the IPv4 and IPv6 pages are supposed to use a table-like editor to manage the routes. This editor is not only easier to comprehend, but also improves the size of the dialog, requiring much less vertical space to present the routes. The current implementation, however, uses a vertical layout and a toolbar, which is inefficient in its usage of space. Fix that by implementing the table-like editor widget, both in IPv4 and IPv6 pages. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 13:04:52 -03:00
GtkSizeGroup *group;
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
GtkWidget *row;
network: Use a table-like widget to edit routes According to the latest mockups for the connection editor dialog [1], the IPv4 and IPv6 pages are supposed to use a table-like editor to manage the routes. This editor is not only easier to comprehend, but also improves the size of the dialog, requiring much less vertical space to present the routes. The current implementation, however, uses a vertical layout and a toolbar, which is inefficient in its usage of space. Fix that by implementing the table-like editor widget, both in IPv4 and IPv6 pages. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 13:04:52 -03:00
GtkWidget *row_box;
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
GtkWidget *widget;
GtkWidget *delete_button;
GtkWidget *image;
network: Convert connection editor to GtkListBox https://bugzilla.gnome.org/show_bug.cgi?id=702164
2013-06-21 20:03:53 +02:00
row = gtk_list_box_row_new ();
network: Use a table-like widget to edit routes According to the latest mockups for the connection editor dialog [1], the IPv4 and IPv6 pages are supposed to use a table-like editor to manage the routes. This editor is not only easier to comprehend, but also improves the size of the dialog, requiring much less vertical space to present the routes. The current implementation, however, uses a vertical layout and a toolbar, which is inefficient in its usage of space. Fix that by implementing the table-like editor widget, both in IPv4 and IPv6 pages. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 13:04:52 -03:00
row_box = gtk_box_new (GTK_ORIENTATION_HORIZONTAL, 0);
gtk_style_context_add_class (gtk_widget_get_style_context (row_box), "linked");
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
widget = gtk_entry_new ();
g_signal_connect_swapped (widget, "changed", G_CALLBACK (ce_page_changed), page);
network: Use a table-like widget to edit routes According to the latest mockups for the connection editor dialog [1], the IPv4 and IPv6 pages are supposed to use a table-like editor to manage the routes. This editor is not only easier to comprehend, but also improves the size of the dialog, requiring much less vertical space to present the routes. The current implementation, however, uses a vertical layout and a toolbar, which is inefficient in its usage of space. Fix that by implementing the table-like editor widget, both in IPv4 and IPv6 pages. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 13:04:52 -03:00
g_signal_connect_swapped (widget, "activate", G_CALLBACK (ensure_empty_routes_row), page);
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
g_object_set_data (G_OBJECT (row), "address", widget);
gtk_entry_set_text (GTK_ENTRY (widget), address);
network: Use a table-like widget to edit routes According to the latest mockups for the connection editor dialog [1], the IPv4 and IPv6 pages are supposed to use a table-like editor to manage the routes. This editor is not only easier to comprehend, but also improves the size of the dialog, requiring much less vertical space to present the routes. The current implementation, however, uses a vertical layout and a toolbar, which is inefficient in its usage of space. Fix that by implementing the table-like editor widget, both in IPv4 and IPv6 pages. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 13:04:52 -03:00
gtk_entry_set_width_chars (GTK_ENTRY (widget), 16);
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
gtk_widget_set_hexpand (widget, TRUE);
network: Use a table-like widget to edit routes According to the latest mockups for the connection editor dialog [1], the IPv4 and IPv6 pages are supposed to use a table-like editor to manage the routes. This editor is not only easier to comprehend, but also improves the size of the dialog, requiring much less vertical space to present the routes. The current implementation, however, uses a vertical layout and a toolbar, which is inefficient in its usage of space. Fix that by implementing the table-like editor widget, both in IPv4 and IPv6 pages. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 13:04:52 -03:00
gtk_container_add (GTK_CONTAINER (row_box), widget);
network: Set mnemonic labels for editable text fields for a11y https://bugzilla.gnome.org/show_bug.cgi?id=693657
2013-02-12 11:33:59 -05:00
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
widget = gtk_entry_new ();
g_signal_connect_swapped (widget, "changed", G_CALLBACK (ce_page_changed), page);
network: Use a table-like widget to edit routes According to the latest mockups for the connection editor dialog [1], the IPv4 and IPv6 pages are supposed to use a table-like editor to manage the routes. This editor is not only easier to comprehend, but also improves the size of the dialog, requiring much less vertical space to present the routes. The current implementation, however, uses a vertical layout and a toolbar, which is inefficient in its usage of space. Fix that by implementing the table-like editor widget, both in IPv4 and IPv6 pages. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 13:04:52 -03:00
g_signal_connect_swapped (widget, "activate", G_CALLBACK (ensure_empty_routes_row), page);
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
g_object_set_data (G_OBJECT (row), "prefix", widget);
network: Port to libnm 1.2 We also remove support for WiMAX (now unsupported by NetworkManager), and InfiniBand (Enterprise feature), and the use of the deprecated NM_SETTING_WIRELESS_SEC property. With help from network-manager-applet patches by Jiří Klimeš and Dan Winship. https://bugzilla.gnome.org/show_bug.cgi?id=765910
2016-04-29 16:05:54 +02:00
gtk_entry_set_text (GTK_ENTRY (widget), prefix ? prefix : "");
network: Use a table-like widget to edit routes According to the latest mockups for the connection editor dialog [1], the IPv4 and IPv6 pages are supposed to use a table-like editor to manage the routes. This editor is not only easier to comprehend, but also improves the size of the dialog, requiring much less vertical space to present the routes. The current implementation, however, uses a vertical layout and a toolbar, which is inefficient in its usage of space. Fix that by implementing the table-like editor widget, both in IPv4 and IPv6 pages. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 13:04:52 -03:00
gtk_entry_set_width_chars (GTK_ENTRY (widget), 16);
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
gtk_widget_set_hexpand (widget, TRUE);
network: Use a table-like widget to edit routes According to the latest mockups for the connection editor dialog [1], the IPv4 and IPv6 pages are supposed to use a table-like editor to manage the routes. This editor is not only easier to comprehend, but also improves the size of the dialog, requiring much less vertical space to present the routes. The current implementation, however, uses a vertical layout and a toolbar, which is inefficient in its usage of space. Fix that by implementing the table-like editor widget, both in IPv4 and IPv6 pages. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 13:04:52 -03:00
gtk_container_add (GTK_CONTAINER (row_box), widget);
network: Set mnemonic labels for editable text fields for a11y https://bugzilla.gnome.org/show_bug.cgi?id=693657
2013-02-12 11:33:59 -05:00
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
widget = gtk_entry_new ();
g_signal_connect_swapped (widget, "changed", G_CALLBACK (ce_page_changed), page);
network: Use a table-like widget to edit routes According to the latest mockups for the connection editor dialog [1], the IPv4 and IPv6 pages are supposed to use a table-like editor to manage the routes. This editor is not only easier to comprehend, but also improves the size of the dialog, requiring much less vertical space to present the routes. The current implementation, however, uses a vertical layout and a toolbar, which is inefficient in its usage of space. Fix that by implementing the table-like editor widget, both in IPv4 and IPv6 pages. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 13:04:52 -03:00
g_signal_connect_swapped (widget, "activate", G_CALLBACK (ensure_empty_routes_row), page);
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
g_object_set_data (G_OBJECT (row), "gateway", widget);
gtk_entry_set_text (GTK_ENTRY (widget), gateway);
network: Use a table-like widget to edit routes According to the latest mockups for the connection editor dialog [1], the IPv4 and IPv6 pages are supposed to use a table-like editor to manage the routes. This editor is not only easier to comprehend, but also improves the size of the dialog, requiring much less vertical space to present the routes. The current implementation, however, uses a vertical layout and a toolbar, which is inefficient in its usage of space. Fix that by implementing the table-like editor widget, both in IPv4 and IPv6 pages. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 13:04:52 -03:00
gtk_entry_set_width_chars (GTK_ENTRY (widget), 16);
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
gtk_widget_set_hexpand (widget, TRUE);
network: Use a table-like widget to edit routes According to the latest mockups for the connection editor dialog [1], the IPv4 and IPv6 pages are supposed to use a table-like editor to manage the routes. This editor is not only easier to comprehend, but also improves the size of the dialog, requiring much less vertical space to present the routes. The current implementation, however, uses a vertical layout and a toolbar, which is inefficient in its usage of space. Fix that by implementing the table-like editor widget, both in IPv4 and IPv6 pages. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 13:04:52 -03:00
gtk_container_add (GTK_CONTAINER (row_box), widget);
network: Set mnemonic labels for editable text fields for a11y https://bugzilla.gnome.org/show_bug.cgi?id=693657
2013-02-12 11:33:59 -05:00
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
widget = gtk_entry_new ();
g_signal_connect_swapped (widget, "changed", G_CALLBACK (ce_page_changed), page);
network: Use a table-like widget to edit routes According to the latest mockups for the connection editor dialog [1], the IPv4 and IPv6 pages are supposed to use a table-like editor to manage the routes. This editor is not only easier to comprehend, but also improves the size of the dialog, requiring much less vertical space to present the routes. The current implementation, however, uses a vertical layout and a toolbar, which is inefficient in its usage of space. Fix that by implementing the table-like editor widget, both in IPv4 and IPv6 pages. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 13:04:52 -03:00
g_signal_connect_swapped (widget, "activate", G_CALLBACK (ensure_empty_routes_row), page);
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
g_object_set_data (G_OBJECT (row), "metric", widget);
network: Port to libnm 1.2 We also remove support for WiMAX (now unsupported by NetworkManager), and InfiniBand (Enterprise feature), and the use of the deprecated NM_SETTING_WIRELESS_SEC property. With help from network-manager-applet patches by Jiří Klimeš and Dan Winship. https://bugzilla.gnome.org/show_bug.cgi?id=765910
2016-04-29 16:05:54 +02:00
gtk_entry_set_text (GTK_ENTRY (widget), metric ? metric : "");
network: Use a table-like widget to edit routes According to the latest mockups for the connection editor dialog [1], the IPv4 and IPv6 pages are supposed to use a table-like editor to manage the routes. This editor is not only easier to comprehend, but also improves the size of the dialog, requiring much less vertical space to present the routes. The current implementation, however, uses a vertical layout and a toolbar, which is inefficient in its usage of space. Fix that by implementing the table-like editor widget, both in IPv4 and IPv6 pages. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 13:04:52 -03:00
gtk_entry_set_width_chars (GTK_ENTRY (widget), 5);
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
gtk_widget_set_hexpand (widget, TRUE);
network: Use a table-like widget to edit routes According to the latest mockups for the connection editor dialog [1], the IPv4 and IPv6 pages are supposed to use a table-like editor to manage the routes. This editor is not only easier to comprehend, but also improves the size of the dialog, requiring much less vertical space to present the routes. The current implementation, however, uses a vertical layout and a toolbar, which is inefficient in its usage of space. Fix that by implementing the table-like editor widget, both in IPv4 and IPv6 pages. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 13:04:52 -03:00
gtk_container_add (GTK_CONTAINER (row_box), widget);
group = GTK_SIZE_GROUP (gtk_builder_get_object (CE_PAGE (page)->builder, "routes_metric_sizegroup"));
gtk_size_group_add_widget (group, widget);
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
delete_button = gtk_button_new ();
network: unfuzzy symbolic buttons and make them square Use the 'image-button' style class to make symbolic buttons square (as supported by latest Adwaita), and make sure to use the correct icon size for all symbolics to avoid fuzzyness. https://bugzilla.gnome.org/show_bug.cgi?id=693357
2013-02-07 16:23:54 -05:00
gtk_style_context_add_class (gtk_widget_get_style_context (delete_button), "image-button");
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
g_signal_connect (delete_button, "clicked", G_CALLBACK (remove_row), page);
network: Use a table-like widget to edit routes According to the latest mockups for the connection editor dialog [1], the IPv4 and IPv6 pages are supposed to use a table-like editor to manage the routes. This editor is not only easier to comprehend, but also improves the size of the dialog, requiring much less vertical space to present the routes. The current implementation, however, uses a vertical layout and a toolbar, which is inefficient in its usage of space. Fix that by implementing the table-like editor widget, both in IPv4 and IPv6 pages. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 13:04:52 -03:00
image = gtk_image_new_from_icon_name ("edit-delete-symbolic", GTK_ICON_SIZE_MENU);
network: Add accessibile labels to buttons in the popup dialogs https://bugzilla.gnome.org/show_bug.cgi?id=693657
2013-02-12 11:13:08 -05:00
atk_object_set_name (gtk_widget_get_accessible (delete_button), _("Delete Route"));
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
gtk_button_set_image (GTK_BUTTON (delete_button), image);
gtk_widget_set_halign (delete_button, GTK_ALIGN_CENTER);
gtk_widget_set_valign (delete_button, GTK_ALIGN_CENTER);
network: Use a table-like widget to edit routes According to the latest mockups for the connection editor dialog [1], the IPv4 and IPv6 pages are supposed to use a table-like editor to manage the routes. This editor is not only easier to comprehend, but also improves the size of the dialog, requiring much less vertical space to present the routes. The current implementation, however, uses a vertical layout and a toolbar, which is inefficient in its usage of space. Fix that by implementing the table-like editor widget, both in IPv4 and IPv6 pages. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 13:04:52 -03:00
gtk_container_add (GTK_CONTAINER (row_box), delete_button);
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
g_object_set_data (G_OBJECT (row), "delete-button", delete_button);
network: Use a table-like widget to edit routes According to the latest mockups for the connection editor dialog [1], the IPv4 and IPv6 pages are supposed to use a table-like editor to manage the routes. This editor is not only easier to comprehend, but also improves the size of the dialog, requiring much less vertical space to present the routes. The current implementation, however, uses a vertical layout and a toolbar, which is inefficient in its usage of space. Fix that by implementing the table-like editor widget, both in IPv4 and IPv6 pages. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 13:04:52 -03:00
group = GTK_SIZE_GROUP (gtk_builder_get_object (CE_PAGE (page)->builder, "routes_sizegroup"));
gtk_size_group_add_widget (group, delete_button);
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
network: Use a table-like widget to edit routes According to the latest mockups for the connection editor dialog [1], the IPv4 and IPv6 pages are supposed to use a table-like editor to manage the routes. This editor is not only easier to comprehend, but also improves the size of the dialog, requiring much less vertical space to present the routes. The current implementation, however, uses a vertical layout and a toolbar, which is inefficient in its usage of space. Fix that by implementing the table-like editor widget, both in IPv4 and IPv6 pages. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 13:04:52 -03:00
gtk_container_add (GTK_CONTAINER (row), row_box);
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
gtk_widget_show_all (row);
gtk_container_add (GTK_CONTAINER (page->routes_list), row);
update_row_sensitivity (page, page->routes_list);
}
network: Use a table-like widget to edit routes According to the latest mockups for the connection editor dialog [1], the IPv4 and IPv6 pages are supposed to use a table-like editor to manage the routes. This editor is not only easier to comprehend, but also improves the size of the dialog, requiring much less vertical space to present the routes. The current implementation, however, uses a vertical layout and a toolbar, which is inefficient in its usage of space. Fix that by implementing the table-like editor widget, both in IPv4 and IPv6 pages. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 13:04:52 -03:00
static void
ensure_empty_routes_row (CEPageIP6 *page)
{
GList *children, *l;
children = gtk_container_get_children (GTK_CONTAINER (page->routes_list));
l = children;
while (l && l->next)
l = l->next;
/* Add the last, stub row if needed*/
if (!l || validate_row (l->data))
add_route_row (page, "", NULL, "", NULL);
g_list_free (children);
}
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
static void
add_empty_route_row (CEPageIP6 *page)
{
network: Port to libnm 1.2 We also remove support for WiMAX (now unsupported by NetworkManager), and InfiniBand (Enterprise feature), and the use of the deprecated NM_SETTING_WIRELESS_SEC property. With help from network-manager-applet patches by Jiří Klimeš and Dan Winship. https://bugzilla.gnome.org/show_bug.cgi?id=765910
2016-04-29 16:05:54 +02:00
add_route_row (page, "", NULL, "", NULL);
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
}
static void
add_routes_section (CEPageIP6 *page)
{
GtkWidget *widget;
GtkWidget *list;
gint i;
widget = GTK_WIDGET (gtk_builder_get_object (CE_PAGE (page)->builder, "routes_section"));
network: Convert connection editor to GtkListBox https://bugzilla.gnome.org/show_bug.cgi?id=702164
2013-06-21 20:03:53 +02:00
page->routes_list = list = gtk_list_box_new ();
gtk_list_box_set_selection_mode (GTK_LIST_BOX (list), GTK_SELECTION_NONE);
network: Use new listbox helpers https://bugzilla.gnome.org/show_bug.cgi?id=732106
2014-06-23 15:37:34 +02:00
gtk_list_box_set_header_func (GTK_LIST_BOX (list), cc_list_box_update_header_func, NULL, NULL);
network: Convert connection editor to GtkListBox https://bugzilla.gnome.org/show_bug.cgi?id=702164
2013-06-21 20:03:53 +02:00
gtk_list_box_set_sort_func (GTK_LIST_BOX (list), (GtkListBoxSortFunc)sort_first_last, NULL, NULL);
network: Use a table-like widget to edit routes According to the latest mockups for the connection editor dialog [1], the IPv4 and IPv6 pages are supposed to use a table-like editor to manage the routes. This editor is not only easier to comprehend, but also improves the size of the dialog, requiring much less vertical space to present the routes. The current implementation, however, uses a vertical layout and a toolbar, which is inefficient in its usage of space. Fix that by implementing the table-like editor widget, both in IPv4 and IPv6 pages. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 13:04:52 -03:00
gtk_container_add (GTK_CONTAINER (widget), list);
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
page->auto_routes = GTK_SWITCH (gtk_builder_get_object (CE_PAGE (page)->builder, "auto_routes_switch"));
network: Port to libnm 1.2 We also remove support for WiMAX (now unsupported by NetworkManager), and InfiniBand (Enterprise feature), and the use of the deprecated NM_SETTING_WIRELESS_SEC property. With help from network-manager-applet patches by Jiří Klimeš and Dan Winship. https://bugzilla.gnome.org/show_bug.cgi?id=765910
2016-04-29 16:05:54 +02:00
gtk_switch_set_active (page->auto_routes, !nm_setting_ip_config_get_ignore_auto_routes (page->setting));
network: Fix compile-time warnings
2013-02-15 13:44:49 +01:00
g_signal_connect (page->auto_routes, "notify::active", G_CALLBACK (switch_toggled), page);
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
network: Port to libnm 1.2 We also remove support for WiMAX (now unsupported by NetworkManager), and InfiniBand (Enterprise feature), and the use of the deprecated NM_SETTING_WIRELESS_SEC property. With help from network-manager-applet patches by Jiří Klimeš and Dan Winship. https://bugzilla.gnome.org/show_bug.cgi?id=765910
2016-04-29 16:05:54 +02:00
for (i = 0; i < nm_setting_ip_config_get_num_routes (page->setting); i++) {
NMIPRoute *route;
char *prefix, *metric;
route = nm_setting_ip_config_get_route (page->setting, i);
prefix = g_strdup_printf ("%u", nm_ip_route_get_prefix (route));
metric = g_strdup_printf ("%u", (guint32) MIN (0, nm_ip_route_get_metric (route)));
add_route_row (page, nm_ip_route_get_dest (route),
prefix,
nm_ip_route_get_next_hop (route),
metric);
g_free (prefix);
g_free (metric);
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
}
network: Port to libnm 1.2 We also remove support for WiMAX (now unsupported by NetworkManager), and InfiniBand (Enterprise feature), and the use of the deprecated NM_SETTING_WIRELESS_SEC property. With help from network-manager-applet patches by Jiří Klimeš and Dan Winship. https://bugzilla.gnome.org/show_bug.cgi?id=765910
2016-04-29 16:05:54 +02:00
if (nm_setting_ip_config_get_num_routes (page->setting) == 0)
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
add_empty_route_row (page);
gtk_widget_show_all (widget);
}
network: Use radio buttons instead of a combobox in IP pages Per the latest mockups [1], the IP pages use a set of four radio buttons to control the method, rather than a switch + a combobox, which is what the current implementation uses. This patch, then, adapts the IP pages of the connection editor dialog to use a set of radio buttons at the top of the page. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 01:56:08 -03:00
enum
{
RADIO_AUTOMATIC,
RADIO_DHCP,
RADIO_LOCAL,
RADIO_MANUAL,
RADIO_DISABLED,
N_RADIO
};
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
static void
connect_ip6_page (CEPageIP6 *page)
{
network: Use radio buttons instead of a combobox in IP pages Per the latest mockups [1], the IP pages use a set of four radio buttons to control the method, rather than a switch + a combobox, which is what the current implementation uses. This patch, then, adapts the IP pages of the connection editor dialog to use a set of radio buttons at the top of the page. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 01:56:08 -03:00
GtkToggleButton *radios[N_RADIO];
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
GtkWidget *content;
const gchar *str_method;
gboolean disabled;
network: Use radio buttons instead of a combobox in IP pages Per the latest mockups [1], the IP pages use a set of four radio buttons to control the method, rather than a switch + a combobox, which is what the current implementation uses. This patch, then, adapts the IP pages of the connection editor dialog to use a set of radio buttons at the top of the page. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 01:56:08 -03:00
guint method, i;
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
add_address_section (page);
add_dns_section (page);
add_routes_section (page);
network: Use radio buttons instead of a combobox in IP pages Per the latest mockups [1], the IP pages use a set of four radio buttons to control the method, rather than a switch + a combobox, which is what the current implementation uses. This patch, then, adapts the IP pages of the connection editor dialog to use a set of radio buttons at the top of the page. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 01:56:08 -03:00
page->disabled = GTK_TOGGLE_BUTTON (gtk_builder_get_object (CE_PAGE (page)->builder, "radio_disabled"));
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
network: Port to libnm 1.2 We also remove support for WiMAX (now unsupported by NetworkManager), and InfiniBand (Enterprise feature), and the use of the deprecated NM_SETTING_WIRELESS_SEC property. With help from network-manager-applet patches by Jiří Klimeš and Dan Winship. https://bugzilla.gnome.org/show_bug.cgi?id=765910
2016-04-29 16:05:54 +02:00
str_method = nm_setting_ip_config_get_method (page->setting);
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
disabled = g_strcmp0 (str_method, NM_SETTING_IP6_CONFIG_METHOD_IGNORE) == 0;
network: Use radio buttons instead of a combobox in IP pages Per the latest mockups [1], the IP pages use a set of four radio buttons to control the method, rather than a switch + a combobox, which is what the current implementation uses. This patch, then, adapts the IP pages of the connection editor dialog to use a set of radio buttons at the top of the page. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 01:56:08 -03:00
gtk_toggle_button_set_active (page->disabled, disabled);
g_signal_connect_swapped (page->disabled, "notify::active", G_CALLBACK (ce_page_changed), page);
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
content = GTK_WIDGET (gtk_builder_get_object (CE_PAGE (page)->builder, "page_content"));
network: Use radio buttons instead of a combobox in IP pages Per the latest mockups [1], the IP pages use a set of four radio buttons to control the method, rather than a switch + a combobox, which is what the current implementation uses. This patch, then, adapts the IP pages of the connection editor dialog to use a set of radio buttons at the top of the page. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 01:56:08 -03:00
g_object_bind_property (page->disabled, "active",
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
content, "sensitive",
network: Use radio buttons instead of a combobox in IP pages Per the latest mockups [1], the IP pages use a set of four radio buttons to control the method, rather than a switch + a combobox, which is what the current implementation uses. This patch, then, adapts the IP pages of the connection editor dialog to use a set of radio buttons at the top of the page. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 01:56:08 -03:00
G_BINDING_SYNC_CREATE | G_BINDING_INVERT_BOOLEAN);
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
method = IP6_METHOD_AUTO;
if (g_strcmp0 (str_method, NM_SETTING_IP6_CONFIG_METHOD_DHCP) == 0) {
method = IP6_METHOD_DHCP;
} else if (g_strcmp0 (str_method, NM_SETTING_IP6_CONFIG_METHOD_LINK_LOCAL) == 0) {
method = IP6_METHOD_LINK_LOCAL;
} else if (g_strcmp0 (str_method, NM_SETTING_IP6_CONFIG_METHOD_MANUAL) == 0) {
method = IP6_METHOD_MANUAL;
} else if (g_strcmp0 (str_method, NM_SETTING_IP6_CONFIG_METHOD_SHARED) == 0) {
method = IP6_METHOD_SHARED;
} else if (g_strcmp0 (str_method, NM_SETTING_IP6_CONFIG_METHOD_IGNORE) == 0) {
method = IP6_METHOD_IGNORE;
}
page->never_default = GTK_WIDGET (gtk_builder_get_object (CE_PAGE (page)->builder, "never_default_check"));
gtk_toggle_button_set_active (GTK_TOGGLE_BUTTON (page->never_default),
network: Port to libnm 1.2 We also remove support for WiMAX (now unsupported by NetworkManager), and InfiniBand (Enterprise feature), and the use of the deprecated NM_SETTING_WIRELESS_SEC property. With help from network-manager-applet patches by Jiří Klimeš and Dan Winship. https://bugzilla.gnome.org/show_bug.cgi?id=765910
2016-04-29 16:05:54 +02:00
nm_setting_ip_config_get_never_default (page->setting));
network: Make "only for this network" work for IPv6 VPNs https://bugzilla.gnome.org/show_bug.cgi?id=738029
2015-03-09 16:12:25 +01:00
g_signal_connect_swapped (page->never_default, "toggled", G_CALLBACK (ce_page_changed), page);
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
network: Use radio buttons instead of a combobox in IP pages Per the latest mockups [1], the IP pages use a set of four radio buttons to control the method, rather than a switch + a combobox, which is what the current implementation uses. This patch, then, adapts the IP pages of the connection editor dialog to use a set of radio buttons at the top of the page. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 01:56:08 -03:00
/* Connect radio buttons */
radios[RADIO_AUTOMATIC] = GTK_TOGGLE_BUTTON (gtk_builder_get_object (CE_PAGE (page)->builder, "radio_automatic"));
radios[RADIO_DHCP] = GTK_TOGGLE_BUTTON (gtk_builder_get_object (CE_PAGE (page)->builder, "radio_dhcp"));
radios[RADIO_LOCAL] = GTK_TOGGLE_BUTTON (gtk_builder_get_object (CE_PAGE (page)->builder, "radio_local"));
radios[RADIO_MANUAL] = GTK_TOGGLE_BUTTON (gtk_builder_get_object (CE_PAGE (page)->builder, "radio_manual"));
radios[RADIO_DISABLED] = page->disabled;
for (i = RADIO_AUTOMATIC; i < RADIO_DISABLED; i++)
g_signal_connect (radios[i], "toggled", G_CALLBACK (method_changed), page);
switch (method) {
case IP6_METHOD_AUTO:
gtk_toggle_button_set_active (radios[RADIO_AUTOMATIC], TRUE);
break;
case IP6_METHOD_DHCP:
gtk_toggle_button_set_active (radios[RADIO_DHCP], TRUE);
break;
case IP6_METHOD_LINK_LOCAL:
gtk_toggle_button_set_active (radios[RADIO_LOCAL], TRUE);
break;
case IP6_METHOD_MANUAL:
gtk_toggle_button_set_active (radios[RADIO_MANUAL], TRUE);
break;
case IP6_METHOD_IGNORE:
gtk_toggle_button_set_active (radios[RADIO_DISABLED], TRUE);
break;
default:
break;
}
method_changed (NULL, page);
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
}
static gboolean
ui_to_setting (CEPageIP6 *page)
{
const gchar *method;
gboolean ignore_auto_dns;
gboolean ignore_auto_routes;
gboolean never_default;
GList *children, *l;
network: Don't stop validating when we get an error The previous code would stop validating when an error occurred which meant that when a page contained multiple errors, only the first one(s) to be checked would appear in red. Now, all the errors will appear in red. https://bugzilla.gnome.org/show_bug.cgi?id=734472
2014-08-13 13:46:03 +02:00
gboolean ret = TRUE;
network: Simplify DNS management in connection editor When editing the DNS servers of a given connection, a simple entry is enough to display and edit the DNS servers. The user can separate IP addresses with commas. This is exemplified by the mockup at [1]. This, however, is not the current implementation, which uses a combination of listbox rows, entries and buttons to manage that with added complexity. Fix that by using an entry to handle the DNS servers. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 02:44:58 -03:00
GStrv dns_addresses = NULL;
gchar *dns_text = NULL;
guint i;
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
network: Use radio buttons instead of a combobox in IP pages Per the latest mockups [1], the IP pages use a set of four radio buttons to control the method, rather than a switch + a combobox, which is what the current implementation uses. This patch, then, adapts the IP pages of the connection editor dialog to use a set of radio buttons at the top of the page. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 01:56:08 -03:00
if (gtk_toggle_button_get_active (page->disabled)) {
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
method = NM_SETTING_IP6_CONFIG_METHOD_IGNORE;
} else {
network: Use radio buttons instead of a combobox in IP pages Per the latest mockups [1], the IP pages use a set of four radio buttons to control the method, rather than a switch + a combobox, which is what the current implementation uses. This patch, then, adapts the IP pages of the connection editor dialog to use a set of radio buttons at the top of the page. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 01:56:08 -03:00
if (RADIO_IS_ACTIVE ("radio_manual")) {
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
method = NM_SETTING_IP6_CONFIG_METHOD_MANUAL;
network: Use radio buttons instead of a combobox in IP pages Per the latest mockups [1], the IP pages use a set of four radio buttons to control the method, rather than a switch + a combobox, which is what the current implementation uses. This patch, then, adapts the IP pages of the connection editor dialog to use a set of radio buttons at the top of the page. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 01:56:08 -03:00
} else if (RADIO_IS_ACTIVE ("radio_local")) {
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
method = NM_SETTING_IP6_CONFIG_METHOD_LINK_LOCAL;
network: Use radio buttons instead of a combobox in IP pages Per the latest mockups [1], the IP pages use a set of four radio buttons to control the method, rather than a switch + a combobox, which is what the current implementation uses. This patch, then, adapts the IP pages of the connection editor dialog to use a set of radio buttons at the top of the page. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 01:56:08 -03:00
} else if (RADIO_IS_ACTIVE ("radio_dhcp")) {
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
method = NM_SETTING_IP6_CONFIG_METHOD_DHCP;
network: Use radio buttons instead of a combobox in IP pages Per the latest mockups [1], the IP pages use a set of four radio buttons to control the method, rather than a switch + a combobox, which is what the current implementation uses. This patch, then, adapts the IP pages of the connection editor dialog to use a set of radio buttons at the top of the page. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 01:56:08 -03:00
} else if (RADIO_IS_ACTIVE ("radio_automatic")) {
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
method = NM_SETTING_IP6_CONFIG_METHOD_AUTO;
}
}
network: Port to libnm 1.2 We also remove support for WiMAX (now unsupported by NetworkManager), and InfiniBand (Enterprise feature), and the use of the deprecated NM_SETTING_WIRELESS_SEC property. With help from network-manager-applet patches by Jiří Klimeš and Dan Winship. https://bugzilla.gnome.org/show_bug.cgi?id=765910
2016-04-29 16:05:54 +02:00
nm_setting_ip_config_clear_addresses (page->setting);
network: Fix IPv6 settings not being applicable when method changes When changing the method from Manual to Automatic, we need to clear the gateway setting, otherwise the settings verification will fail: ipv6.gateway: gateway cannot be set if there are no addresses configured Another fallout of the libnm 1.2 port https://bugzilla.gnome.org/show_bug.cgi?id=769230
2016-06-14 14:03:07 +02:00
if (g_str_equal (method, NM_SETTING_IP6_CONFIG_METHOD_MANUAL)) {
network: Don't save hidden configuration options When switching from a particular IPv4 or IPv6 "addresses" method to another, make sure that "address", "DNS" and "routes" are applied or ignored depending on that method's capabilities. For example, when switching from manual to automatic IPv4 "addresses" method, we need to make sure that the old IP address, gateway, etc. aren't actually used in the new setting. https://bugzilla.gnome.org/show_bug.cgi?id=734337
2014-08-13 18:26:19 +02:00
children = gtk_container_get_children (GTK_CONTAINER (page->address_list));
network: Fix IPv6 settings not being applicable when method changes When changing the method from Manual to Automatic, we need to clear the gateway setting, otherwise the settings verification will fail: ipv6.gateway: gateway cannot be set if there are no addresses configured Another fallout of the libnm 1.2 port https://bugzilla.gnome.org/show_bug.cgi?id=769230
2016-06-14 14:03:07 +02:00
} else {
g_object_set (G_OBJECT (page->setting),
NM_SETTING_IP_CONFIG_GATEWAY, NULL,
NULL);
network: Don't save hidden configuration options When switching from a particular IPv4 or IPv6 "addresses" method to another, make sure that "address", "DNS" and "routes" are applied or ignored depending on that method's capabilities. For example, when switching from manual to automatic IPv4 "addresses" method, we need to make sure that the old IP address, gateway, etc. aren't actually used in the new setting. https://bugzilla.gnome.org/show_bug.cgi?id=734337
2014-08-13 18:26:19 +02:00
children = NULL;
network: Fix IPv6 settings not being applicable when method changes When changing the method from Manual to Automatic, we need to clear the gateway setting, otherwise the settings verification will fail: ipv6.gateway: gateway cannot be set if there are no addresses configured Another fallout of the libnm 1.2 port https://bugzilla.gnome.org/show_bug.cgi?id=769230
2016-06-14 14:03:07 +02:00
}
network: Don't save hidden configuration options When switching from a particular IPv4 or IPv6 "addresses" method to another, make sure that "address", "DNS" and "routes" are applied or ignored depending on that method's capabilities. For example, when switching from manual to automatic IPv4 "addresses" method, we need to make sure that the old IP address, gateway, etc. aren't actually used in the new setting. https://bugzilla.gnome.org/show_bug.cgi?id=734337
2014-08-13 18:26:19 +02:00
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
for (l = children; l; l = l->next) {
GtkWidget *row = l->data;
GtkEntry *entry;
const gchar *text_address;
const gchar *text_prefix;
const gchar *text_gateway;
guint32 prefix;
gchar *end;
network: Port to libnm 1.2 We also remove support for WiMAX (now unsupported by NetworkManager), and InfiniBand (Enterprise feature), and the use of the deprecated NM_SETTING_WIRELESS_SEC property. With help from network-manager-applet patches by Jiří Klimeš and Dan Winship. https://bugzilla.gnome.org/show_bug.cgi?id=765910
2016-04-29 16:05:54 +02:00
NMIPAddress *addr;
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
gboolean have_gateway = FALSE;
entry = GTK_ENTRY (g_object_get_data (G_OBJECT (row), "address"));
if (!entry)
continue;
text_address = gtk_entry_get_text (entry);
text_prefix = gtk_entry_get_text (GTK_ENTRY (g_object_get_data (G_OBJECT (row), "prefix")));
text_gateway = gtk_entry_get_text (GTK_ENTRY (g_object_get_data (G_OBJECT (row), "gateway")));
if (!*text_address && !*text_prefix && !*text_gateway) {
/* ignore empty rows */
network: Make broken configuration entries red When a configuration setting is wrong, set the entry or file chooser that contains the incorrect information to be surrounded by red. This makes it easier for users to find where the error was made that disallows them to click the "Apply" button. https://bugzilla.gnome.org/show_bug.cgi?id=734446
2014-08-07 18:32:34 +02:00
widget_unset_error (GTK_WIDGET (entry));
widget_unset_error (g_object_get_data (G_OBJECT (row), "prefix"));
widget_unset_error (g_object_get_data (G_OBJECT (row), "gateway"));
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
continue;
}
network: Consider empty IPv6 gateway to be valid The string we get back from the text entries are never NULL (as long as the UI isn't broken that is), but can be empty strings. Consider an empty IPv6 address to be invalid, but an empty gateway to be valid. See https://bugzilla.redhat.com/show_bug.cgi?id=1467308
2018-02-06 10:30:57 +01:00
if (!*text_address || !nm_utils_ipaddr_valid (AF_INET6, text_address)) {
network: Make broken configuration entries red When a configuration setting is wrong, set the entry or file chooser that contains the incorrect information to be surrounded by red. This makes it easier for users to find where the error was made that disallows them to click the "Apply" button. https://bugzilla.gnome.org/show_bug.cgi?id=734446
2014-08-07 18:32:34 +02:00
widget_set_error (GTK_WIDGET (entry));
network: Don't stop validating when we get an error The previous code would stop validating when an error occurred which meant that when a page contained multiple errors, only the first one(s) to be checked would appear in red. Now, all the errors will appear in red. https://bugzilla.gnome.org/show_bug.cgi?id=734472
2014-08-13 13:46:03 +02:00
ret = FALSE;
} else {
widget_unset_error (GTK_WIDGET (entry));
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
}
prefix = strtoul (text_prefix, &end, 10);
if (!end || *end || prefix == 0 || prefix > 128) {
network: Make broken configuration entries red When a configuration setting is wrong, set the entry or file chooser that contains the incorrect information to be surrounded by red. This makes it easier for users to find where the error was made that disallows them to click the "Apply" button. https://bugzilla.gnome.org/show_bug.cgi?id=734446
2014-08-07 18:32:34 +02:00
widget_set_error (g_object_get_data (G_OBJECT (row), "prefix"));
network: Don't stop validating when we get an error The previous code would stop validating when an error occurred which meant that when a page contained multiple errors, only the first one(s) to be checked would appear in red. Now, all the errors will appear in red. https://bugzilla.gnome.org/show_bug.cgi?id=734472
2014-08-13 13:46:03 +02:00
ret = FALSE;
} else {
widget_unset_error (g_object_get_data (G_OBJECT (row), "prefix"));
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
}
network: Consider empty IPv6 gateway to be valid The string we get back from the text entries are never NULL (as long as the UI isn't broken that is), but can be empty strings. Consider an empty IPv6 address to be invalid, but an empty gateway to be valid. See https://bugzilla.redhat.com/show_bug.cgi?id=1467308
2018-02-06 10:30:57 +01:00
if (*text_gateway && !nm_utils_ipaddr_valid (AF_INET6, text_gateway)) {
network: Port to libnm 1.2 We also remove support for WiMAX (now unsupported by NetworkManager), and InfiniBand (Enterprise feature), and the use of the deprecated NM_SETTING_WIRELESS_SEC property. With help from network-manager-applet patches by Jiří Klimeš and Dan Winship. https://bugzilla.gnome.org/show_bug.cgi?id=765910
2016-04-29 16:05:54 +02:00
widget_set_error (g_object_get_data (G_OBJECT (row), "gateway"));
ret = FALSE;
network: Don't stop validating when we get an error The previous code would stop validating when an error occurred which meant that when a page contained multiple errors, only the first one(s) to be checked would appear in red. Now, all the errors will appear in red. https://bugzilla.gnome.org/show_bug.cgi?id=734472
2014-08-13 13:46:03 +02:00
} else {
widget_unset_error (g_object_get_data (G_OBJECT (row), "gateway"));
network: Consider empty IPv6 gateway to be valid The string we get back from the text entries are never NULL (as long as the UI isn't broken that is), but can be empty strings. Consider an empty IPv6 address to be invalid, but an empty gateway to be valid. See https://bugzilla.redhat.com/show_bug.cgi?id=1467308
2018-02-06 10:30:57 +01:00
if (*text_gateway)
have_gateway = TRUE;
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
}
network: Don't stop validating when we get an error The previous code would stop validating when an error occurred which meant that when a page contained multiple errors, only the first one(s) to be checked would appear in red. Now, all the errors will appear in red. https://bugzilla.gnome.org/show_bug.cgi?id=734472
2014-08-13 13:46:03 +02:00
if (!ret)
continue;
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
network: Port to libnm 1.2 We also remove support for WiMAX (now unsupported by NetworkManager), and InfiniBand (Enterprise feature), and the use of the deprecated NM_SETTING_WIRELESS_SEC property. With help from network-manager-applet patches by Jiří Klimeš and Dan Winship. https://bugzilla.gnome.org/show_bug.cgi?id=765910
2016-04-29 16:05:54 +02:00
addr = nm_ip_address_new (AF_INET6, text_address, prefix, NULL);
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
if (have_gateway)
network: Port to libnm 1.2 We also remove support for WiMAX (now unsupported by NetworkManager), and InfiniBand (Enterprise feature), and the use of the deprecated NM_SETTING_WIRELESS_SEC property. With help from network-manager-applet patches by Jiří Klimeš and Dan Winship. https://bugzilla.gnome.org/show_bug.cgi?id=765910
2016-04-29 16:05:54 +02:00
g_object_set (G_OBJECT (page->setting),
NM_SETTING_IP_CONFIG_GATEWAY, text_gateway,
NULL);
nm_setting_ip_config_add_address (page->setting, addr);
network: Use a table-like widget in address editor According to the latest mockups for the connection editor dialog [1], the IPv4 and IPv6 pages are supposed to use a table-like editor to manage the addresses, in a similar fashion of what was done to the routes editor. This way of editing is not only easier to comprehend, but also improves the size of the dialog, requiring much less vertical space to present the routes. The current implementation, however, uses a vertical layout and a toolbar, which is inefficient in its usage of space. Fix that by implementing the table-like editor widget, both in IPv4 and IPv6 pages. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 15:02:45 -03:00
if (!l || !l->next)
ensure_empty_address_row (page);
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
}
g_list_free (children);
network: Port to libnm 1.2 We also remove support for WiMAX (now unsupported by NetworkManager), and InfiniBand (Enterprise feature), and the use of the deprecated NM_SETTING_WIRELESS_SEC property. With help from network-manager-applet patches by Jiří Klimeš and Dan Winship. https://bugzilla.gnome.org/show_bug.cgi?id=765910
2016-04-29 16:05:54 +02:00
nm_setting_ip_config_clear_dns (page->setting);
network: Simplify DNS management in connection editor When editing the DNS servers of a given connection, a simple entry is enough to display and edit the DNS servers. The user can separate IP addresses with commas. This is exemplified by the mockup at [1]. This, however, is not the current implementation, which uses a combination of listbox rows, entries and buttons to manage that with added complexity. Fix that by using an entry to handle the DNS servers. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 02:44:58 -03:00
dns_text = g_strstrip (g_strdup (gtk_entry_get_text (GTK_ENTRY (page->dns_entry))));
network: Don't save hidden configuration options When switching from a particular IPv4 or IPv6 "addresses" method to another, make sure that "address", "DNS" and "routes" are applied or ignored depending on that method's capabilities. For example, when switching from manual to automatic IPv4 "addresses" method, we need to make sure that the old IP address, gateway, etc. aren't actually used in the new setting. https://bugzilla.gnome.org/show_bug.cgi?id=734337
2014-08-13 18:26:19 +02:00
if (g_str_equal (method, NM_SETTING_IP6_CONFIG_METHOD_AUTO) ||
g_str_equal (method, NM_SETTING_IP6_CONFIG_METHOD_DHCP) ||
g_str_equal (method, NM_SETTING_IP6_CONFIG_METHOD_MANUAL))
network: Simplify DNS management in connection editor When editing the DNS servers of a given connection, a simple entry is enough to display and edit the DNS servers. The user can separate IP addresses with commas. This is exemplified by the mockup at [1]. This, however, is not the current implementation, which uses a combination of listbox rows, entries and buttons to manage that with added complexity. Fix that by using an entry to handle the DNS servers. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 02:44:58 -03:00
dns_addresses = g_strsplit_set (dns_text, ", ", -1);
network: Don't save hidden configuration options When switching from a particular IPv4 or IPv6 "addresses" method to another, make sure that "address", "DNS" and "routes" are applied or ignored depending on that method's capabilities. For example, when switching from manual to automatic IPv4 "addresses" method, we need to make sure that the old IP address, gateway, etc. aren't actually used in the new setting. https://bugzilla.gnome.org/show_bug.cgi?id=734337
2014-08-13 18:26:19 +02:00
else
network: Simplify DNS management in connection editor When editing the DNS servers of a given connection, a simple entry is enough to display and edit the DNS servers. The user can separate IP addresses with commas. This is exemplified by the mockup at [1]. This, however, is not the current implementation, which uses a combination of listbox rows, entries and buttons to manage that with added complexity. Fix that by using an entry to handle the DNS servers. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 02:44:58 -03:00
dns_addresses = NULL;
network: Don't save hidden configuration options When switching from a particular IPv4 or IPv6 "addresses" method to another, make sure that "address", "DNS" and "routes" are applied or ignored depending on that method's capabilities. For example, when switching from manual to automatic IPv4 "addresses" method, we need to make sure that the old IP address, gateway, etc. aren't actually used in the new setting. https://bugzilla.gnome.org/show_bug.cgi?id=734337
2014-08-13 18:26:19 +02:00
network: Simplify DNS management in connection editor When editing the DNS servers of a given connection, a simple entry is enough to display and edit the DNS servers. The user can separate IP addresses with commas. This is exemplified by the mockup at [1]. This, however, is not the current implementation, which uses a combination of listbox rows, entries and buttons to manage that with added complexity. Fix that by using an entry to handle the DNS servers. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 02:44:58 -03:00
for (i = 0; dns_addresses && dns_addresses[i]; i++) {
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
const gchar *text;
struct in6_addr tmp_addr;
network: Simplify DNS management in connection editor When editing the DNS servers of a given connection, a simple entry is enough to display and edit the DNS servers. The user can separate IP addresses with commas. This is exemplified by the mockup at [1]. This, however, is not the current implementation, which uses a combination of listbox rows, entries and buttons to manage that with added complexity. Fix that by using an entry to handle the DNS servers. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 02:44:58 -03:00
text = dns_addresses[i];
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
network: Simplify DNS management in connection editor When editing the DNS servers of a given connection, a simple entry is enough to display and edit the DNS servers. The user can separate IP addresses with commas. This is exemplified by the mockup at [1]. This, however, is not the current implementation, which uses a combination of listbox rows, entries and buttons to manage that with added complexity. Fix that by using an entry to handle the DNS servers. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 02:44:58 -03:00
if (!text || !*text)
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
continue;
if (inet_pton (AF_INET6, text, &tmp_addr) <= 0) {
network: Simplify DNS management in connection editor When editing the DNS servers of a given connection, a simple entry is enough to display and edit the DNS servers. The user can separate IP addresses with commas. This is exemplified by the mockup at [1]. This, however, is not the current implementation, which uses a combination of listbox rows, entries and buttons to manage that with added complexity. Fix that by using an entry to handle the DNS servers. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 02:44:58 -03:00
g_clear_pointer (&dns_addresses, g_strfreev);
widget_set_error (page->dns_entry);
network: Don't stop validating when we get an error The previous code would stop validating when an error occurred which meant that when a page contained multiple errors, only the first one(s) to be checked would appear in red. Now, all the errors will appear in red. https://bugzilla.gnome.org/show_bug.cgi?id=734472
2014-08-13 13:46:03 +02:00
ret = FALSE;
network: Simplify DNS management in connection editor When editing the DNS servers of a given connection, a simple entry is enough to display and edit the DNS servers. The user can separate IP addresses with commas. This is exemplified by the mockup at [1]. This, however, is not the current implementation, which uses a combination of listbox rows, entries and buttons to manage that with added complexity. Fix that by using an entry to handle the DNS servers. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 02:44:58 -03:00
break;
network: Don't stop validating when we get an error The previous code would stop validating when an error occurred which meant that when a page contained multiple errors, only the first one(s) to be checked would appear in red. Now, all the errors will appear in red. https://bugzilla.gnome.org/show_bug.cgi?id=734472
2014-08-13 13:46:03 +02:00
} else {
network: Simplify DNS management in connection editor When editing the DNS servers of a given connection, a simple entry is enough to display and edit the DNS servers. The user can separate IP addresses with commas. This is exemplified by the mockup at [1]. This, however, is not the current implementation, which uses a combination of listbox rows, entries and buttons to manage that with added complexity. Fix that by using an entry to handle the DNS servers. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 02:44:58 -03:00
widget_unset_error (page->dns_entry);
network: Port to libnm 1.2 We also remove support for WiMAX (now unsupported by NetworkManager), and InfiniBand (Enterprise feature), and the use of the deprecated NM_SETTING_WIRELESS_SEC property. With help from network-manager-applet patches by Jiří Klimeš and Dan Winship. https://bugzilla.gnome.org/show_bug.cgi?id=765910
2016-04-29 16:05:54 +02:00
nm_setting_ip_config_add_dns (page->setting, text);
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
}
}
network: Port to libnm 1.2 We also remove support for WiMAX (now unsupported by NetworkManager), and InfiniBand (Enterprise feature), and the use of the deprecated NM_SETTING_WIRELESS_SEC property. With help from network-manager-applet patches by Jiří Klimeš and Dan Winship. https://bugzilla.gnome.org/show_bug.cgi?id=765910
2016-04-29 16:05:54 +02:00
nm_setting_ip_config_clear_routes (page->setting);
network: Don't save hidden configuration options When switching from a particular IPv4 or IPv6 "addresses" method to another, make sure that "address", "DNS" and "routes" are applied or ignored depending on that method's capabilities. For example, when switching from manual to automatic IPv4 "addresses" method, we need to make sure that the old IP address, gateway, etc. aren't actually used in the new setting. https://bugzilla.gnome.org/show_bug.cgi?id=734337
2014-08-13 18:26:19 +02:00
if (g_str_equal (method, NM_SETTING_IP6_CONFIG_METHOD_AUTO) ||
g_str_equal (method, NM_SETTING_IP6_CONFIG_METHOD_DHCP) ||
g_str_equal (method, NM_SETTING_IP6_CONFIG_METHOD_MANUAL))
children = gtk_container_get_children (GTK_CONTAINER (page->routes_list));
else
children = NULL;
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
for (l = children; l; l = l->next) {
GtkWidget *row = l->data;
GtkEntry *entry;
const gchar *text_address;
const gchar *text_prefix;
const gchar *text_gateway;
const gchar *text_metric;
guint32 prefix, metric;
gchar *end;
network: Port to libnm 1.2 We also remove support for WiMAX (now unsupported by NetworkManager), and InfiniBand (Enterprise feature), and the use of the deprecated NM_SETTING_WIRELESS_SEC property. With help from network-manager-applet patches by Jiří Klimeš and Dan Winship. https://bugzilla.gnome.org/show_bug.cgi?id=765910
2016-04-29 16:05:54 +02:00
NMIPRoute *route;
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
entry = GTK_ENTRY (g_object_get_data (G_OBJECT (row), "address"));
if (!entry)
continue;
text_address = gtk_entry_get_text (entry);
text_prefix = gtk_entry_get_text (GTK_ENTRY (g_object_get_data (G_OBJECT (row), "prefix")));
text_gateway = gtk_entry_get_text (GTK_ENTRY (g_object_get_data (G_OBJECT (row), "gateway")));
text_metric = gtk_entry_get_text (GTK_ENTRY (g_object_get_data (G_OBJECT (row), "metric")));
if (!*text_address && !*text_prefix && !*text_gateway && !*text_metric) {
/* ignore empty rows */
network: Make broken configuration entries red When a configuration setting is wrong, set the entry or file chooser that contains the incorrect information to be surrounded by red. This makes it easier for users to find where the error was made that disallows them to click the "Apply" button. https://bugzilla.gnome.org/show_bug.cgi?id=734446
2014-08-07 18:32:34 +02:00
widget_unset_error (GTK_WIDGET (entry));
widget_unset_error (g_object_get_data (G_OBJECT (row), "prefix"));
widget_unset_error (g_object_get_data (G_OBJECT (row), "gateway"));
widget_unset_error (g_object_get_data (G_OBJECT (row), "metric"));
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
continue;
}
network: Port to libnm 1.2 We also remove support for WiMAX (now unsupported by NetworkManager), and InfiniBand (Enterprise feature), and the use of the deprecated NM_SETTING_WIRELESS_SEC property. With help from network-manager-applet patches by Jiří Klimeš and Dan Winship. https://bugzilla.gnome.org/show_bug.cgi?id=765910
2016-04-29 16:05:54 +02:00
if (!nm_utils_ipaddr_valid (AF_INET6, text_address)) {
network: Make broken configuration entries red When a configuration setting is wrong, set the entry or file chooser that contains the incorrect information to be surrounded by red. This makes it easier for users to find where the error was made that disallows them to click the "Apply" button. https://bugzilla.gnome.org/show_bug.cgi?id=734446
2014-08-07 18:32:34 +02:00
widget_set_error (GTK_WIDGET (entry));
network: Don't stop validating when we get an error The previous code would stop validating when an error occurred which meant that when a page contained multiple errors, only the first one(s) to be checked would appear in red. Now, all the errors will appear in red. https://bugzilla.gnome.org/show_bug.cgi?id=734472
2014-08-13 13:46:03 +02:00
ret = FALSE;
} else {
widget_unset_error (GTK_WIDGET (entry));
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
}
prefix = strtoul (text_prefix, &end, 10);
if (!end || *end || prefix == 0 || prefix > 128) {
network: Make broken configuration entries red When a configuration setting is wrong, set the entry or file chooser that contains the incorrect information to be surrounded by red. This makes it easier for users to find where the error was made that disallows them to click the "Apply" button. https://bugzilla.gnome.org/show_bug.cgi?id=734446
2014-08-07 18:32:34 +02:00
widget_set_error (g_object_get_data (G_OBJECT (row), "prefix"));
network: Don't stop validating when we get an error The previous code would stop validating when an error occurred which meant that when a page contained multiple errors, only the first one(s) to be checked would appear in red. Now, all the errors will appear in red. https://bugzilla.gnome.org/show_bug.cgi?id=734472
2014-08-13 13:46:03 +02:00
ret = FALSE;
} else {
widget_unset_error (g_object_get_data (G_OBJECT (row), "prefix"));
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
}
network: Port to libnm 1.2 We also remove support for WiMAX (now unsupported by NetworkManager), and InfiniBand (Enterprise feature), and the use of the deprecated NM_SETTING_WIRELESS_SEC property. With help from network-manager-applet patches by Jiří Klimeš and Dan Winship. https://bugzilla.gnome.org/show_bug.cgi?id=765910
2016-04-29 16:05:54 +02:00
if (!nm_utils_ipaddr_valid (AF_INET6, text_gateway)) {
network: Make broken configuration entries red When a configuration setting is wrong, set the entry or file chooser that contains the incorrect information to be surrounded by red. This makes it easier for users to find where the error was made that disallows them to click the "Apply" button. https://bugzilla.gnome.org/show_bug.cgi?id=734446
2014-08-07 18:32:34 +02:00
widget_set_error (g_object_get_data (G_OBJECT (row), "gateway"));
network: Don't stop validating when we get an error The previous code would stop validating when an error occurred which meant that when a page contained multiple errors, only the first one(s) to be checked would appear in red. Now, all the errors will appear in red. https://bugzilla.gnome.org/show_bug.cgi?id=734472
2014-08-13 13:46:03 +02:00
ret = FALSE;
} else {
widget_unset_error (g_object_get_data (G_OBJECT (row), "gateway"));
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
}
metric = 0;
if (*text_metric) {
errno = 0;
metric = strtoul (text_metric, NULL, 10);
if (errno) {
network: Make broken configuration entries red When a configuration setting is wrong, set the entry or file chooser that contains the incorrect information to be surrounded by red. This makes it easier for users to find where the error was made that disallows them to click the "Apply" button. https://bugzilla.gnome.org/show_bug.cgi?id=734446
2014-08-07 18:32:34 +02:00
widget_set_error (g_object_get_data (G_OBJECT (row), "metric"));
network: Don't stop validating when we get an error The previous code would stop validating when an error occurred which meant that when a page contained multiple errors, only the first one(s) to be checked would appear in red. Now, all the errors will appear in red. https://bugzilla.gnome.org/show_bug.cgi?id=734472
2014-08-13 13:46:03 +02:00
ret = FALSE;
} else {
widget_unset_error (g_object_get_data (G_OBJECT (row), "metric"));
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
}
network: Don't stop validating when we get an error The previous code would stop validating when an error occurred which meant that when a page contained multiple errors, only the first one(s) to be checked would appear in red. Now, all the errors will appear in red. https://bugzilla.gnome.org/show_bug.cgi?id=734472
2014-08-13 13:46:03 +02:00
} else {
widget_unset_error (g_object_get_data (G_OBJECT (row), "metric"));
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
}
network: Don't stop validating when we get an error The previous code would stop validating when an error occurred which meant that when a page contained multiple errors, only the first one(s) to be checked would appear in red. Now, all the errors will appear in red. https://bugzilla.gnome.org/show_bug.cgi?id=734472
2014-08-13 13:46:03 +02:00
if (!ret)
continue;
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
network: Port to libnm 1.2 We also remove support for WiMAX (now unsupported by NetworkManager), and InfiniBand (Enterprise feature), and the use of the deprecated NM_SETTING_WIRELESS_SEC property. With help from network-manager-applet patches by Jiří Klimeš and Dan Winship. https://bugzilla.gnome.org/show_bug.cgi?id=765910
2016-04-29 16:05:54 +02:00
route = nm_ip_route_new (AF_INET6, text_address, prefix, text_gateway, metric, NULL);
nm_setting_ip_config_add_route (page->setting, route);
nm_ip_route_unref (route);
network: Use a table-like widget to edit routes According to the latest mockups for the connection editor dialog [1], the IPv4 and IPv6 pages are supposed to use a table-like editor to manage the routes. This editor is not only easier to comprehend, but also improves the size of the dialog, requiring much less vertical space to present the routes. The current implementation, however, uses a vertical layout and a toolbar, which is inefficient in its usage of space. Fix that by implementing the table-like editor widget, both in IPv4 and IPv6 pages. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 13:04:52 -03:00
if (!l || !l->next)
ensure_empty_routes_row (page);
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
}
g_list_free (children);
network: Don't stop validating when we get an error The previous code would stop validating when an error occurred which meant that when a page contained multiple errors, only the first one(s) to be checked would appear in red. Now, all the errors will appear in red. https://bugzilla.gnome.org/show_bug.cgi?id=734472
2014-08-13 13:46:03 +02:00
if (!ret)
goto out;
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
ignore_auto_dns = !gtk_switch_get_active (page->auto_dns);
ignore_auto_routes = !gtk_switch_get_active (page->auto_routes);
never_default = gtk_toggle_button_get_active (GTK_TOGGLE_BUTTON (page->never_default));
g_object_set (page->setting,
network: Port to libnm 1.2 We also remove support for WiMAX (now unsupported by NetworkManager), and InfiniBand (Enterprise feature), and the use of the deprecated NM_SETTING_WIRELESS_SEC property. With help from network-manager-applet patches by Jiří Klimeš and Dan Winship. https://bugzilla.gnome.org/show_bug.cgi?id=765910
2016-04-29 16:05:54 +02:00
NM_SETTING_IP_CONFIG_METHOD, method,
NM_SETTING_IP_CONFIG_IGNORE_AUTO_DNS, ignore_auto_dns,
NM_SETTING_IP_CONFIG_IGNORE_AUTO_ROUTES, ignore_auto_routes,
NM_SETTING_IP_CONFIG_NEVER_DEFAULT, never_default,
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
NULL);
out:
network: Simplify DNS management in connection editor When editing the DNS servers of a given connection, a simple entry is enough to display and edit the DNS servers. The user can separate IP addresses with commas. This is exemplified by the mockup at [1]. This, however, is not the current implementation, which uses a combination of listbox rows, entries and buttons to manage that with added complexity. Fix that by using an entry to handle the DNS servers. [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/network/aday2/network-wires.png https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-23 02:44:58 -03:00
g_clear_pointer (&dns_addresses, g_strfreev);
g_clear_pointer (&dns_text, g_free);
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
network: Don't stop validating when we get an error The previous code would stop validating when an error occurred which meant that when a page contained multiple errors, only the first one(s) to be checked would appear in red. Now, all the errors will appear in red. https://bugzilla.gnome.org/show_bug.cgi?id=734472
2014-08-13 13:46:03 +02:00
return ret;
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
}
static gboolean
validate (CEPage *page,
NMConnection *connection,
GError **error)
{
if (!ui_to_setting (CE_PAGE_IP6 (page)))
return FALSE;
return nm_setting_verify (NM_SETTING (CE_PAGE_IP6 (page)->setting), NULL, error);
}
static void
ce_page_ip6_init (CEPageIP6 *page)
{
}
static void
ce_page_ip6_class_init (CEPageIP6Class *class)
{
CEPageClass *page_class= CE_PAGE_CLASS (class);
page_class->validate = validate;
}
CEPage *
ce_page_ip6_new (NMConnection *connection,
network: Port to libnm 1.2 We also remove support for WiMAX (now unsupported by NetworkManager), and InfiniBand (Enterprise feature), and the use of the deprecated NM_SETTING_WIRELESS_SEC property. With help from network-manager-applet patches by Jiří Klimeš and Dan Winship. https://bugzilla.gnome.org/show_bug.cgi?id=765910
2016-04-29 16:05:54 +02:00
NMClient *client)
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
{
CEPageIP6 *page;
page = CE_PAGE_IP6 (ce_page_new (CE_TYPE_PAGE_IP6,
connection,
client,
"/org/gnome/control-center/network/ip6-page.ui",
_("IPv6")));
page->setting = nm_connection_get_setting_ip6_config (connection);
network: Implement the new design for wired This expands the connection editor to cover ethernet, and adds support for multiple wired profiles.
2012-12-17 14:17:42 -05:00
if (!page->setting) {
network: Port to libnm 1.2 We also remove support for WiMAX (now unsupported by NetworkManager), and InfiniBand (Enterprise feature), and the use of the deprecated NM_SETTING_WIRELESS_SEC property. With help from network-manager-applet patches by Jiří Klimeš and Dan Winship. https://bugzilla.gnome.org/show_bug.cgi?id=765910
2016-04-29 16:05:54 +02:00
page->setting = NM_SETTING_IP_CONFIG (nm_setting_ip6_config_new ());
network: Implement the new design for wired This expands the connection editor to cover ethernet, and adds support for multiple wired profiles.
2012-12-17 14:17:42 -05:00
nm_connection_add_setting (connection, NM_SETTING (page->setting));
}
network: Break out wifi details code and add editing support This code is fairly independent of the rest, and we don't want net-device-wifi.c to become too massive and unmaintainable. The code in connection-editor/ is fairly similar to nm-connection-editor, with some simplification because we currently only edit wireless connections. The code in wireless-security/ is almost a straight copy of the same code in nm-connection-editor, with some changes to the .ui files to make them fit better in the new design.
2012-12-09 19:38:32 -05:00
connect_ip6_page (page);
return CE_PAGE (page);
}
Reference in a new issue Copy permalink