applications/gnome-control-center
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

system/about: Do not leak CcSystemDetailsWindow

Browse source 
The window should be destroyed and unreferenced when the About page is
disposed to prevent leaking it.

We need to take the reference in order to not repeat #2823, since the
AdwWindow is initially floating.
This commit is contained in:
Matthijs Velsink 2024-02-02 01:08:17 +01:00 • committed by Felipe Borges
parent 343932964f
commit 0eb1eacb64
1 changed files with 19 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
panels/system/about/cc-about-page.c
View file

@ -119,7 +119,10 @@ cc_about_page_open_system_details (CcAboutPage *self)
GtkNative *parent;
if (!self->system_details_window)
self->system_details_window = GTK_WINDOW (cc_system_details_window_new ());
{
self->system_details_window = GTK_WINDOW (cc_system_details_window_new ());
g_object_ref_sink (self->system_details_window);
}
parent = gtk_widget_get_native (GTK_WIDGET (self));
gtk_window_set_transient_for (self->system_details_window, GTK_WINDOW (parent));
@ -203,11 +206,26 @@ setup_os_logo (CcAboutPage *self)
#endif
}
static void
cc_about_page_dispose (GObject *object)
{
CcAboutPage *self = CC_ABOUT_PAGE (object);
if (self->system_details_window)
gtk_window_destroy (self->system_details_window);
g_clear_object (&self->system_details_window);
G_OBJECT_CLASS (cc_about_page_parent_class)->dispose (object);
}
static void
cc_about_page_class_init (CcAboutPageClass *klass)
{
GObjectClass *object_class = G_OBJECT_CLASS (klass);
GtkWidgetClass *widget_class = GTK_WIDGET_CLASS (klass);
object_class->dispose = cc_about_page_dispose;
g_type_ensure (CC_TYPE_HOSTNAME_ENTRY);
gtk_widget_class_set_template_from_resource (widget_class, "/org/gnome/control-center/system/about/cc-about-page.ui");