applications/gnome-control-center
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

user-accounts: Fix use of an uninitialised variable in the carousel

Browse source 
`dest_x` is not set if `gtk_widget_translate_coordinates()` fails, which
it can do before the widget is realised.

This fixes a valgrind warning, but doesn’t change any user-visible
behaviour as far as I can tell.

Signed-off-by: Philip Withnall <withnall@endlessm.com>
This commit is contained in:
Philip Withnall 2020-01-29 17:43:24 +00:00
parent a7524dcf92
commit 6284162a1d
1 changed files with 7 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
panels/user-accounts/cc-carousel.c
View file

@ -93,12 +93,13 @@ cc_carousel_item_get_x (CcCarouselItem *item,
widget = GTK_WIDGET (item); widget = GTK_WIDGET (item);
width = gtk_widget_get_allocated_width (widget); width = gtk_widget_get_allocated_width (widget);
gtk_widget_translate_coordinates (widget, if (!gtk_widget_translate_coordinates (widget,
parent, parent,
width / 2, width / 2,
0, 0,
&dest_x, &dest_x,
NULL); NULL))
return 0;
return CLAMP (dest_x - ARROW_SIZE, return CLAMP (dest_x - ARROW_SIZE,
0, 0,