applications/gnome-control-center
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

default-apps: Fix illegal memory access

Browse source 
gnome_da_xml_free() frees priv->capplet, so we shouldn't be
accessing it afterwards.
This commit is contained in:
Bastien Nocera 2010-09-21 15:22:43 +01:00
parent 720065c183
commit a205fc79b4
1 changed files with 2 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
panels/default-applications/cc-default-applications-panel.c
View file

@ -71,7 +71,6 @@ cc_default_applications_panel_dispose (GObject *object)
if (priv->capplet) if (priv->capplet)
{ {
g_object_unref (priv->capplet->gconf); g_object_unref (priv->capplet->gconf);
gnome_da_xml_free (priv->capplet);
if (priv->capplet->theme_changed_id > 0) if (priv->capplet->theme_changed_id > 0)
{ {
@ -80,6 +79,8 @@ cc_default_applications_panel_dispose (GObject *object)
priv->capplet->theme_changed_id = 0; priv->capplet->theme_changed_id = 0;
} }
gnome_da_xml_free (priv->capplet);
priv->capplet = NULL; priv->capplet = NULL;
} }