applications/gnome-control-center
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

network: Avoid crashing if the NMDevice doesn't have a hw-address

Browse source 
The property might not exist and we would g_free() an uninitialized
pointer. Using the proper API avoids all that.

https://bugzilla.gnome.org/show_bug.cgi?id=783839
This commit is contained in:
Rui Matos 2017-06-16 12:24:05 +02:00
parent 82261fbe75
commit ca667d9928
1 changed files with 2 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
panels/network/net-device-simple.c
View file

@ -85,7 +85,7 @@ static void
nm_device_simple_refresh_ui (NetDeviceSimple *device_simple)
{
NetDeviceSimplePrivate *priv = device_simple->priv;
char *hwaddr;
const char *hwaddr;
GtkWidget *widget;
char *speed = NULL;
NMDevice *nm_device;
@ -119,11 +119,8 @@ nm_device_simple_refresh_ui (NetDeviceSimple *device_simple)
panel_set_device_status (priv->builder, "label_status", nm_device, speed);
/* device MAC */
g_object_get (G_OBJECT (nm_device),
"hw-address", &hwaddr,
NULL);
hwaddr = nm_device_get_hw_address (nm_device);
panel_set_device_widget_details (priv->builder, "mac", hwaddr);
g_free (hwaddr);
/* set IP entries */
panel_set_device_widgets (priv->builder, nm_device);