applications/gnome-control-center
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

remote-desktop: Fix page contents being cut when window is small

Browse source 
- Use halign correctly ("left" and "right" aren't
valid values) and use hexpand in the
"Verify Encryption" button, since halign needs
hexpand set to "true"

- Ditch the spacer box, as it causes the page contents
to not scale correctly when the window width is small

- Add can-shrink property to "Generate New Password" and
"Verify Encryption" buttons so they can shrink when
the window width is small

- Also, set the margin-top only in the GtkBox to avoid
redundancy

Closes https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2933
This commit is contained in:
Automeris naranja 2024-03-02 21:48:02 -03:00
parent 92e01d0f39
commit d9be89a5de
2 changed files with 10 additions and 22 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
panels/system/remote-desktop/cc-desktop-sharing-page.ui
View file

@ -123,29 +123,23 @@
</child>
<child>
<object class="GtkBox">
<property name="margin-top">24</property>
<property name="spacing">10</property>
<child>
<object class="GtkButton" id="generate_password_button">
<property name="sensitive">False</property>
<property name="halign">left</property>
<property name="margin-top">24</property>
<property name="can-shrink">True</property>
<property name="label" translatable="yes">_Generate New Password</property>
<property name="use-underline">True</property>
<signal name="clicked" handler="on_generate_password_button_clicked" swapped="yes"/>
</object>
</child>
<child>
<object class="GtkBox" id="spacer_box">
<property name="visible">True</property>
<property name="can-focus">False</property>
<property name="hexpand">True</property>
</object>
</child>
<child>
<object class="GtkButton" id="verify_encryption_button">
<property name="sensitive">False</property>
<property name="halign">right</property>
<property name="margin-top">24</property>
<property name="hexpand">True</property>
<property name="halign">end</property>
<property name="can-shrink">True</property>
<property name="label" translatable="yes">_Verify Encryption</property>
<property name="use-underline">True</property>
<signal name="clicked" handler="on_verify_encryption_button_clicked" swapped="yes"/>

16
panels/system/remote-desktop/cc-remote-session-page.ui
View file

@ -121,29 +121,23 @@
</child>
<child>
<object class="GtkBox">
<property name="margin-top">24</property>
<property name="spacing">10</property>
<child>
<object class="GtkButton" id="generate_password_button">
<property name="sensitive">False</property>
<property name="halign">left</property>
<property name="margin-top">24</property>
<property name="can-shrink">True</property>
<property name="label" translatable="yes">_Generate New Password</property>
<property name="use-underline">True</property>
<signal name="clicked" handler="on_generate_password_button_clicked" swapped="yes"/>
</object>
</child>
<child>
<object class="GtkBox" id="spacer_box">
<property name="visible">True</property>
<property name="can-focus">False</property>
<property name="hexpand">True</property>
</object>
</child>
<child>
<object class="GtkButton" id="verify_encryption_button">
<property name="sensitive">False</property>
<property name="halign">right</property>
<property name="margin-top">24</property>
<property name="hexpand">True</property>
<property name="halign">end</property>
<property name="can-shrink">True</property>
<property name="label" translatable="yes">_Verify Encryption</property>
<property name="use-underline">True</property>
<signal name="clicked" handler="on_verify_encryption_button_clicked" swapped="yes"/>