Commit graph

5124 commits

Author SHA1 Message Date
Benjamin Berg
adf5a42f01 display: Show insensitive apply button for invalid configurations
When the user creates temporary invalid configurations the dialog used
to hide the apply button as if no change had been done so far. Change
this to show the normal "Apply"/"Cancel" titlebar but make the "Apply"
button insensitive and modify the title to indicate the error.

Unfortunately we don't currently get the reason in a way that we could
translate it. Ideally we would special case common error scenarios and
present the user with a better explanation or even correct the mistake.

See https://bugzilla.gnome.org/show_bug.cgi?id=790891 for the related
mutter bug.

https://bugzilla.gnome.org/show_bug.cgi?id=790792
2018-03-29 12:09:59 +02:00
Andrea Azzarone
d918b02c1f online-accounts: Complete account removal in cc_goa_panel_finalize()
When removing an online account, gnome-control-center gives the user
the possibility to undo the action showing an "undo notification".
Right now if you close the gnome-control-center window, without dismissing
the notification, the online account will not be properly removed.

https://gitlab.gnome.org/GNOME/gnome-control-center/issues/25
2018-03-27 21:09:46 +00:00
Ondrej Holy
05c86d3fdc user-accounts: Prevent freeze caused by external cameras
cheese_camera_device_monitor_new freezes the whole panel when opening
for a couple of seconds if external camera is connected. This is not
acceptable. Probably it is bug in kernel. Let's use GAsyncInitable if
available.

Bump the cheese dependency accordingly.

https://bugzilla.gnome.org/show_bug.cgi?id=783789
2018-03-26 10:15:31 +02:00
Rasmus Thomsen
f957ce1776
user-accounts: fix building without cheese
https://gitlab.gnome.org/GNOME/gnome-control-center/merge_requests/10
2018-03-20 17:24:04 +01:00
Georges Basile Stavracas Neto
a1bace4683 build: Drop libgd
Settings does not use libgd.
2018-03-16 15:55:10 -03:00
Georges Basile Stavracas Neto
9a611e0d69 keyboard: Remove deprecated gdk_error_trap_push|pop calls
Instead, implement custom error push and pop functions that mimic
what GDK used to do, but using only non-deprecated functions.
2018-03-16 14:56:28 -03:00
Georges Basile Stavracas Neto
0269f6e5b2 keyboard: Trivial update to code style
This fixed many code style issues in wm-common, and add
a few g_autofree when possible.
2018-03-16 14:39:31 -03:00
Georges Basile Stavracas Neto
aba1647bea keyboard: Silence initialization warning
This field is always initialized properly before being
used, so let's not initialize it when declaring.
2018-03-16 14:19:43 -03:00
Georges Basile Stavracas Neto
ee66dc5f3f keyboard: Turn gchar** into GStrv and use g_auto 2018-03-16 14:18:45 -03:00
Georges Basile Stavracas Neto
4496b60c73 keyboard: Make unused public function static
It is not used outside wm-common.c, so let's not export
it as a public function.
2018-03-16 14:14:41 -03:00
Georges Basile Stavracas Neto
2416b4278d keyboard: Remove unused include 2018-03-16 14:14:11 -03:00
Georges Basile Stavracas Neto
1643674a24 bluetooth: Replace GtkAlignment by halign and valign properties
This removes the last deprecation warning in the Bluetooth panel.
2018-03-16 13:51:25 -03:00
Georges Basile Stavracas Neto
5659271ec3 build: Drop remaining libnm-glib usage
This library is deprecated for a long time now, and Fedora Rawhide
removed the package. Since our CI is based on Rawhide, it began
to fail.

In the end, the usage was just legacy code that doesn't exist anymore,
so it's pretty safe to just plain drop it.
2018-03-16 13:03:04 -03:00
Mohammed Sadiq
f6b3afb9d2 display: Increase popover margins to match mockup
https://bugzilla.gnome.org/show_bug.cgi?id=793165
2018-03-16 02:32:55 -03:00
Georges Basile Stavracas Neto
cf163ef0df universal-access: Use transient-for display
This prevents us from triggering a warning.
2018-03-16 02:07:17 -03:00
Georges Basile Stavracas Neto
a5b766f7f0 universal-access: Move widget setup code to constructed()
This is in preparation for using the transient-for window to
retrieve the GdkMonitor.
2018-03-16 02:06:28 -03:00
Georges Basile Stavracas Neto
6cd9461807 universal-access: Turn ZoomOptions into a template class
This commit turns the ZoomOptions into a template class that
subclasses GtkDialog.

This is also a follow-up from commit c82deede1 where we started
using the non-deprecated GdkMonitor API.
2018-03-16 02:01:38 -03:00
Mario Sanchez Prada
ca9228bb59 display: Early return in monitor_labeler_show() if no outputs are available
The GVariant constructed here would be useless otherwise, since there are
no outputs to show the labels for. Besides, calling g_variant_builder_close
in this scenario would hit an assertion and the program would crash.

https://gitlab.gnome.org/GNOME/gnome-control-center/issues/12
2018-03-14 23:27:44 +00:00
Benjamin Berg
729db87249 network: Remove dead code trying to use NMConnection as NMActiveConnection
These code paths could never be hit as an NMConnection cannot be an
NMVpnConnection which is a descendant of NMActiveConnection.

https://bugzilla.gnome.org/show_bug.cgi?id=794171
2018-03-12 17:29:53 +01:00
Benjamin Berg
72ef675a36 network: Fix warning about missing cast to GtkWidget*
https://bugzilla.gnome.org/show_bug.cgi?id=794171
2018-03-12 16:15:19 +01:00
Benjamin Berg
3117e2dc4a network: Remove nagging code which removed from libnma
This has been removed long ago and there are only stubs left for g-c-c.

See also:
- https://bugzilla.gnome.org/show_bug.cgi?id=706964
- https://git.gnome.org/browse/network-manager-applet/commit/?id=e21d598896ccd2c52850f52d21fe1d5aaa4e5410

https://bugzilla.gnome.org/show_bug.cgi?id=794171
2018-03-12 16:14:47 +01:00
Bastien Nocera
4663ba2fac network: Fix crash opening "Hidden network" dialogue
Both the Network panel and libnma expect UI resources in the
same location, which will cause problems when the Network panel loads
its own version that doesn't quite match up to the code used in libnma.

This fixes a crash when nma_wifi_dialog_new_for_hidden() is called and
libnma expects a domain widget to be present, which it isn't in our
version of the UI files.

https://bugzilla.gnome.org/show_bug.cgi?id=785099
2018-03-12 14:39:10 +01:00
Bastien Nocera
7289e21ef1 network: Fix crash due to object name clashes in NM and g-c-c
1. open Wi-Fi Settings
2. Menu -> Known Wi-fi Networks
3. Click settings of some Wi-Fi network listed there.
4. Press escape twice to close all the dialogs
5. Menu -> Connect to Hidden network..,

Fix crashes when some object type names (WirelessSecurity and
EAPMethod in this case) are duplicated across the Network
panel and libnma.

Fixes a regression in commit 0470c04

https://bugzilla.gnome.org/show_bug.cgi?id=785099
2018-03-12 14:27:18 +01:00
Georges Basile Stavracas Neto
c82deede1c universal-access: Port to GdkMonitor API
This removes the last deprecation warning of the Universal
Access panel by porting the GdkScreen API usage to the
GdkMonitor API.
2018-03-07 12:10:22 -03:00
Georges Basile Stavracas Neto
cec979ae0c universal-access: Replace GtkHScale
Following the previous commit, this one replaces GtkHScale
by GtkScale. No GtkVScale was found in Universal Access
panel (or any other panel).
2018-03-07 11:56:26 -03:00
Georges Basile Stavracas Neto
86413dc6d5 universal-access: Replace GtkHBox and GtkVBox
We can simply use a GtkBox and set the orientation property.
Since this property defaults to 'horizontal', we actually
only need to set it when replacing GtkVBox.
2018-03-07 11:50:07 -03:00
Georges Basile Stavracas Neto
9e8a4729f0 color: Remove deprecated functions and silence compiler warnings
The color calibration code called on GdkScreen API, an API that is
now mostly deprecated in favour of GdkDisplay and GdkMonitor.

This commit updates that, and also removes a compiler warning about
different enum types.
2018-03-07 11:08:43 -03:00
Georges Basile Stavracas Neto
23fadca422 user-accounts: Force symlink creation
So that we can run Settings more than once in GNOME Builder.
Without the -f flag, ln errs out after these symlinks are
created, and Builder refuses to run after that.
2018-03-06 22:02:58 -03:00
Andrea Azzarone
3aa89a836a online-accounts: Restore the "add" command
This reverts parts of commit 5a04e40fef
that don't use goa_provider_set_preseed_data.

https://bugzilla.gnome.org/show_bug.cgi?id=794012
2018-03-05 17:48:26 +01:00
Marek Kasik
5663a8189c Printers: Fix closing of Jobs dialog
When user presses Esc key on Jobs dialog when there
is a job which needs authentication then the dialog
is not closed. This commit fixes this issue.
2018-03-05 17:02:44 +01:00
Marek Kasik
1225766e1f Printers: Don't focus non-realized widgets
This commit removes focusing of widgets in authentication dialog
which could happen when user traverses Jobs dialog via Tab key
if there are some jobs which need authentication.
Lets rely on standard focus chain.
2018-03-05 17:02:41 +01:00
Benjamin Berg
1d72a0b350 power: Fix crash when panel is closed quickly
Fix a use-after-free while creating the dbus proxy for
org.gnome.SettingsDaemon.Power.Keyboard. This fix is identical to the
previous fix for the screen proxy.

https://bugzilla.gnome.org/show_bug.cgi?id=794089
2018-03-05 16:47:52 +01:00
Ondrej Holy
2ef0e2aa89 user-accounts: Remove unused cell renderer
With the carousel, the custom user image cell renderer is no more needed.
2018-03-02 08:21:09 +00:00
Ondrej Holy
93f8920ae5 user-accounts: Do not show legacy face images
Legacy face images should not be shown in avatar chooser, so let's filter
all symlinks to the legacy files out.

Closes: https://gitlab.gnome.org/GNOME/gnome-control-center/issues/5
2018-03-02 08:59:49 +01:00
Ondrej Holy
6e4d75eaaf user-accounts: Add back legacy image faces
Commit ffe5aac8 introduced new set of face images and removed the old
ones. Consequently, generic avatar is shown for people after update.
Add back legacy images, so people won't lose their current images on
update. Add them into the subfolder and create symlinks for them,
so it can be simply filtered out from the chooser widget, because just
the new images should be shown.

https://gitlab.gnome.org/GNOME/gnome-control-center/issues/5
2018-03-02 08:59:49 +01:00
Ondrej Holy
ff0ec34161 user-accounts: Rename new face images which conflicts with old ones
We want to add back legacy images, so let's rename the new ones to not
be in a conflict. This unfortunately can cause another breakage for
people which uses development versions, but we can't do much about it.

https://gitlab.gnome.org/GNOME/gnome-control-center/issues/5
2018-03-02 08:59:49 +01:00
Ondrej Holy
7bc7aa6e59 user-accounts: Use GIO API for face images handling
GFile is needed for face widgets anyway, so let's use GFileEnumerator
for dir listing instead of POSIX API.

https://gitlab.gnome.org/GNOME/gnome-control-center/issues/5
2018-03-02 08:59:49 +01:00
Will Cooke
817a065e50 network: Use monospace font for wi-fi hotspot password
https://bugzilla.gnome.org/show_bug.cgi?id=785413
2018-03-01 11:22:38 -05:00
Marek Kasik
873c2c6839 Printers: Add commandline action "show-jobs"
Add action "show-jobs" to printers panel which
gets printer name as a parameter and shows user
jobs dialog.
Syntax for trigerring this action looks like:
"gnome-control-center printers show-jobs my-local-printer".

https://bugzilla.gnome.org/show_bug.cgi?id=758170
2018-02-26 14:33:30 +01:00
Marek Kasik
91328078fe Printers: Fix GVariant handling
Some const strings taken from GVariants were used
after their GVariants were unreffed.

https://bugzilla.gnome.org/show_bug.cgi?id=758170
2018-02-26 14:33:27 +01:00
Piotr Drąg
7265bd53a0 Add translator comments to .desktop files
Icons are confusing translators, and gettext
is unlikely to get fixed any time soon.
2018-02-23 18:49:35 +01:00
Bastien Nocera
e047753ea6 wifi: Show the "Wi-Fi disabled" page if it is disabled
Rather than an empty "Visible Networks" table.

https://bugzilla.gnome.org/show_bug.cgi?id=793647
2018-02-21 12:29:40 +01:00
Bastien Nocera
84279c4aaa network: Request periodic Wi-Fi scans
As NetworkManager from version 1.10 doesn't handle background scanning
itself, to minimise battery drain, we need to periodically request it to
scan for Wi-Fi Access Points.

We now do this request every 15 seconds, as NetworkManager-applet and
gnome-shell do, and disable that periodic scan if Wi-Fi is disabled.

https://bugzilla.gnome.org/show_bug.cgi?id=793647
2018-02-21 12:29:40 +01:00
Bastien Nocera
d2f1155639 power: Fix crash when panel is closed quickly
Another use-after-free on cancellation crash.

 #0  g_type_check_instance_cast (type_instance=type_instance@entry=0x1eac3c0, iface_type=32150864) at /glib/gobject/gtype.c:4057
 #1  0x0000000000494077 in got_screen_proxy_cb (source_object=<optimized out>, res=0x1eceab0, user_data=user_data@entry=0x1eac3c0)
     at panels/power/cc-power-panel.c:1083

https://bugzilla.gnome.org/show_bug.cgi?id=789464
2018-02-20 10:59:18 +01:00
Felipe Borges
849e50b70e wifi: Revert "Add a refresh button"
This reverts commit 5ad72b6faa.

See https://bugzilla.gnome.org/793238
2018-02-20 10:04:48 +01:00
Marek Kasik
ee1b9a8729 Printers: Make jobs dialog wider
Request width of 720 pixels for jobs dialog and
constrain maximal number of character in displayed
jobs titles to 40 chars. Ellipsize at the end
if the job title is longer.

https://bugzilla.gnome.org/show_bug.cgi?id=758170
2018-02-20 01:13:16 +01:00
Marek Kasik
aa0819894f Printers: Add commandline action "authenticate-jobs"
Add action "authenticate-jobs" to printers panel which
gets printer name as a parameter and asks user for
credentials.
Syntax for trigerring this action looks like:
"gnome-control-center printers authenticate-jobs my-local-printer".

https://bugzilla.gnome.org/show_bug.cgi?id=758170
2018-02-20 01:13:13 +01:00
Marek Kasik
212b8a6504 Printers: Add method for authentication of jobs to PpPrinterEntry
This commit adds method for triggerring of authentication of print jobs
to PpPrinterEntry. This is needed for asking for authentication of jobs
of a printer from the main panel.

https://bugzilla.gnome.org/show_bug.cgi?id=758170
2018-02-20 01:13:09 +01:00
Marek Kasik
1be3901b67 Printers: Add authentication dialog for print jobs
This commit adds popup dialog to jobs dialog which can be accessed
if there is a print job which needs authentication.
Clicking "Authenticate" button will reveal this dialog
where user can enter credential info for the actual printer
and clicking the "Authenticate" in it will authenticate all
print jobs of this printer which needs authentication info
and will send them for printing.

https://bugzilla.gnome.org/show_bug.cgi?id=758170
2018-02-20 01:13:06 +01:00
Marek Kasik
90e306df20 Printers: Get "job-hold-until" attribute for jobs
Get "job-hold-until" attribute when getting list of jobs. If it has value
"auth-info-required" then get "auth-info-required" attribute of the printer
and store it in PpJob's "auth-info-required" property.

https://bugzilla.gnome.org/show_bug.cgi?id=758170
2018-02-20 01:13:03 +01:00