Commit graph

88 commits

Author SHA1 Message Date
Ondrej Holy
64007ce52d user-accounts: Do not crash because of libpwquality failures
Users panel crashes with g_error() if some of libpwquality calls fails,
e.g. when pwquality.conf is broken. The default values should be used
instead of crash. Let's use g_warning() instead of g_error() in that
case.

https://gitlab.gnome.org/GNOME/gnome-control-center/issues/171
2018-09-10 22:04:23 +00:00
Ondrej Holy
70d8427b04 user-accounts: Add casts to suppress gcc warnings
"warning: passing argument 1 of ‘gtk_widget_destroy’ from incompatible
pointer type" is printed from g_clear_pointer, because it is more
type-safe now. See https://gitlab.gnome.org/GNOME/glib/issues/1425 for
more info. Add the necessary casts to suppress the warnings.
2018-08-15 22:12:12 +00:00
Ondrej Holy
833c18bce4 user-accounts: Use the same phrase when passwords do not match
Use "The passwords do not match." phrase in the Add User dialog and
Password dialog consistently.
2018-07-12 10:11:25 +02:00
Robert Ancell
5e91cc7140 user-accounts: Correctly hide password mismatch warnings
The logic for the password mismatch warnings didn't handle the case where
you deleted both the passwords - it would still show them as not
matching.

Fix this by handling the three cases:
- Passwords are different
- Passwords are the same
- No passwords entered
2018-07-11 16:19:54 +02:00
Ondrej Holy
525adcf10b user-accounts: Fix entry sensitivity after password generation
If a password is generated and prefilled in the corresponding entries,
the verify entry remains insensitive. Let's fix the sensitivity...

https://gitlab.gnome.org/GNOME/gnome-control-center/issues/38
2018-07-11 10:38:57 +02:00
Ondrej Holy
d07a67fcb3 user-accounts: Validate password before moving focus
If <tab> is pressed and password is not yet validated (ie. the verify
entry is not sensitive), focus skips the verify entry, even if the
password is strong enough. Let's validate the password when <tab> is
pressed (ie. before focus change) to prevent this <tab> breakage...

https://gitlab.gnome.org/GNOME/gnome-control-center/issues/38
2018-07-11 10:38:57 +02:00
Ondrej Holy
ae16a8e7a0 Revert "user-accounts: Don't disable the verify password entry"
This reverts commit 7b3746af23.

This is needed to make obvious that password is not yet strong
enough.

Closes: https://gitlab.gnome.org/GNOME/gnome-control-center/issues/38
2018-07-11 10:38:57 +02:00
Robert Ancell
678beb6712 user-accounts: Replace GObject boilerplace with G_DECLARE_TYPE 2018-06-01 11:04:18 +00:00
Ondrej Holy
f4b1fb66a4 user-accounts: Fix hint for wrong enterprise user/password
A variable of label widget, used for a hint when wrong enterprise
user/password is used, is not properly initialized and thus criticals
are shown instead of the hint when user/password is wrong. Let's bind
the variable properly.
2018-05-12 04:12:43 +00:00
Ondrej Holy
85f267bfa7 user-accounts: Port UmRealmManager to GTask
https://gitlab.gnome.org/GNOME/gnome-control-center/issues/20
2018-04-25 19:11:37 +02:00
Ondrej Holy
3cf277eb68 user-accounts: Port UmAccountDialog to GTask
https://gitlab.gnome.org/GNOME/gnome-control-center/issues/20
2018-04-25 19:11:35 +02:00
Ondrej Holy
51c9a3235b user-accounts: Fix password strenght check
It is possible to use weak passwords in dialogs currently, which is
not intentional and leads to problems in case of changing password of
current user. This regression was introduced by Bug 780002, which added
new strength level for weak passwords. Let's reflect the new level also
when setting sensitivity...

https://bugzilla.gnome.org/show_bug.cgi?id=788122
2017-09-25 14:23:24 +02:00
Ondrej Holy
e89d4f59c2 user-accounts: Add strength indicator level for weak passwords
Add first level for short, or weak passwords to be obvious that
the strength indicator signalize something.

https://bugzilla.gnome.org/show_bug.cgi?id=780002
2017-05-03 11:37:28 +02:00
Ondrej Holy
9e4123363e user-accounts: Remove unused password hints
Short password hints are not used for some time. Let's remove them.

https://bugzilla.gnome.org/show_bug.cgi?id=780002
2017-05-03 11:37:28 +02:00
Ondrej Holy
3d8d45ab6b user-accounts: Fix wording mistake
https://bugzilla.gnome.org/show_bug.cgi?id=781133
2017-05-03 10:30:34 +02:00
Ondrej Holy
60c315b53b user-accounts: Fix crash when name is changed and dialogue closed
Wrong variables are used to store timeout id, consequently, the sources
are not properly removed in all cases. Then the dialog may crash in certain
cases if it is closed before the source functions are called.

https://bugzilla.gnome.org/show_bug.cgi?id=778595
2017-02-16 09:21:42 +01:00
Ondrej Holy
9440035560 user-accounts: Don't modify pre-filled username
If user type custom username, don't modify it automatically when
changing fullname.

https://bugzilla.gnome.org/show_bug.cgi?id=778555
2017-02-14 18:44:52 +01:00
Piotr Drąg
1e1509240e user-accounts: use Unicode in translatable strings
See https://developer.gnome.org/hig/stable/typography.html

https://bugzilla.gnome.org/show_bug.cgi?id=772199
2016-10-03 15:21:21 +02:00
Felipe Borges
09cbc05608 user-accounts: move Add User dialog buttons to ui file
https://bugzilla.gnome.org/show_bug.cgi?id=767065
2016-06-14 13:12:19 +02:00
Felipe Borges
1db970ecca user-accounts: port "Add User" dialog to gtk+ composite widget templates
https://bugzilla.gnome.org/show_bug.cgi?id=767065
2016-06-14 13:08:21 +02:00
Felipe Borges
de0de51406 user-accounts: split join-dialog from account-dialog
The UmAccountDialog class will be ported to gtk widget templates,
in doing so, we are decoupling here the gtkbuilder dependend ui
code from what will be the class code in the port.

Nothing changed in the join-dialog ui code itself.

https://bugzilla.gnome.org/show_bug.cgi?id=767065
2016-06-14 11:25:45 +02:00
Felipe Borges
efc887c419 user-accounts: use radio buttons for account type in Add User dialog
https://wiki.gnome.org/Design/SystemSettings/UserAccounts

https://bugzilla.gnome.org/show_bug.cgi?id=767065
2016-06-01 17:10:56 +02:00
Felipe Borges
6d24ed5ae9 user-accounts: update strings to new design
https://wiki.gnome.org/Design/SystemSettings/UserAccounts

https://bugzilla.gnome.org/show_bug.cgi?id=767065
2016-06-01 11:43:08 +02:00
Jiro Matsuzawa
04a8943cfd user-accounts: Give mnemonic to labelled widgets
https://bugzilla.gnome.org/show_bug.cgi?id=736606
2016-01-18 17:21:17 +01:00
Ondrej Holy
7ce6ce6807 user-accounts: Fix enterprise user login permitting
Commit 3e6b741a introduced check for NULL on um_realm_object_get_common.
Unfortunatelly one check is wrong and breaks the login permitting.
The patch fixes the wrong check.

https://bugzilla.gnome.org/show_bug.cgi?id=752405
2015-07-15 17:34:49 +02:00
Ondrej Holy
3e6b741ad2 user-accounts: check for NULL on um_realm_object_get_common
um_realm_object_get_common can return NULL, which shouldn't be passed
into subsequent functions to avoid crashes.

https://bugzilla.gnome.org/show_bug.cgi?id=705351
2015-02-25 15:50:17 +01:00
Ondrej Holy
f0e8f9d161 user-accounts: fix crash when network changes
Add user dialog crashes if it has been closed and network configuration
changes, because the dialog is already disposed, but on_network_changes
callback is executed. To fix this crash network monitor signal handler
has to be disconnected on dispose.

https://bugzilla.gnome.org/show_bug.cgi?id=742439
2015-01-06 12:20:55 +01:00
Ondrej Holy
3695f858dd user-accounts: use GtkStack instead of GtkNotebook in Add user dialog
https://bugzilla.gnome.org/show_bug.cgi?id=734422
2014-08-15 17:21:40 +02:00
Ondrej Holy
0f3575b317 user-accounts: avoid removing non-existent GSources
Source id have to be zeroed correctly.

https://bugzilla.gnome.org/show_bug.cgi?id=734548
2014-08-14 13:51:56 +02:00
Ondrej Holy
e4efd5eafd user-accounts: prefill domain entry
If we already have any configured realm, prefill one.

https://bugzilla.gnome.org/show_bug.cgi?id=711675
2014-08-09 14:33:16 +02:00
Ondrej Holy
608fa9609c user-accounts: fix enterprise toggle
Enterprise toggle isn't shown due to header bar buttons. Don't add
the toggle in to the dialog action area to fix the bug.

https://bugzilla.gnome.org/show_bug.cgi?id=734422
2014-08-09 14:33:12 +02:00
Ondrej Holy
08a00388be user-accounts: fix warning caused by invalid signal 2014-08-07 11:55:43 +02:00
Yosef Or Boczko
5a8a96dcbb user-accounts: Use header bar in the account dialog
https://bugzilla.gnome.org/show_bug.cgi?id=724299
2014-04-28 17:29:18 +03:00
Ondrej Holy
a53905f030 user-accounts: don't append period at the end of sentence
The period is appended at the end of sentences after there are
translated. However some languages might not use periods at the
end of sentences. This patch changes the texts directly.
2014-04-25 13:05:56 +02:00
Daniel Mustieles
2c5951819d Updated FSF's address 2014-01-29 11:27:38 +01:00
Rui Matos
3b485b6df2 user-accounts: Don't leak a dialog
https://bugzilla.gnome.org/show_bug.cgi?id=708286
2013-10-01 10:05:03 +02:00
Ondrej Holy
60e1999618 user-accounts: add password generation to the add user dialog
https://bugzilla.gnome.org/show_bug.cgi?id=706067
2013-08-16 23:08:44 +02:00
Ondrej Holy
12da80928e user-accounts: let realmd prefil the DHCP domain if it's joinable
https://bugzilla.gnome.org/show_bug.cgi?id=704407
2013-08-16 22:47:18 +02:00
Ondrej Holy
cb056263fd user-accounts: Hint improvements when adding enterprise accounts
Add domain hint and change error messages.

https://bugzilla.gnome.org/show_bug.cgi?id=704407
2013-08-16 22:24:19 +02:00
Ondrej Holy
a4bac32271 user-accounts: move strength meter below in the add user dialog
Remove strength hint, add verify hint, change labels and replace domain spinner
by dialog spinner.

https://bugzilla.gnome.org/show_bug.cgi?id=704407
2013-08-16 22:24:05 +02:00
Stef Walter
7ae6814784 user-accounts: Validate dialog immediately when enter is pressed
This allows users to touch type passwords, press <ENTER> without
waiting for the pasword timeout to clear.

https://bugzilla.gnome.org/show_bug.cgi?id=702476
2013-08-16 21:56:29 +02:00
Stef Walter
7b3746af23 user-accounts: Don't disable the verify password entry
This completely breaks pressing <TAB> to get to the next
control in the dialog, especially when immediately typing
a password.

https://bugzilla.gnome.org/show_bug.cgi?id=702476
2013-08-16 21:56:29 +02:00
Ondrej Holy
af691e6122 user-accounts: add positive confirmation to the add user dialog
Add checkmarks, remove exclam icons and decrese timeout (by design).

https://bugzilla.gnome.org/show_bug.cgi?id=702476
2013-08-16 21:56:29 +02:00
Ondrej Holy
7f3f853fb3 user-accounts: username generation fix
https://bugzilla.gnome.org/show_bug.cgi?id=703748
2013-08-15 09:16:39 +02:00
Ondrej Holy
39e6b6d044 user-accounts: Info message when we are offline
https://bugzilla.gnome.org/show_bug.cgi?id=702477
2013-08-14 22:29:53 +02:00
Stef Walter
66893e9f40 user-accounts: Remove some unused code in UmAccountDialog
We don't use UmAccountDialog.mode_areas

https://bugzilla.gnome.org/show_bug.cgi?id=705990
2013-08-14 16:02:21 +02:00
Ondrej Holy
0510baa660 user-accounts: Remove a domain validation error icon
https://bugzilla.gnome.org/show_bug.cgi?id=702479
2013-08-07 18:37:38 +02:00
Jonh Wendell
7e62ec47ce user-accounts: really selects the newly-created user
complement to f438da7c3b

make sure to only return the newly created User object when
it is fully loaded.

https://bugzilla.gnome.org/show_bug.cgi?id=704426
2013-07-30 09:47:23 -03:00
Ondrej Holy
8c43927d83 user-accounts: fix compilation warning and function name
https://bugzilla.gnome.org/show_bug.cgi?id=704741
2013-07-24 10:17:59 +02:00
Ondrej Holy
86e45a5c74 user-accounts: Add user account dialog redesign
https://bugzilla.gnome.org/show_bug.cgi?id=689344
2013-06-05 16:43:12 +01:00