When the window is small, the rows show a broken icon in the reveal
button, because the "view-layout-symbolic" icon can't be found.
To fix this, replace such icon with "view-reveal-symbolic", as per
latest mockups[1].
[1] 3a5fe844dd
AdwDialog handles Escape for us, and the dialog isn't a window so
`window.close` isn't necessarily what we want. It's not actually a bug
right now (I guess AdwDialog prevents the Escape key event from bubbling
up), but in the future if something changes, then emitting window.close
might just close the entire GNOME Settings window
Doing so, the "Network Unavailable" status page can be set
in cc-network-panel.ui, as .ui files are the appropriated
place to put UI stuff as much as possible.
Also, remove cc-network-panel.c from POTFILES.in, as there
are no translatable strings in that file anymore.
Matthijs does an outstanding job contributing to various aspects of
GNOME Settings, and has agreed to be listed as co-maintainer.
Signed-off-by: Felipe Borges <felipeborges@gnome.org>
Use a GtkListBox placeholder widget to show the
"No input source selected" message. Also, remove the
hexpand and vexpand properties from the list box, which
currently aren't doing anything.
According to [1], the string "This could be the result of
the graphics driver being used, or the desktop being used
remotely" should end with a period. This wasn't addressed
in [2], so add the period to fix this issue.
[1] https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2020
[2] 909f068672
Night light can be unavailable in three cases:
- Device being used remotely
- Unsupported graphics driver
- Using a virtual machine
In all of these cases, a GtkInfoBar is shown. However, GtkInfoBar is
deprecated. AdwBanner is the replacement, but it's meant for short
text and the text explaining the three cases above is quite long for
AdwBanner. AdwStatusPage can be used with longer text, so use it.
Splitting the translation for the CcSpeakerTestButton tooltip is not
ideal. However, fixing that would require keeping track of all the
`pa_channel_position_t` and translating all speaker names as well.
From context of the dialog, it's obvious that it is about testing
speakers, so we can also go with tooltips like "Front Left" instead
of "Front Left Speaker".
We then don't need any translations.
Partially reverts commit a8148b40, but keeps the tooltips and screen
reader output is the same now as before a8148b40.
Fixes#2905
The full icon name is `org.gnome.Settings-accessibility-symbolic`. Even
though it was still being found due to the way icon lookup works, the
Fedora Update System (bodhi) Automated Testing tagged this with
Desktop file /usr/share/applications/gnome-universal-access-panel.desktop
on x86_64 references icon org.gnome.Settings-accessibility but no
subpackages contain org.gnome.Settings-accessibility
So, fix that.
AdwActionRow is already accessible by default.
Also, in [1] the GtkScales were set as activatable-widgets
of their corresponding rows, making the GtkScales to be
correctly a11y-labelled by the row title.
[1] 7e25cd8a8f
Each printer entry/row has several elements such as texts
and buttons. When there lots of printers showing in the
Printers panel (like in a corporate environment, for example),
the printer list can look very cluttered.
To fix this problem, use the new .boxed-list-separate style
class from libadwaita 1.6, which adds a gap between the rows
from a list box.
The dialog gets destroyed when closing but it was only getting recreated
when g-r-d RDP credentials changed. Instead we should recreate the
dialog on demand, just like in desktop sharing.
- In the "No Events" status page, use the .dim-label
style class instead of using the "opacity" property
- Fix a typo in a GtkStackPage name:
(page_unavaliable -> page_unavailable)
- Set the "Device Security Unavailable" status page
directly as a child widget of the panel_unavailable
GtkStackPage. Using AdwPreferencesPage/Group isn't
necessary
- Don't make the "Device Security Unavailable" status
page dimmed, as status pages from other panels aren't
dimmed
- Wrap the "No Events" status page into a GtkBox that
has the .card style, which avoids the .card looking
being incorrectly dimmed
- Use more descriptive names in the stack pages from
firmware_security_log_stack
Previously, the row would remain visible (and do nothing when clicked)
if g-c-c is compiled w/o support for libmalcontent. Now, we make sure to
only show the row if compiled w/ libmalcontent support.
This more clearly indicates that HSI-1 is firmly between HSI-0 and HSI-2
in goodness/badness. It is secure, so the lock icon is locked. It's just
not as great as HSI-2, so it's yellow rather than green.
Tweak the text slightly to improve clarity. For example, instead of just
saying "Checks Failed" let's say "Security Checks Failed." There is
room to make the strings slightly longer.
The hardest part here was deciding what to say about the HSI-1 security
level, which is not described very well currently. I've made the largest
changes at this level.
