Commit graph

2275 commits

Author SHA1 Message Date
Jens Granseuer
2a25f23559 various small tweaks and optimizations
2007-08-12  Jens Granseuer  <jensgr@gmx.net>

	* theme-thumbnail.c: (create_folder_icon),
	(create_gtk_theme_pixbuf), (handle_bytes), (message_from_capplet),
	(message_from_child), (read_pixbuf), (generate_theme_thumbnail):
	various small tweaks and optimizations

svn path=/trunk/; revision=7991
2007-08-12 15:30:07 +00:00
Jens Granseuer
91a555aa0c make sure we have a selection before trying to get the data (bug #465431)
2007-08-11  Jens Granseuer  <jensgr@gmx.net>

	* appearance-style.c: (conv_from_widget_cb): make sure we have a
	selection before trying to get the data (bug #465431)

svn path=/trunk/; revision=7987
2007-08-11 13:17:31 +00:00
Jens Granseuer
6b148c2959 fix leak
2007-08-11  Jens Granseuer  <jensgr@gmx.net>

	* theme-installer.c: (gnome_theme_install_from_uri): fix leak

svn path=/trunk/; revision=7986
2007-08-11 12:47:44 +00:00
Jens Granseuer
7de103f0b6 restrict drag'n'drop installation to the theme tab instead of the entire
2007-08-09  Jens Granseuer  <jensgr@gmx.net>

	* appearance-themes.c: (theme_drag_data_received_cb),
	(themes_init): restrict drag'n'drop installation to the theme tab
	instead of the entire window so lockdown works properly

	* theme-installer.c: (gnome_theme_install_from_uri),
	(gnome_theme_installer_run):
	* theme-installer.h: fix double-free and use-after-free

svn path=/trunk/; revision=7985
2007-08-09 21:00:28 +00:00
Jens Granseuer
c8dc660cf3 reenable theme lockdown
2007-08-09  Jens Granseuer  <jensgr@gmx.net>

	* appearance-themes.c: (themes_init): reenable theme lockdown

svn path=/trunk/; revision=7984
2007-08-09 19:57:48 +00:00
Jens Granseuer
08d807cfb4 tiny optimization
2007-08-09  Jens Granseuer  <jensgr@gmx.net>

	* gnome-wp-xml.c: (gnome_wp_xml_load_list),
	(gnome_wp_xml_save_list):
	* theme-installer.c: (gnome_theme_install_from_uri): tiny optimization

svn path=/trunk/; revision=7982
2007-08-08 22:07:28 +00:00
Jens Granseuer
4279e8b062 Create the icon theme representative before the GTK stock button. Since we
2007-08-08  Jens Granseuer  <jensgr@gmx.net>

	* theme-thumbnail.c: (create_meta_theme_pixbuf):
	Create the icon theme representative before the GTK stock button. Since
	we explicitly set the icon theme for the first, this ensures both are
	drawn with the same icon theme. Before it was possible when changing
	icon themes (especially on slower machines) that the GtkSettings were
	not yet updated and the stock button still used the old theme.

svn path=/trunk/; revision=7981
2007-08-08 21:46:28 +00:00
Jens Granseuer
159ede4aea revert r7973 because it broke color scheme notifications, and add a
2007-08-08  Jens Granseuer  <jensgr@gmx.net>

	* appearance-style.c: (gtk_theme_changed): revert r7973 because it
	broke color scheme notifications, and add a comment
	* appearance-themes.c: (theme_setting_changed_cb), (themes_init):
	connect to some signals from GtkSettings instead of GConf

svn path=/trunk/; revision=7980
2007-08-08 21:32:01 +00:00
Jens Granseuer
5e58d70e8f shave off a number of unnecessary casts
2007-08-07  Jens Granseuer  <jensgr@gmx.net>

	* appearance-desktop.c: (wp_add_images), (wp_dragged_image),
	(desktop_init):
	* appearance-main.c: (main):
	* appearance-style.c: (update_color_buttons_from_settings),
	(check_color_schemes_enabled), (update_cursor_size_scale),
	(prepare_list), (style_init):
	* appearance-ui.c: (ui_init): shave off a number of unnecessary casts

svn path=/trunk/; revision=7975
2007-08-07 21:46:06 +00:00
Jens Granseuer
137138efa4 also remove code that we needed when the thumbnailer was still in-process
2007-08-07  Jens Granseuer  <jensgr@gmx.net>

	* appearance-style.c: (gtk_theme_changed): also remove code that we
	needed when the thumbnailer was still in-process

svn path=/trunk/; revision=7973
2007-08-07 21:01:52 +00:00
Jens Granseuer
3d0bb8f59d make sure we don't run off the end of the array
2007-08-07  Jens Granseuer  <jensgr@gmx.net>

	* gnome-theme-info.c: (read_cursor_theme): make sure we don't run off
	the end of the array

svn path=/trunk/; revision=7972
2007-08-07 20:16:18 +00:00
Jens Granseuer
69749b7dcb copy the name for the default cursor, too, lest we crash on free, and only
2007-08-07  Jens Granseuer  <jensgr@gmx.net>

	* gnome-theme-info.c: (read_cursor_theme),
	(gnome_theme_cursor_info_free): copy the name for the default cursor,
	too, lest we crash on free, and only unref the thumbnail if we have
	one

svn path=/trunk/; revision=7971
2007-08-07 19:44:18 +00:00
Jens Granseuer
44eec9e2a3 remove stuff I forgot to delete
2007-08-07  Jens Granseuer  <jensgr@gmx.net>

	* appearance-style.c: (color_button_clicked_cb): remove stuff I forgot
	to delete

svn path=/trunk/; revision=7970
2007-08-07 19:20:46 +00:00
Jens Granseuer
8cba2c1e8e make sure the color scheme has changed before writing to GConf and
2007-08-07  Jens Granseuer  <jensgr@gmx.net>

	* appearance-style.c: (color_button_clicked_cb): make sure the color
	scheme has changed before writing to GConf and enabling the reset button

svn path=/trunk/; revision=7969
2007-08-07 16:48:02 +00:00
Jens Granseuer
197bc958af simplify (check_color_schemes_enabled): fix check for available symbolic
2007-08-07  Jens Granseuer  <jensgr@gmx.net>

	* appearance-style.c: (update_color_buttons_from_string): simplify
	(check_color_schemes_enabled): fix check for available symbolic colors
	and make buttons for unsupported colors insensitive (bug #464081)
	(color_button_clicked_cb), (style_init): simplify

	* data/appearance.glade: name the color buttons exactly like their
	respective color so we don't need to keep two arrays around

svn path=/trunk/; revision=7968
2007-08-07 16:35:09 +00:00
Jens Granseuer
e0db21068c reinstate select-after-realize; it's still necessary
2007-08-05  Jens Granseuer  <jensgr@gmx.net>

	* appearance-themes.c: (themes_init): reinstate select-after-realize;
	it's still necessary

svn path=/trunk/; revision=7964
2007-08-05 21:32:12 +00:00
Jens Granseuer
b437efed11 Patch by: Dennis Cranston <dennis_cranston@yahoo.com>
2007-08-05  Jens Granseuer  <jensgr@gmx.net>

	Patch by: Dennis Cranston <dennis_cranston@yahoo.com>

	* data/appearance.glade: Indent category contents, and other HIG
	spacing fixes for "Font Rendering Details" dialog (bug #463332)

svn path=/trunk/; revision=7963
2007-08-05 19:24:21 +00:00
Bastien Nocera
314fc15bdd reviewed by: Jens Granseuer <jensgr@gmx.net>
2007-08-05  Bastien Nocera  <hadess@hadess.net>

	reviewed by: Jens Granseuer <jensgr@gmx.net>

	* gnome-keybinding-properties.c: (keyval_is_forbidden),
	(accel_edited_callback): Make the arrows and tabs unbindable
	without a modifier (Closes: #463433)


svn path=/trunk/; revision=7962
2007-08-04 23:11:42 +00:00
Jens Granseuer
6c27578959 Based on a patch by: Dennis Cranston <dennis_cranston@yahoo.com>
2007-08-04  Jens Granseuer  <jensgr@gmx.net>

	Based on a patch by: Dennis Cranston <dennis_cranston@yahoo.com>

        * appearance-style.c: (update_cursor_size_scale) Toggle
        sensitivity of the cursor scale labels (bug #463442)

svn path=/trunk/; revision=7961
2007-08-04 20:11:56 +00:00
Denis Washington
5cfe0df8a6 Also load the "default" cursor theme as GnomeThemeCursorInfo so we know
2007-08-04  Denis Washington  <denisw@svn.gnome.org>

	* common/gnome-theme-info.c: (read_cursor_theme), (look_for_cursor_theme):
	Also load the "default" cursor theme as GnomeThemeCursorInfo so
	we know about the available sizes. (bug #462409)

	* appearance/appearance-style.c: (prepare_list):
	Only add a "Default Pointer" list item if there is
	no such GnomeThemeCursorInfo.

svn path=/trunk/; revision=7960
2007-08-04 13:05:24 +00:00
Jens Granseuer
f7bf24a1cf oops, remove left-over devel ifdef
2007-08-03  Jens Granseuer  <jensgr@gmx.net>

	* appearance-themes.c: (theme_thumbnail_update): oops, remove
	left-over devel ifdef

svn path=/trunk/; revision=7957
2007-08-03 21:19:11 +00:00
Jens Granseuer
54d446ae88 use gdk_color_to_string instead of g_strdup_printf remove check for old
2007-08-03  Jens Granseuer  <jensgr@gmx.net>

	* appearance-desktop.c: (wp_color_changed): use gdk_color_to_string
	instead of g_strdup_printf
	* gnome-wp-xml.c: (gnome_wp_xml_load_xml),
	(gnome_wp_xml_load_list): remove check for old glib version that
	would result in bogus code, and save an unnecessary alloc

svn path=/trunk/; revision=7956
2007-08-03 21:02:47 +00:00
Jens Granseuer
b7ad0952dc use thumbnail factory to store and retrieve metatheme thumbs (bug #448968)
2007-08-03  Jens Granseuer  <jensgr@gmx.net>

	* appearance-desktop.c: (wp_props_load_wallpaper), (wp_add_image),
	(wp_scale_type_changed), (wp_shade_type_changed),
	(wp_update_preview), (wp_load_stuffs), (desktop_init),
	(desktop_shutdown):
	* appearance-main.c: (init_appearance_data),
	(main_window_response):
	* appearance-themes.c: (theme_get_mtime), (theme_thumbnail_update),
	(theme_get_thumbnail_from_cache), (theme_thumbnail_done_cb),
	(theme_thumbnail_generate):
	* appearance.h:
	* gnome-wp-xml.c: (gnome_wp_load_legacy), (gnome_wp_xml_load_xml):
	use thumbnail factory to store and retrieve metatheme thumbs
	(bug #448968)

svn path=/trunk/; revision=7955
2007-08-03 19:53:14 +00:00
Jens Granseuer
aa9ddd3739 reduce metatheme thumbnail size to 128x128 in preparation of using
2007-08-03  Jens Granseuer  <jensgr@gmx.net>

	* data/appearance.glade:
	* data/theme-thumbnailing.png: reduce metatheme thumbnail size to
	128x128 in preparation of using gnome-thumbnail-factory

2007-08-03  Jens Granseuer  <jensgr@gmx.net>

	* theme-thumbnail.c: reduce metatheme thumbnail size to 128x128

svn path=/trunk/; revision=7954
2007-08-03 19:49:32 +00:00
Jens Granseuer
379677ec2f simplify
2007-08-03  Jens Granseuer  <jensgr@gmx.net>

	* appearance-style.c: (color_button_clicked_cb): simplify

svn path=/trunk/; revision=7953
2007-08-03 18:44:42 +00:00
Jens Granseuer
d31c4f7b75 no need for an expensive parse to initialize the colors
2007-08-02  Jens Granseuer  <jensgr@gmx.net>

	* gnome-theme-info.c: (gnome_theme_color_scheme_parse): no need for an
	expensive parse to initialize the colors

svn path=/trunk/; revision=7949
2007-08-02 21:26:03 +00:00
Jens Granseuer
1ab61b2bbc don't generate GTK thumbnails when we want metacity or icon (bug #462724)
2007-08-02  Jens Granseuer  <jensgr@gmx.net>

	* theme-thumbnail.c: (generate_metacity_theme_thumbnail),
	(generate_icon_theme_thumbnail): don't generate GTK thumbnails when we
	want metacity or icon (bug #462724)

svn path=/trunk/; revision=7948
2007-08-02 18:26:43 +00:00
Jens Granseuer
b7c050d006 don't use '==', and improve portability with empty strings
2007-08-01  Jens Granseuer  <jensgr@gmx.net>

	* gnome-at-commandline.in.in: don't use '==', and improve
	portability with empty strings

svn path=/trunk/; revision=7945
2007-08-01 19:28:13 +00:00
Thomas Wood
5a24de992f Path by: Dennis Cranston <dennis_cranston@yahoo.com>
2007-08-01  Thomas Wood  <thos@gnome.org>

	Path by: Dennis Cranston <dennis_cranston@yahoo.com>

	* data/appearance.glade:  Add a few more mnemonics.  HIG capitalization 
	  fix for a checkbutton label.

svn path=/trunk/; revision=7943
2007-08-01 08:37:08 +00:00
Jens Granseuer
3c5a53064b use g_get_user_special_dir() instead of hardcoding ~/Pictures
2007-07-31  Jens Granseuer  <jensgr@gmx.net>

	* gnome-about-me.c: (about_me_image_clicked_cb): use
	g_get_user_special_dir() instead of hardcoding ~/Pictures

svn path=/trunk/; revision=7942
2007-07-31 21:22:38 +00:00
Jens Granseuer
3bb830b0ac add a shortcut to the user's special Pictures folder to the file chooser
2007-07-31  Jens Granseuer  <jensgr@gmx.net>

	* appearance-desktop.c: (wp_file_open_dialog), (desktop_init):
	* appearance.h: add a shortcut to the user's special Pictures folder to
	the file chooser and default to it (bug #461093), and reduce casting

svn path=/trunk/; revision=7941
2007-07-31 21:15:02 +00:00
Jens Granseuer
147912ed01 fix cut'n'paste errors for the tooltip colors and use new color enum
2007-07-30  Jens Granseuer  <jensgr@gmx.net>

	* appearance-style.c: (color_button_clicked_cb): fix cut'n'paste errors
	for the tooltip colors and use new color enum

	* data/appearance.glade: repair the mess glade3 made of the file

2007-07-30  Jens Granseuer  <jensgr@gmx.net>

	* gnome-theme-info.c: (gnome_theme_color_scheme_parse),
	(gnome_theme_color_scheme_equal):
	* gnome-theme-info.h: add symbolic colors enum and use it

svn path=/trunk/; revision=7936
2007-07-30 18:22:00 +00:00
Thomas Wood
e82c2b596e Add missing '\n'.
2007-07-30  Thomas Wood  <thos@gnome.org>

	* appearance-style.c: (color_button_clicked_cb): Add missing '\n'.

svn path=/trunk/; revision=7935
2007-07-30 16:59:41 +00:00
Jens Granseuer
a215c9db04 use our custom cell renderer for metathemes, too, so the previews don't
2007-07-30  Jens Granseuer  <jensgr@gmx.net>

	* appearance-themes.c: (themes_init):
	* data/appearance.glade: use our custom cell renderer for metathemes,
	too, so the previews don't get shaded (bug #461198)

svn path=/trunk/; revision=7934
2007-07-30 16:54:37 +00:00
Thomas Wood
12faf7f40e Add tooltip foreground and background colours to the list of recognised
2007-07-30  Thomas Wood  <thos@gnome.org>

	* appearance-style.c: (update_color_buttons_from_string),
	(check_color_schemes_enabled), (color_button_clicked_cb),
	(style_init):
	* data/appearance.glade:

	Add tooltip foreground and background colours to the list of recognised
	symbolic colours.

2007-07-30  Thomas Wood  <thos@gnome.org>

	* gnome-theme-info.c: (gnome_theme_color_scheme_parse): Add tooltip foreground
	and background colours to the list of recognised symbolic colours.

svn path=/trunk/; revision=7933
2007-07-30 16:49:28 +00:00
Jens Granseuer
ebff839891 default to showing the background tab if wallpapers were given on the
2007-07-29  Jens Granseuer  <jensgr@gmx.net>

	* appearance-main.c: (main): default to showing the background tab
	if wallpapers were given on the command line

svn path=/trunk/; revision=7930
2007-07-29 20:21:10 +00:00
Jens Granseuer
59e5742370 add %F to the exec line so external programs like epiphany can set the
2007-07-29  Jens Granseuer  <jensgr@gmx.net>

	* data/gnome-appearance-properties.desktop.in.in: add %F to the exec
	line so external programs like epiphany can set the background (bug
	#456337)

svn path=/trunk/; revision=7929
2007-07-29 18:56:15 +00:00
Jens Granseuer
d23fb65eb6 only create the custom theme entry when changes are made, and delete it
2007-07-29  Jens Granseuer  <jensgr@gmx.net>

	* data/appearance.glade:
	* appearance-themes.c: (theme_custom_cb):
	* theme-save.c: (save_dialog_response): only create the custom theme
	entry when changes are made, and delete it when the theme is saved.
	These changes obsolete the requirement for a modal details window.

svn path=/trunk/; revision=7928
2007-07-29 18:20:31 +00:00
Denis Washington
11cd98e2d1 Don't store the cell renderer in AppearanceData, it is only needed by
2007-07-29  Denis Washington  <denisw@svn.gnome.org>

	* appearance.h:
	* appearance-desktop.c: (desktop_init):
	Don't store the cell renderer in AppearanceData, it is only needed by
	desktop_init().

svn path=/trunk/; revision=7927
2007-07-29 17:45:51 +00:00
Thomas Wood
a316e82ccc Expand check for empty metatheme colour scheme to include blank colour
2007-07-29  Thomas Wood  <thos@gnome.org>

	* gnome-theme-info.c: (gnome_theme_read_meta_theme): Expand check for empty
	metatheme colour scheme to include blank colour scheme strings.

svn path=/trunk/; revision=7926
2007-07-29 17:26:47 +00:00
Jens Granseuer
0921b627db remove spurious AT desktop entries (bug #444787)
2007-07-29  Jens Granseuer  <jensgr@gmx.net>

	* configure.in: remove spurious AT desktop entries (bug #444787)

2007-07-29  Jens Granseuer  <jensgr@gmx.net>

	* Makefile.am:
	* default-applications-accessibility.desktop.in.in:
	* gnome-at-mobility.desktop.in.in:
	* gnome-at-visual.desktop.in.in: remove spurious desktop entries
	(bug #444787)

2007-07-29  Jens Granseuer  <jensgr@gmx.net>

	* POTFILES.in:
	* POTFILES.skip: remove spurious AT desktop entries

svn path=/trunk/; revision=7925
2007-07-29 17:23:02 +00:00
Jens Granseuer
e831657b38 cope with unset GConf keys, and group GConf notifications
2007-07-29  Jens Granseuer  <jensgr@gmx.net>

	* appearance-themes.c: (theme_message_area_update), (themes_init):
	cope with unset GConf keys, and group GConf notifications

svn path=/trunk/; revision=7924
2007-07-29 16:17:44 +00:00
Denis Washington
ad496d45ae _Really_ only show background/font suggestions if they haven't already
2007-07-29  Denis Washington  <denisw@svn.gnome.org>

	* appearance-themes.c: (theme_message_area_response_cb),
	(theme_message_area_update), (theme_selection_changed_cb),
	(background_or_font_changed), (themes_init):
	_Really_ only show background/font suggestions if they haven't
	already been applied.

svn path=/trunk/; revision=7923
2007-07-29 15:37:22 +00:00
Denis Washington
2f8351bca7 Only show background/font suggestions if they haven't already been
2007-07-29  Denis Washington  <denisw@svn.gnome.org>

	* appearance-themes.c: (theme_message_area_response_cb),
	(theme_message_area_update), (theme_selection_changed_cb):
	Only show background/font suggestions if they haven't already
	been applied.

svn path=/trunk/; revision=7922
2007-07-29 14:51:59 +00:00
Denis Washington
35872177c1 Added controls for applying suggested backgrounds and/or fonts from
2007-07-29  Denis Washington  <denisw@svn.gnome.org>

	* data/appearance.glade:
	* appearance-themes.c: (theme_message_area_response_cb),
	(theme_message_area_update), (theme_selection_changed_cb),
	(themes_init), (themes_shutdown):
	* gedit-message-area.[ch]:
	* theme-util.h:
	Added controls for applying suggested backgrounds and/or fonts from
	metathemes. Copied over some code from gedit for the message area
	(GeditMessageArea).

	* Makefile.am:
	Added gedit-message-area.[ch].

svn path=/trunk/; revision=7921
2007-07-29 13:56:10 +00:00
Thomas Wood
23c161aa35 Prevent some memory leaks
2007-07-29  Thomas Wood  <thos@gnome.org>

	* appearance-style.c: (cursor_theme_sort_func), (prepare_list),
	(style_init): Prevent some memory leaks

2007-07-29  Thomas Wood  <thos@gnome.org>

	* gnome-theme-apply.c: (gnome_meta_theme_set):
	* gtkrc-utils.c: (gtkrc_get_details), (gtkrc_get_color_scheme):

	Prevent some memory leaks

svn path=/trunk/; revision=7920
2007-07-29 13:05:29 +00:00
Thomas Wood
930245a60b - Fix theme installation (free called before last last use of a string) -
2007-07-29  Thomas Wood  <thos@gnome.org>

	* theme-installer.c: (file_theme_type), (gnome_theme_install_real):
	- Fix theme installation (free called before last last use of a string)
	- Update icon cache when installing icon themes (closes bug 355486)

svn path=/trunk/; revision=7919
2007-07-29 11:03:05 +00:00
Thomas Wood
d9683907b5 Fix mnemonics and Customize Theme window title. Closes bug 461255.
2007-07-29  Thomas Wood  <thos@gnome.org>

	* data/appearance.glade: Fix mnemonics and Customize Theme window title.
	Closes bug 461255.

svn path=/trunk/; revision=7918
2007-07-29 10:05:54 +00:00
Jens Granseuer
63f30c42f4 get rid of a number of unnecessary casts and the gtk version checks since
2007-07-28  Jens Granseuer  <jensgr@gmx.net>

	* appearance-desktop.c: (wp_view_tooltip_cb), (desktop_init):
	* data/appearance.glade: get rid of a number of unnecessary casts and the
	gtk version checks since we now depend on 2.11.6 unconditionally

svn path=/trunk/; revision=7915
2007-07-28 14:15:48 +00:00
Denis Washington
2834baf127 Read a cursor theme's name from it's index.theme file if it has one.
2007-07-28  Denis Washington  <denisw@svn.gnome.org>

	* common/gnome-theme-info.h:
	* common/gnome-theme-info.c: (look_in_cursor_theme),
	(gnome_theme_cursor_info_free):
	Read a cursor theme's name from it's index.theme file if it has one.

	* appearance/appearance-style.c: (prepare_list):
	Show readable_name in cursor theme list instead of name.

svn path=/trunk/; revision=7914
2007-07-28 13:53:15 +00:00