When using the copy buttons from Desktop Sharing/Remote Login pages,
the toasts don't show that the values were copied to the clipboard,
unlike in System > Secure Shell/About > System Details, for example.
So, fix this inconsistency.
"Add" and "Enroll" buttons can still be sensitive without
calling main_page_validate() and enroll_page_validate()
respectively. Add an assertion check in both cases to
prevent these buttons being sensitive incorrectly.
Co-authored-by: Matthijs Velsink <mvelsink@gnome.org>
"Language" and "Format" rows show their value as a subtitle,
but this is inconsistent with Settings design pattern in which
the value label is shown at the right, so fix this inconsistency.
Closes https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2914
- Use edit-find-symbolic
- Use "No Results Found" title
- Add "Try a different search" description
- Remove the margin-top because this causes the status
page to look misaligned
The first three changes will make the status page to look
more similar to the status page from the Settings sidebar
(when the search term doesn't return anything), improving
consistency.
When the window is small, which makes the
"Hardware Information" and "Software Information"
sections to show vertically, the latter doesn't
properly separate from the first visually. Add a
top margin to fix that.
This also fixes the ".cutout-button" style being
set in "user-accounts-dialog.css", which is wrong
because this widget is located in the main panel
and not in the add user dialog.
The timedate1_call will fail because network time synchronization is enabled:
GDBus.Error:org.freedesktop.timedate1.AutomaticTimeSyncEnabled: Automatic time synchronization is enabled
Let's not set_time when NTP is not available, neither set time by
accident at the widget construction stage. When widgets signals are connected
in the UI file their respective callback was getting called. By moving
the signal connection to callbacks to the widget's _init method we
avoid the unwanted callback call.
Fixes#2945
When copying the login command, a toast appear
saying "Command copied". However, these kind of toasts
usually says that the text was copied *to the clipboard*,
like the toast from System > About > System Details > Copy.
Spaces aren’t supported in .desktop file keywords, as gnome-shell splits
the search term by spaces, and then prefix-matches each word separately
against the candidate keywords.
So a search term of ‘parental’ would match the ‘Parental Controls’
keyword, but a search term of ‘parental controls’ would not, as
‘controls’ doesn’t prefix-match anything.
Avoid that by removing spaces from the keywords.
Signed-off-by: Philip Withnall <pwithnall@gnome.org>
Helps: https://gitlab.freedesktop.org/pwithnall/malcontent/-/issues/48
As the user facing name of this setting changed to "Secure Shell",
let's change its internal name to match it.
This avoids confusion with the Remote Desktop "Remote Session" setting,
which is now named "Remote Login" in the UI and should get its code
renamed to follow that consistently.
Let's manually wire the row activation to the panel creation so that
we can create panels on demand.
This also makes calls to subpages directly avoid initializing the
other panels.
Fixes#2857
At init it will verify whether the panel can be constructed in the
check_desktop_sharing_available call, and with that hide/show the
panel accordingly.
Fixes#2955
Secure Shell and Software Updates rows are
using the letters R and U, respectively, for
their mnemonics. However, these letters are
already taken by other rows (Region & Language
and Users).
Fix that by choosing different letters.
Make this dialog design closer to what mockups
show[1] by:
- Removing window default-width/height,
so the window size follows the content size
- Using a compact AdwStatusPage
- Using larger fingerprint label horizontal margins
and reducing vertical ones
Also:
- Port the window to AdwToolbarView, which
makes the close button position to be consistent
with other windows
- Allow closing the window with ESC
- Add window size request properties to improve
adaptiveness
[1] cbb4810936
"Computer" isn't a suitable term for other device
form factors. Also, there are several strings in
Settings that already use "device", and cc-color-panel.ui
uses a mix of "computer" and "device" strings, which is
weird.
When the Users panel got moved to System, the original .desktop file was
also moved. However, that is now obsolute with
`panels/system/users/gnome-users-panel.desktop.in`. This old file is
also not referenced in any `meson.build` and contains an outdated `Exec`
line.
So, remove it.
A previous commit[1] attempted to prevent "How to Connect"
section string from being translated twice[2].
Desktop Sharing and Remote Login pages have this same
string, but the latter was missing a period at the
end of the phrase, which caused the duplicated issue.
The commit[1] didn't fix the issue entirely, because
the string from the Desktop Sharing page was using
a different apostrophe symbol than the Remote Login page
counterpart (which is the recommended apostrophe symbol
acc. to HIG[3]).
Fix the issue by using the same apostrophe symbol mentioned
above in the string from the Remote Login page. This will
cause the translation from the Desktop Sharing string to be
reused, thus a string freeze break won't happen.
See also: https://gitlab.gnome.org/Teams/Translation/Coordination/-/issues/133
[1] b4131d3b0a
[2] https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2936
[3] https://developer.gnome.org/hig/guidelines/typography.html
Right now we set a subtitle of "" when the port is invalid. This
leads to the "Port" title getting center aligned vertically.
We also keep the port sensitive even when it's empty and there is
little value in copying it.
This commit changes the subtitle to " " so it serves as a
placeholder to keep the "Port" title top aligned. This commit
also makes the port insensitive in that case so the user never
copies the placeholder space.
Closes: https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2934
Right now we set a subtitle of "" when the port is invalid. This
leads to the "Port" title getting center aligned vertically.
We also keep the port sensitive even when it's empty and there is
little value in copying it.
This commit changes the subtitle to " " so it serves as a
placeholder to keep the "Port" title top aligned. This commit
also makes the port insensitive in that case so the user never
copies the placeholder space.
Previously, events from accountsservice would be used to change the
state of the AdwNavigation in ways that don't correspond to the event
that happened. For example, deleting an account would pop the top page
off the stack, even if that page didn't belong to that account.
Especially buggy is the behavior of replacing the currently visible page
with the contents of an account that just changed. systemd-homed changes
the user record whenever authentication happens successfully. So, user
Foo might be trying to edit user Bar, type in their password at the
polkit prompt, and end up looking at a broken version of their own
settings page again: the title would be "Bar", there'd be no list of
users, and hitting the back button would take Foo back to the same
settings page they're currently looking at.
This commits refactors the handling of the accountsservice signals to
fix all the bugs
Fixes https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2911
650p is way too much and makes the bottom bar to
appear when there is still space available in
the headerbar. Use 450p so the bottom bar will only
appear when the headerbar doesn't have enough
space available.
Follow-up from a4224d9e21
When the window width is small, the view switcher
labels get very ellipsized, making them difficult
to read.
Use AdwBreakpointBin to show the view switchers
at the bottom at the page (like in the Mouse & Touchpad
panel) when the window width is small.
- Use halign correctly ("left" and "right" aren't
valid values) and use hexpand in the
"Verify Encryption" button, since halign needs
hexpand set to "true"
- Ditch the spacer box, as it causes the page contents
to not scale correctly when the window width is small
- Add can-shrink property to "Generate New Password" and
"Verify Encryption" buttons so they can shrink when
the window width is small
- Also, set the margin-top only in the GtkBox to avoid
redundancy
Closes https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2933
- Fix the activatable-widget from port_row,
which was pointing to copy_address_button
- Remove a11y labels from copy buttons
because Orca also reads tooltips
- Remove .property style class from entry rows
since this class is only meant to be used
in AdwActionRow and AdwExpanderRow[1]
- Set the copy buttons as suffix widgets
directly, because wrapping them in a GtkBox
is unnecessary
- Fix indentation
[1] https://gnome.pages.gitlab.gnome.org/libadwaita/doc/main/style-classes.html#property-rows
- Fix the activatable-widget from port_row,
which was pointing to copy_address_button
- Remove a11y labels from copy buttons
because Orca also reads tooltips
- Remove .property style class from entry rows
since this class is only meant to be used
in AdwActionRow and AdwExpanderRow[1]
- Set the copy buttons as suffix widgets
directly, because wrapping them in a GtkBox
is unnecessary
- Fix indentation
[1] https://gnome.pages.gitlab.gnome.org/libadwaita/doc/main/style-classes.html#property-rows
The code currently assumes that if the fingerprint is non-null it's
valid, but gnome-remote-desktop can also set the fingerprint to an
empty string if there's no certificate yet.
This commit makes sure to handle both NULL and empty fingerprints.
If the username and password get set then the certificate fingerprint
isn't updated even if that lets the service start.
This commit fixes things by doing a round trip through the service after
setting the username/password to
1. Make sure the change actually worked
2. Trigger our fingerprint dialog setting code that currently only runs
on reading username/password
Remote session support needs to be able to start systemd units
and also manage gnome-remote-desktop.
This commit adds a polkit policy to accomodate both subactions
with one overarching action that only needs to be unlocked one time.
