Commit graph

458 commits

Author SHA1 Message Date
Felipe Borges
50c2af0cfb user-accounts: Avoid markup in "Your Account" label
The label indicating which photo in the Carousel belongs to the
current user had the <small> markup within the translatable string,
causing unnecessary work for translators. See
https://wiki.gnome.org/TranslationProject/DevGuidelines/Avoid%20markup%20wherever%20possible

This patch formats the string with g_strdup_printf, leaving the
markup tags out of the translatable message.
2017-02-24 17:12:10 +01:00
Ondrej Holy
60c315b53b user-accounts: Fix crash when name is changed and dialogue closed
Wrong variables are used to store timeout id, consequently, the sources
are not properly removed in all cases. Then the dialog may crash in certain
cases if it is closed before the source functions are called.

https://bugzilla.gnome.org/show_bug.cgi?id=778595
2017-02-16 09:21:42 +01:00
Ondrej Holy
9440035560 user-accounts: Don't modify pre-filled username
If user type custom username, don't modify it automatically when
changing fullname.

https://bugzilla.gnome.org/show_bug.cgi?id=778555
2017-02-14 18:44:52 +01:00
Jeremy Bicha
206310e9fb user-accounts: Use ellipsis for "Remove User"
https://bugzilla.gnome.org/show_bug.cgi?id=778568
2017-02-13 19:56:07 +01:00
Felipe Borges
51a184b1b7 user-accounts: Align the elements of "Add User" dialog
https://bugzilla.gnome.org/show_bug.cgi?id=778457
2017-02-13 19:15:05 +01:00
Ondrej Holy
8e6fccc8c4 user-accounts: Make user icon bigger
User icon should be bigger as per mockup.

https://bugzilla.gnome.org/show_bug.cgi?id=778458
2017-02-13 14:09:09 +01:00
Allan Day
05f675a037 user-accounts: Give user image button a raised appearance
So it looks clickable.

https://bugzilla.gnome.org/show_bug.cgi?id=778458
2017-02-13 12:22:04 +00:00
Allan Day
e84b10a4a2 user-accounts: Add space above settings
The settings were a bit tightly placed to the top of the panel.
This looks more balanced.

https://bugzilla.gnome.org/show_bug.cgi?id=778458
2017-02-13 12:13:20 +00:00
Felipe Borges
da997dc2ce user-accounts: Save vertical space in the alignment of widgets
Compensate border-width changes with respective margins.

https://bugzilla.gnome.org/show_bug.cgi?id=778458
2017-02-13 12:03:25 +01:00
Ondrej Holy
b4c26363d8 user-accounts: Disable animations when reloading users
Animations cause unwanted effects when reloading users, disable them.

https://bugzilla.gnome.org/show_bug.cgi?id=778405
2017-02-13 11:58:42 +01:00
Ondrej Holy
c8b535007f user-accounts: Don't move with arrow during animations
Don't move with the arrow during the stack animation in order to avoid
some ugly movements...

https://bugzilla.gnome.org/show_bug.cgi?id=778405
2017-02-13 11:58:42 +01:00
Felipe Borges
b8983f906f user-accounts: Animate the Carousel Arrow
https://bugzilla.gnome.org/show_bug.cgi?id=778405
2017-02-13 11:58:42 +01:00
Felipe Borges
bce05cb8bd user-accounts: Animate page transitions in the Carousel
https://bugzilla.gnome.org/show_bug.cgi?id=778405
2017-02-13 11:58:42 +01:00
Felipe Borges
c1f56c3e4a user-accounts: Re-label "Remove Account" button to "Remove User"
"Remove User" matches better to "Add User" than "Remove Account".

https://bugzilla.gnome.org/show_bug.cgi?id=778458
2017-02-13 11:55:32 +01:00
Felipe Borges
92e99f677f user-account: Use a stack in user-icon to keep the same size
This fixes the undesired jumps (resizes) while switching between
"Your Account" and any other account.

https://bugzilla.gnome.org/show_bug.cgi?id=778458
2017-02-13 11:55:32 +01:00
Felipe Borges
ffb2aaabe7 user-accounts: Drop the user photo selector arrow
https://bugzilla.gnome.org/show_bug.cgi?id=778458
2017-02-13 11:55:32 +01:00
Bastien Nocera
5c5d608730 user-accounts: Fix button sensitivity in photo dialogue
g_file_info_get_content_type() returns an internal string, and we were
freeing the file_info we got it from in the next line, so it's a miracle
that the mime_type was ever not garbage.

https://bugzilla.gnome.org/show_bug.cgi?id=778424
2017-02-12 20:09:44 +01:00
Felipe Borges
1610fe581f user-accounts: Make the UmCarouselItems look the same on hover
UmCarouselItem is a button, but since we have now the arrow which
points to the selected item, we don't need any other visual
feedback (such as hover border/background).

https://bugzilla.gnome.org/show_bug.cgi?id=767065
2017-02-09 19:25:28 +01:00
Felipe Borges
d2529a1a09 user-accounts: Add "Your account" label below proper UmCarouselItem
Set a margin for the username label instead of using the container
spacing property. In doing so the labels are not so far apart from
each other, but still distant from the profile icon/image.

https://bugzilla.gnome.org/show_bug.cgi?id=767065
2017-02-09 19:25:28 +01:00
Felipe Borges
8452bebe19 user-accounts: Make the user name label bold in the UmCarouselItem
https://bugzilla.gnome.org/show_bug.cgi?id=767065
2017-02-09 19:25:28 +01:00
Felipe Borges
3a84720fb0 user-accounts: Draw arrow in UmCarousel
The arrow is drawn using CSS.

https://bugzilla.gnome.org/show_bug.cgi?id=767065
2017-02-09 19:25:28 +01:00
Felipe Borges
011cbc0c08 user-accounts: Reorganize the user-options container
This commit merges the hbox2, main-user-vbox, and grid1 into the
"user-options" container.

It also replaces deprecated widgets, such as GtkVBox and GtkHBox.

These changes are according to the new User Accounts panel mockups
at https://wiki.gnome.org/Design/SystemSettings/UserAccounts

https://bugzilla.gnome.org/show_bug.cgi?id=767065
2017-02-09 19:25:28 +01:00
Felipe Borges
d740a9ac98 user-accounts: Introduce UmCarousel
UmCarousel is an horizontal container that contains UmCarouselItem
children. These items are paginated 3 at 3 at the time.

UmCarousel intents to act as controller for content containers. It
emitis the "item-activated" signal whenever an UmCarouselItem gets
activated (clicked).

It automatically activates the first UmCarouselItem of the current
vsible page.

The visibility of the go-back and go-next button is automatically
set based on the number of children.

These changes are according to the new User Accounts panel mockups
at https://wiki.gnome.org/Design/SystemSettings/UserAccounts

https://bugzilla.gnome.org/show_bug.cgi?id=767065
2017-02-09 19:25:28 +01:00
Bastien Nocera
3f0510cac8 build: Better libm checks
Use AC_CHECK_LIBM instead of AC_CHECK_LIB(m,...
and use $(LIBM) instead of hardcoding "-lm" in Makefiles.
2017-02-08 19:21:53 +01:00
Ondrej Holy
fc9b455bd6 user-accounts: Fix last login button sensitivity
The last login button should be insensitive for other accounts if the
panel is not unlocked.

https://bugzilla.gnome.org/show_bug.cgi?id=767065
2017-02-08 14:29:42 +01:00
Piotr Drąg
fdc9b35c6b Fix translator comments
They need to be exactly one line above a string to show up in .po files.
2017-01-27 23:02:44 +01:00
Felipe Borges
120956fad3 user-accounts: Use GtkRevealer instead of GdNotification
GtkRevealer combined with the "app-notification" class is enough
to represent the notification concept nowadays.

https://bugzilla.gnome.org/show_bug.cgi?id=775178
2016-11-30 13:06:28 +01:00
Felipe Borges
b995e16c98 user-accounts: Don't show_restart_notification when changing Language
Since commit 5e2ed8e, the user-accounts panel does not present an
option to change the Language for the current user. This should be
done in the "Region & Language" panel instead.

In doing so, the code for launching the restart notification is
never reached in the language_response callback method.

https://bugzilla.gnome.org/show_bug.cgi?id=767065
2016-11-29 15:19:52 +01:00
Bastien Nocera
a396e0578a user-accounts: Simplify the fingerprint manager fetching
Code styling fix.
2016-10-17 11:45:03 +02:00
Piotr Drąg
1e1509240e user-accounts: use Unicode in translatable strings
See https://developer.gnome.org/hig/stable/typography.html

https://bugzilla.gnome.org/show_bug.cgi?id=772199
2016-10-03 15:21:21 +02:00
Felipe Borges
4f48934b50 user-accounts: Revert "Fix history dialog height"
This reverts commit 77c26aa162.

Since the changes in GtkScrolledWindow on Bug 766569, this patch
is no longer necessary.

https://bugzilla.gnome.org/show_bug.cgi?id=767065
2016-09-06 16:56:33 +02:00
Ondrej Holy
77c26aa162 user-accounts: Fix history dialog height
History dialog changes its height depending on number of entries. It
is caused by the recent GtkScrolledWindow changes from Bug 766569. Set
fixed min and max content heights to avoid this behavioral.

https://bugzilla.gnome.org/show_bug.cgi?id=767065
2016-08-04 17:13:26 +02:00
Felipe Borges
5b101946b9 user-accounts: Drop CcEditableEntry references from um-user-panel
There is no need to use this type in the new user accounts panel.

https://bugzilla.gnome.org/show_bug.cgi?id=767065
2016-08-01 14:51:23 +02:00
Felipe Borges
5c12abbe2f user-accounts: Fix horizontal alignment of "Account Type" buttons
It makes "account-type-standard" and "account-type-admin" hexpand
properties to equal TRUE.

https://bugzilla.gnome.org/show_bug.cgi?id=767065
2016-08-01 14:48:41 +02:00
Felipe Borges
e3148af358 user-accounts: Use sensitivity to denote changes in "Account Type"
Instead of changing from "Account Type" buttons to label, set the
sensitivity of the buttons according to the current users' permission.

Now we hide the "Account Type" for a single user account.

https://bugzilla.gnome.org/show_bug.cgi?id=767065
2016-08-01 09:38:13 +02:00
Felipe Borges
e36a3654a0 user-accounts: Drop "Account Activity" button
Now the "Account Activity" dialog is launched by clicking in the
"Last Login" option.

https://bugzilla.gnome.org/show_bug.cgi?id=767065
2016-08-01 09:35:21 +02:00
Felipe Borges
1039642d93 user-accounts: Use GtkEntry instead of CcEditableEntry
https://bugzilla.gnome.org/show_bug.cgi?id=767065
2016-08-01 09:24:39 +02:00
Felipe Borges
a05375005b user-accounts: Remove UmEditableButton object
To bring it back, revert this commit.

https://bugzilla.gnome.org/show_bug.cgi?id=767065
2016-08-01 09:22:40 +02:00
Felipe Borges
e2d3b47a33 user-accounts: Drop usage of UmEditableButtons
Now using GtkButtons instead. Since we are denoting the permission
to edit an option by setting the option sensitivity.

https://bugzilla.gnome.org/show_bug.cgi?id=767065
2016-08-01 09:19:40 +02:00
Ondrej Holy
7e1d575798 user-accounts: Remove unused variable
https://bugzilla.gnome.org/show_bug.cgi?id=767065
2016-07-28 12:46:38 +02:00
Ondrej Holy
8e8d00541b user-accounts: Do not access already removed toolbar
Commit eb9c110 removed add-remove-toolbar, however, some leftovers are
in the code which causes the following errors:
Gtk-CRITICAL **: gtk_widget_get_style_context: assertion 'GTK_IS_WIDGET (widget)' failed
Gtk-CRITICAL **: gtk_style_context_set_junction_sides: assertion 'GTK_IS_STYLE_CONTEXT (context)' failed

https://bugzilla.gnome.org/show_bug.cgi?id=767065
2016-07-28 10:53:59 +02:00
Felipe Borges
eb9c110646 user-accounts: Move "Add User" button to header bar
This also introduces a change to the Lock/Unlock logic. From now
on, Unlocking the panel causes the "Lock" button to turn into the
"Add User" button.

https://bugzilla.gnome.org/show_bug.cgi?id=767065
2016-07-27 11:49:06 +02:00
Felipe Borges
e18c0014f1 user-accounts: Properly align option buttons
https://bugzilla.gnome.org/show_bug.cgi?id=767065
2016-07-27 11:37:47 +02:00
Felipe Borges
cbe31d5337 user-accounts: Reposition "Remove Account" button
It used to be at the toolbar in the bottom of the treeview. Now it
is fixed in the bottom-right corner of the panel.

https://bugzilla.gnome.org/show_bug.cgi?id=767065
2016-07-27 11:31:05 +02:00
Ondrej Holy
90d6f3b622 user-accounts: Unify size of headerbar buttons
The headerbar buttons with arrows were moved sidebyside by the commit
a70888f. The buttons have a slightly different size, which looks pretty
weird currently. Fix this by setting valign on GtkButton and not on
GtkImage inside.

https://bugzilla.gnome.org/show_bug.cgi?id=767065
2016-07-27 09:25:48 +02:00
Felipe Borges
1345cf36c5 user-accounts: Remove UmEditableCombo class
Revert this commit in order to bring the UmEditableCombo class back.

https://bugzilla.gnome.org/show_bug.cgi?id=767065
2016-07-25 15:22:35 +02:00
Felipe Borges
079928d693 user-accounts: Make the "Account Activity" dialog wider
Set it to 60% of the parent window.

https://bugzilla.gnome.org/show_bug.cgi?id=767065
2016-07-14 10:42:41 +02:00
Felipe Borges
094447fdd3 user-accounts: Drop overwritten title of "Account Activity" dialog
Since we are setting the "Account Activity" title by prepending
the user real name ("%s - Account Activity") in um-history-dialog.c,
there's no need to set the title property for the dialog elsewhere.

https://bugzilla.gnome.org/show_bug.cgi?id=767065
2016-07-14 10:41:45 +02:00
Felipe Borges
f029fc0947 user-accounts: Prepend user real name to "Account Activity" dialog title
https://bugzilla.gnome.org/show_bug.cgi?id=767065
2016-07-14 10:39:43 +02:00
Felipe Borges
f56c90b916 user-accounts: Drop unused subtitle in "Account Activity" dialog
https://bugzilla.gnome.org/show_bug.cgi?id=767065
2016-07-14 10:38:41 +02:00