Cheese has an internal copy of UmCropArea, and exports the corresponding
um_crop_area_get_type() as part of libcheese-gtk. This leads to a crash
when taking a photo in the avatar chooser, as the control center copy of
the get_type() function is used. Renaming the function in Cheese would
be an ABI break, so at this stage it is best to do the rename in the
control center instead.
https://bugzilla.gnome.org/show_bug.cgi?id=697039
This lines are dead code, because act_user_get_language() returns empty
string if language isn't set. We don't want to fix the condition, because
cc_common_language_get_current_language is wrong for other users.
https://bugzilla.gnome.org/show_bug.cgi?id=737216
If language is unknown and language chooser is cancelled, panel crash
with the following error:
(gnome-control-center:24952): Gtk-CRITICAL **: gtk_list_store_get_path:
assertion 'iter->stamp == priv->stamp' failed
(gnome-control-center:24952): Gtk-CRITICAL **: gtk_list_store_get_value:
assertion 'iter_is_valid (iter, list_store)' failed
(gnome-control-center:24952): GLib-GObject-WARNING **: gtype.c:4221:
type id '0' is invalid
(gnome-control-center:24952): GLib-GObject-WARNING **:
can't peek value table for type '<invalid>' which is not currently referenced
Segmentation fault (core dumped)
https://bugzilla.gnome.org/show_bug.cgi?id=738002
If the language chooser is confirmed and no language is selected,
"Other..." is shown as user's language and the following error is printed:
(gnome-control-center:14608): AccountsService-CRITICAL **:
act_user_set_language: assertion 'language != NULL' failed
Autologin widgets are different in height as compared with other widgets,
which looks odd. Put all the widgets in the sizegroups, to have same
height.
https://bugzilla.gnome.org/show_bug.cgi?id=737343
The notification is wider then window for some languages (e.g.
France). This patch allows wrapping, limits chars and changes
margin as a result of discussion on #gnome-design.
https://bugzilla.gnome.org/show_bug.cgi?id=703392
Making containers take focus is almost never right. In this
case, it disrupts the focus chain in the dialog, because the
focus gets stuck on the stack.
https://bugzilla.gnome.org/show_bug.cgi?id=736223
Preview has to be generated after default handler of "selection-changed"
signal, otherwise dialog response sensitivity is rewritten (Bug 547988).
Preview also has to be generated on "selection-changed" signal to reflect
all changes (Bug 660877).
https://bugzilla.gnome.org/show_bug.cgi?id=721683
The mechanism of setting label padding had to be changed consequently.
It fixes following warnings:
(gnome-control-center:32638): Gtk-WARNING **: GtkComboBox 0x28bcef0 is mapped but not child_visible
(gnome-control-center:32638): Gtk-WARNING **: GtkComboBoy 0x28bcef0 is mapped but visible=1 child_visible=0 parent GtkNotebook 0x2b86600 mapped=1
The ugly hack to catch when combo is losing focus had to be also removed
and notify::popup-shown is used instead. It fixes when GtkComboBox is wrongly
shown instead of GtkButton due to escape is pressed or active item is selected.
https://bugzilla.gnome.org/show_bug.cgi?id=694325
Before, we were freeing the DateTime instances when closing the dialog
through the close button and always creating new ones on _show().
Now, with the header bar, we go through the delete-event handler which
just hides the dialog, meaning that we leak the dates instanced on
_show().
Clearing the dates on _show() is more robust anyway. Note that we'd
leak even before switching to a header bar when going through the
delete-event handler.
https://bugzilla.gnome.org/show_bug.cgi?id=729181
The period is appended at the end of sentences after there are
translated. However some languages might not use periods at the
end of sentences. This patch changes the texts directly.
When deleting a user account, we try to check if the user is
still logged in, but we are using an accountsservice API that
ignores console logins. But deleting a user that is logged
in on the console is just as bad, so use
act_user_is_logged_in_anywhere instead, which includes console
logins.
https://bugzilla.gnome.org/show_bug.cgi?id=721951
