Changing user’s language resets the formats (region) by passing `NULL` to `update_region`.
However, updating the region calls `maybe_notify`, whose callback `maybe_notify_finish`
tries to parse the `mnd->target_locale` (the `NULL`), producing a critical:
GLib-CRITICAL **: g_regex_match_full: assertion 'string != NULL' failed
Since updating the language itself already triggers the notification check,
let’s just skip calling `maybe_notify` here in that case.
On the Verify Encryption dialog we were adding a GtkWindowControls
widget with a button child. This is a misunderstanding of the behavior
of GtkWindowControls, which adds its own buttons to the window.
Let's remove our custom close-button and its callback, since the
previous commit disabled this codepath for hiding the dialog.
Currently, we display a 256x256 version of the OS icon from
/etc/os-release. This is too big for my taste, and it's also not
sufficient for distros that want to display a logo that is not an icon.
For instance, because we no longer display the operating system name
immediately beneath the logo, it may be desirable to use a logo variant
that includes text. This patch adds a meson build option that
distributions can use to override the logo, and a second build option to
specify a different logo for use in dark mode.
Otherwise glib will make internal calls before setlocale is called:
** (process:1124144): WARNING **: 10:16:58.983: dcgettext("(null)", "", 5) called before setlocale()
#0 0x00007ffff7c80f77 in g_logv () at /lib64/libglib-2.0.so.0
#1 0x00007ffff7c81233 in g_log () at /lib64/libglib-2.0.so.0
#2 0x00007ffff7fbb6c6 in dcgettext (__domainname=<optimized out>, __msgid=0x7ffff7ce6c5a "", __category=<optimized out>) at ../../../../Projects/jhbuild/gettext-pseudolocale/gettext-pseudolocale.c:194
#3 0x00007ffff7c6478e in _g_dgettext_should_translate () at /lib64/libglib-2.0.so.0
#4 0x00007ffff7c6484b in g_dgettext () at /lib64/libglib-2.0.so.0
#5 0x00007ffff7e98974 in g_application_class_intern_init () at /lib64/libgio-2.0.so.0
#6 0x00007ffff7d9cfb8 in g_type_class_ref () at /lib64/libgobject-2.0.so.0
#7 0x00007ffff7d9cc95 in g_type_class_ref () at /lib64/libgobject-2.0.so.0
#8 0x00007ffff7d9cc95 in g_type_class_ref () at /lib64/libgobject-2.0.so.0
#9 0x00007ffff7d9cc95 in g_type_class_ref () at /lib64/libgobject-2.0.so.0
#10 0x00007ffff7d8671a in g_object_new_valist () at /lib64/libgobject-2.0.so.0
#11 0x00007ffff7d867fd in g_object_new () at /lib64/libgobject-2.0.so.0
#12 0x0000000000449bcc in cc_application_new () at ../../../../Projects/jhbuild/gnome-control-center/shell/cc-application.c:294
#13 0x0000000000448fa6 in main (argc=1, argv=0x7fffffffd138) at ../../../../Projects/jhbuild/gnome-control-center/shell/main.c:55
