Commit graph

18140 commits

Author SHA1 Message Date
Marek Černocký
89b3eb36fd Fixed Czech translation typo 2018-11-17 21:23:51 +01:00
Georges Basile Stavracas Neto
aeb060c8ad
panel-list: Instrument more functions
These were useful tracing messages to figure out some bugs
with the sidebar widget implementation.
2018-11-16 19:25:13 -02:00
Georges Basile Stavracas Neto
896ff73c2b
tests: Add test panels for sidebar widget
Two tests for sidebar widget were added: one at the main
sidebar view, the other inside the Details category.
2018-11-16 19:25:13 -02:00
Georges Basile Stavracas Neto
fdf22ad255
tests: Properly generate desktop files 2018-11-16 19:25:13 -02:00
Georges Basile Stavracas Neto
8d2265c6b9
window: Properly update headebar buttons and title
With the new sidebar view in place, a new problem arose: we
need the current panel to be configured to update the title,
but cc_panel_list_add_sidebar_widget() changes the view while
activating the panel. That makes Settings crash.

Fix that by explicitly updating the headerbar widget, instead
of using notify::view of the panel list.
2018-11-16 19:25:13 -02:00
Georges Basile Stavracas Neto
8c144b6261
window: Instrument some functions 2018-11-16 19:24:49 -02:00
Georges Basile Stavracas Neto
2c18053ddd
window: Set the panel name as title for the widget
Instead of the wrong name of the previous panel list view.
2018-11-16 19:24:49 -02:00
Georges Basile Stavracas Neto
6295831fff
window: Add panel's sidebar widget to sidebar
When opening a panel, add its sidebar widget to the sidebar.
2018-11-16 19:24:49 -02:00
Georges Basile Stavracas Neto
de15083e7a
panel-list: Rename internal function
It was referring to listbox, where in the future
it is going to refer to any kind of widget.
2018-11-16 15:19:09 -02:00
Georges Basile Stavracas Neto
b02bc2a935
panel-list: Replace set_view() by go_previous()
Instead of directly selecting the view that the panel
list will have, let it decide which is the previous
view instead.

This does not change anything functionality wise, but
in the future where we have sidebar widget (and thus
the main window does not control which view the sidebar
is display) this will be important.
2018-11-16 15:19:09 -02:00
Georges Basile Stavracas Neto
6541c128df
trivial: Update code style 2018-11-16 15:19:08 -02:00
Georges Basile Stavracas Neto
75167f45fd
panel: Add get_sidebar_widget() vfunc
This vfunc is the entry point for panels that have
a sidebar widget. It must never return NULL.

At this point, nothing uses it and this vfunc does
not impact execution of the program.
2018-11-16 15:19:08 -02:00
Georges Basile Stavracas Neto
3e9425aee3
panel: Remove size negotiation machinery overrides
These overrides were added eight years ago, as a port from
GTK3's size_request() deprecation, in commit f5f5aac5c0.

These overrides are not necessary these days, since they
just reproduce the default behavior now.

Remove these overrides then.
2018-11-16 15:18:59 -02:00
Georges Basile Stavracas Neto
62743ab47e
window: Factor out function to find panel iter
It will be used by the next commits to look for the panel
name. That is because the panel name is what will be used
as the first headerbar title of panels with a sidebar widget.
2018-11-16 15:18:59 -02:00
Georges Basile Stavracas Neto
7e2865131b
panel: Remove unused macro 2018-11-16 15:18:59 -02:00
Georges Basile Stavracas Neto
93209fafab
panel: Remove useless get_type() function
It is already declared by G_DECLARE_DERIVABLE_TYPE().
2018-11-16 15:18:59 -02:00
João Paulo Rechi Vita
6efaf85e9a power: Label the PENDING_CHARGING state as "Not Charging"
The pending-charge state means AC power is on but the battery is not
being charged. This can happen because its charge is above a certain
threshold, to avoid short charging cycles and prolong the battery's
life, or because the PSU is not powerful enough to charge the batteries.

Instead of lying to the user about something being estimated, we should
simply tell the truth and set the label to "Not Charging".

Closes: #249.
2018-11-14 13:53:40 -08:00
Robert Ancell
41e3426873 network: Fix warning about freeing const string
The use of g_clear_pointer (&str, g_free) with str being a const gchar *
caused warning errors.

Instead of using str for both constant and allocated strings use separate
variables. Autofree the allocated strings.
2018-11-14 10:40:10 +00:00
Robert Ancell
631e83ec0e bluetooth: Use g_auto for variables 2018-11-14 10:11:44 +00:00
Robert Ancell
14f20f3784 bluetooth: Move class_init to end of file
As specified in docs/HACKING.md and removes the need for function prototypes.
2018-11-14 10:11:44 +00:00
Robert Ancell
5c821bad71 bluetooth: Connect signals in swapped form 2018-11-14 10:11:44 +00:00
Robert Ancell
5ff8a88747 bluetooth: Fix indentation error 2018-11-14 10:11:44 +00:00
Robert Ancell
325c3c9446 bluetooth: Align struct members 2018-11-14 10:11:44 +00:00
Robert Ancell
4f97e8cb07 bluetooth: Use widget data types
Replace GtkWidget with the widget data types.
2018-11-14 10:11:44 +00:00
Robert Ancell
281827f70f bluetooth: Rename generic variable name
Rename from 'widget' to 'settings_widget'
2018-11-14 10:11:43 +00:00
Robert Ancell
5b55519db2 bluetooth: Replace GtkStack page names with widgets
This is less likely to be accidentally broken in the future
2018-11-14 10:11:43 +00:00
Robert Ancell
e5ee278393 bluetooth: Make .ui filename match the .c filename 2018-11-14 10:11:43 +00:00
Robert Ancell
f1307baf4e user-accounts: Replace lone tab character with spaces 2018-11-14 10:11:02 +13:00
Robert Ancell
b40b0a4d05 user-accounts: Rename um-utils.[ch] to user-utils.[ch]
Um is a naming hangover from before this was part of g-c-c.
2018-11-14 10:10:15 +13:00
Robert Ancell
c092f8b89e user-accounts: Fix alignment of function parameters 2018-11-14 10:10:15 +13:00
Robert Ancell
a41780267b user-accounts: Move non-shared function
The generate_username_choices function is only used in CcAddUserDialog
2018-11-14 10:10:15 +13:00
Robert Ancell
ffa54acdb9 user-accounts: Move non-shared function
The set_user_icon_data function is only use in CcAvatarChooser
2018-11-14 10:10:15 +13:00
Robert Ancell
60ffc24c30 user-accounts: Move non-shared function
The render_user_icon function is only used in CcUserImage
2018-11-14 10:10:15 +13:00
Robert Ancell
288ef61515 user-accounts: Move non-shared function
The would_demote_only_admin function is only used in CcUserPanel
2018-11-14 10:10:15 +13:00
Robert Ancell
4e31c3face user-accounts: Remove unused popup_menu_below_button function 2018-11-14 10:10:15 +13:00
Robert Ancell
96b6ae98d0 user-accounts: Remove unused icon style code 2018-11-14 10:10:15 +13:00
Robert Ancell
feaa29bfc0 user-accounts: Rename UmRealmManager to CcRealmManager
Um is a naming hangover from before this was part of g-c-c.
2018-11-14 10:10:14 +13:00
Robert Ancell
eb7bbae2cd user-accounts: Rename UmPhotoDialog to CcAvatarChooser
Um is a naming hangover from before this was part of g-c-c.
2018-11-14 10:06:15 +13:00
Robert Ancell
262baed6a1 user-accounts: Rename UmCarousel to CcCarousel
Um is a naming hangover from before this was part of g-c-c.
2018-11-14 10:06:15 +13:00
Robert Ancell
4767a094bd user-accounts: Rename UmUserImage to CcUserImage
Um is a naming hangover from before this was part of g-c-c.
2018-11-14 10:06:15 +13:00
Georges Basile Stavracas Neto
fb45df29a3
3.31.2 2018-11-12 23:43:14 -02:00
Benjamin Berg
1ab42b4ec5 tests: Ensure generated function have a __qualname__ attribute
This is solely used for filtering by unittest, however, if it is
missing, then unittest will fail. So generate a reasonable name (which
is unfortunately not identical to the real name of the attribute).
2018-11-13 02:32:28 +01:00
Robert Ancell
f649308f1f common: Fix ... row not showing in language chooser
Broken in 67a9f47464
2018-11-12 20:33:05 +00:00
Robert Ancell
9d091692f8 region: Fix ... row not showing
Broken in 5368c1cb71
2018-11-12 20:33:05 +00:00
Robert Ancell
c4a6f7bd54 search: Make .ui filename match the .c filename 2018-11-12 16:41:01 +00:00
Robert Ancell
e77080c83c info: Make .ui filenames match the .c filenames 2018-11-12 16:41:01 +00:00
Robert Ancell
e6bf2870c1 power: Make .ui filename match the .c filename 2018-11-12 16:41:01 +00:00
Robert Ancell
3695c22ab5 datetime: Make .ui filename match the .c filename 2018-11-12 16:41:01 +00:00
Robert Ancell
59cc518c3e universal-access: Make .ui filename match the .c filename 2018-11-12 16:41:01 +00:00
Robert Ancell
41d2eff314 sharing: Make .ui filename match the .c filename 2018-11-12 16:41:01 +00:00