We were assuming that setting stock-size would affect the emblems in
GEmblemedIcons, but not the icons themselves. This is a bit weird.
GtkCellRendererPixbuf:gicon is meant to work with
GtkCellRendererPixbuf:stock-size, and this was only working so far
because GTK_ICON_LOOKUP_FORCE_SIZE was not being used when loading
the icon.
Let's composite the emblems ourselves so that we don't have to depend
on this quirky interpretation of stock-size.
Unfortunately, we can not directly use the pixbufs because they are
unaware of the scale factor and GTK+ will scale them on HiDpi
displays. Since our pixbufs already have enough pixels to work well
with such devices, scaling them further will lead to giant, fuzzy
thumbnails. Hence, we use GtkCellRendererPixbuf:surface with the
scale factor codified in it.
https://bugzilla.gnome.org/show_bug.cgi?id=732375
This is deprecated in newer automake versions, and this causes warnings
with automake 1.14:
panels/printers/Makefile.am:3: warning: 'INCLUDES' is the old name for
AM_CPPFLAGS' (or '*_CPPFLAGS')
https://bugzilla.gnome.org/show_bug.cgi?id=732189
... so that it is possible to override virtual functions and change
the order of the object creation and destruction process without having
to write a bunch of prototypes. Having the class_init below the others
helps us do that.
https://bugzilla.gnome.org/show_bug.cgi?id=731713
When using a small screen, make sure that the whole of the dialogue
is visible, including the confirmation buttons. This means that the
dialogue will be maximised when on smaller screens (just like its
parent), and that we won't set a number of columns for the icon
view.
We will also stop making the dialogue much bigger than the
Settings window itself.
https://bugzilla.gnome.org/show_bug.cgi?id=692495
A completely black background will make it impossible to see
whether there is one more workspace in gnome-shell, and as we
do not want to design gnome-shell around the possibility of
a solid black coloured background, remove black from the options.
https://bugzilla.gnome.org/show_bug.cgi?id=649426
There is no need to pass the source-uri as a parameter as we can get it
from the file itself. This would help in using the same code paths for
local and remote pictures.
https://bugzilla.gnome.org/show_bug.cgi?id=707569
We do not wait until the first thumbnail is created to start filling up
the store. This avoids the "No Pictures Found" message from showing up
on slow machines were I/O and decoding the data may take a while.
However, placeholders are not shown for PNGs since they might be
screenshots.
https://bugzilla.gnome.org/show_bug.cgi?id=708943
This removes an extra g_object_ref when inserting items to GtkListStore:
the list store takes care of incrementing the reference count itself and
the caller doesn't need to do it.
https://bugzilla.gnome.org/show_bug.cgi?id=709453
Commit b9e3603ba4 added an unref to fix a
memory leak, but it went to a wrong place -- in XML loader, all items
are stored in a hash table that takes ownership of them, and destroyed
when the hash table goes away.
This commit fixes the reference counting in the XML loader and adds
explicit g_object_ref / g_strdup when inserting values to the hash table
to make the memory management more obvious.
The following commit fixes the real leak.
https://bugzilla.gnome.org/show_bug.cgi?id=709453
Instead of setting the size on each child, set it on the parent grid
because only one of those children are visible at any given point.
We are cheating a bit by ignoring the fact there is a second child
which is always shown -- the button box. This will make the other
children lose some height and the dialog will be smaller. However it is
still too big for smaller screens.
https://bugzilla.gnome.org/show_bug.cgi?id=708943
We want to track the busy state of the source. To do that we will keep
a count of the number of pending operations. Not having a check for
NOT_FOUND makes it slightly easier to do that. Not a big deal, but I
think it outweighs the downfall of showing an extra warning.
Plus we are trying to create the directories before using them, so the
warning means something fishy has been going on with your system.
https://bugzilla.gnome.org/show_bug.cgi?id=708943
