Commit graph

308 commits

Author SHA1 Message Date
Bastien Nocera
1445700c62 background: Align items in debug output 2013-10-02 19:30:14 +02:00
Bastien Nocera
42ddaffc9a background: Dump the selected item in the test program 2013-10-02 19:30:09 +02:00
Bastien Nocera
5d16f81821 background: Fix a memory leak when monitoring directories
Destroy directory monitors on when the XML object is destroyed.

https://bugzilla.gnome.org/show_bug.cgi?id=709243
2013-10-02 19:27:10 +02:00
Bastien Nocera
ca77b20062 background: Fix double-free when closing the dialog
9955f17d introduced a double-free.
2013-10-02 19:26:09 +02:00
Bastien Nocera
b9e3603ba4 background: Fix memory leak in XML signal handling
When emitted in an idle, the item was correctly unref'ed, but not
when emitting the signal straight away.

https://bugzilla.gnome.org/show_bug.cgi?id=709243
2013-10-02 19:03:02 +02:00
Bastien Nocera
a0ab6d527f background: Fix memory leaks in slideshow handling
A string was leaked when loading the name of the slideshow,
and a file object was left lingering as well.

https://bugzilla.gnome.org/show_bug.cgi?id=709243
2013-10-02 18:21:18 +02:00
Bastien Nocera
9955f17dd4 background: Fix memory leak in background item object
Some fields were never freed.

https://bugzilla.gnome.org/show_bug.cgi?id=709243
2013-10-02 18:21:18 +02:00
Bastien Nocera
ed589cd5b8 background: Fix memory leak in Pictures source
The enumerator was never unref'ed.

https://bugzilla.gnome.org/show_bug.cgi?id=709243
2013-10-02 18:21:18 +02:00
Bastien Nocera
d331444591 background: Add test program for the selection dialog
https://bugzilla.gnome.org/show_bug.cgi?id=709243
2013-10-02 18:21:18 +02:00
Bastien Nocera
c2413a3c3e background: Fix leak of the Flickr source
The Flickr source was never disposed of when destroying the
selection dialog.

https://bugzilla.gnome.org/show_bug.cgi?id=709243
2013-10-02 18:21:18 +02:00
Bastien Nocera
e7433f1629 background: Fix leak of the preview picture
https://bugzilla.gnome.org/show_bug.cgi?id=709243
2013-10-02 18:21:18 +02:00
Bastien Nocera
3942035180 background: Fix memory leak in the picture sources
The list store was taking a reference to the background item,
so we need to unref it on our side to avoid leaking it.

https://bugzilla.gnome.org/show_bug.cgi?id=709243
2013-10-02 18:21:18 +02:00
Debarshi Ray
675bf324f8 background: Remove undefined method declaration 2013-09-30 18:59:37 +02:00
Jasper St. Pierre
a8b83d706b background: Fix crasher when entering/leaving the background panel
g_application_get_dbus_connection() does not return a ref, so we
shouldn't try to free it.
2013-09-12 15:53:41 -04:00
Bastien Nocera
015d29604a background: Fix debug message
We're never capturing the whole screen, only a single monitor.

https://bugzilla.gnome.org/show_bug.cgi?id=706578
2013-09-10 16:15:34 +02:00
Bastien Nocera
fd4cf7b881 background: Fix top bar location on dual-head
For testing:
xrandr --addmode VGA1 1024x768
xrandr --output VGA1 --mode 1024x768 --left-of eDP1

https://bugzilla.gnome.org/show_bug.cgi?id=706578
2013-09-10 16:15:31 +02:00
Bastien Nocera
a2872ff123 background: Remove empty finalize functions
They were just chaining up.

https://bugzilla.gnome.org/show_bug.cgi?id=707602
2013-09-09 16:24:56 +02:00
Bastien Nocera
00d8f80586 background: Use g_clear_* helpers when possible
https://bugzilla.gnome.org/show_bug.cgi?id=707602
2013-09-09 16:24:37 +02:00
Debarshi Ray
cc17b9d471 background: Don't access possibly invalid object
The previous value of CURRENT_BG may not be valid after a call to
update_preview.

https://bugzilla.gnome.org/show_bug.cgi?id=707569
2013-09-09 15:12:55 +02:00
Bastien Nocera
074f55e344 background: Add support for lock screen background
https://bugzilla.gnome.org/show_bug.cgi?id=696166
2013-08-20 00:35:30 +02:00
Bastien Nocera
ea16cadce9 background: Remove unused "lock" preview widgets
https://bugzilla.gnome.org/show_bug.cgi?id=696166
2013-08-20 00:35:30 +02:00
Bastien Nocera
1097d4ca75 background: Fix memory corruption when creating preview
When using a single screen, the captured area was too small, and
we were copying data from out-of-bounds of the pixbuf area.

https://bugzilla.gnome.org/show_bug.cgi?id=696166
2013-08-20 00:35:30 +02:00
Yosef Or Boczko
27e12bb7b0 background: drop GtkStock
https://bugzilla.gnome.org/show_bug.cgi?id=704178
2013-07-19 15:55:48 +03:00
Joshua Lock
60260e7b65 background: show explanation of why pictures source might be empty
Show a message to the user when the Pictures source is empty, inspired both
in design and widget layout by the EmptyResultsBox from gnome-documents.

https://bugzilla.gnome.org/show_bug.cgi?id=630892
2013-06-04 14:09:36 +01:00
Joshua Lock
9bad43e484 background: ensure background chooser is closed if panel changed
If the background chooser is open and the user triggers a switch to a
different panel (i.e. from one of the gnome-shell indicators) the chooser
is still the topmost window and modal for g-c-c, however if the chooser is
interacted with in any way other than clicking the cancel button g-c-c
crashes.

Ensure that the chooser is destroyed if the panel is changed.

https://bugzilla.gnome.org/show_bug.cgi?id=700860
2013-06-04 11:53:26 +01:00
Kalev Lember
35af441e31 background: Add missing semicolons to desktop files
https://bugzilla.gnome.org/show_bug.cgi?id=696806
2013-04-16 11:15:12 +02:00
Bastien Nocera
f9c0732a6c background: Fix handling of cancellation in async calls
A few of the async calls were still handling the user_data before
checking that it was still valid (eg. the operation was not cancelled),
and also printing warnings when the error was a cancellation.
2013-03-26 15:43:39 +01:00
Michael Wood
ce409d4542 background: Monitor the Pictures and cache directory for new files
Monitor the pictures directory and cache directory for any new files
added or removed. Re-purposes the add/remove api that was no longer used.

https://bugzilla.gnome.org/show_bug.cgi?id=693329
2013-03-01 11:13:19 +00:00
Michael Wood
09baf812ea background: Offload the sorting of the initial list of files
Sorting after the image scale for each image causes the list to change
as you're viewing it depending on the size of the image.
This can be quite jarring visually.

https://bugzilla.gnome.org/show_bug.cgi?id=691800
2013-03-01 11:13:00 +00:00
Allan Day
c2ca6faa8f background: Update panel comments
Very few of the panel comments provide information that is very
useful. Update them to supplement the panel descriptions - this
will make the search results more helpful.

https://bugzilla.gnome.org/show_bug.cgi?id=694110
2013-02-19 10:41:43 +01:00
Bastien Nocera
3840ef6539 background: Fix compile-time warning with format 2013-01-31 17:02:11 +01:00
Michael Wood
c3446cccdc background: Sort Pictures in order of most recently modified
In the picture browser you see the most recently modified pictures
first.

https://bugzilla.gnome.org/show_bug.cgi?id=691800
2013-01-31 11:46:07 +01:00
Bastien Nocera
f959d3072b background: Avoid accessing the panel if cancelled
If the background panel was closed, we shouldn't try to access
panel's internals as it's already been freed.

https://bugzilla.redhat.com/show_bug.cgi?id=880859
2013-01-30 19:18:07 +01:00
Bastien Nocera
681aed6f9c background: Fix error checking in on_screenshot_finished()
This could create crashers when no errors were detected, but
either the D-Bus call or loading the pixbuf return NULL.

Conflicts:
	panels/background/cc-background-panel.c
2013-01-30 19:18:07 +01:00
Bastien Nocera
8d99d1c7c5 background: Update for gnome-shell Screenshot API changes
https://bugzilla.gnome.org/show_bug.cgi?id=692849
2013-01-30 18:05:40 +01:00
Bastien Nocera
39d7842ebe background: Don't access the panel object in _finish()
We shouldn't access the panel object as we don't know whether
the memory is still valid or the panel has gone away and was
freed.
2013-01-15 08:27:11 +01:00
Cosimo Cecchi
8d5f2908b5 panels: add --sourcedir=$(srcdir) when generating resource list
Like b8e93fb333 but for all panels.
2013-01-07 16:23:57 -05:00
Cosimo Cecchi
e30613e355 background: use a GResource for GtkBuilder UI definition
https://bugzilla.gnome.org/show_bug.cgi?id=691132
2013-01-07 10:57:05 +01:00
Matthias Clasen
3d27d8caaf shell: Fittsify panels
Make it possible for panels to go all the way to the edge of the
shell. This is particularly important for panels that scroll, such
as the new power panel. All other panels are changed to compensate
for the loss of external padding.

https://bugzilla.gnome.org/show_bug.cgi?id=691229
2013-01-07 10:51:29 +01:00
Bastien Nocera
e419ee7d4e panels: Remove unused X-GNOME-Settings-Panel key 2012-12-11 17:09:04 +01:00
Bastien Nocera
3686cf7eb8 shell: Make all control-center plugins static
This makes loading faster, with less I/O, avoids unnecessary
code duplication (around 1k lines shaved), and ensures that
all the panels link and work appropriately.

By the same token, it will stop external panels from being
created, and loaded.

https://bugzilla.gnome.org/show_bug.cgi?id=690036
2012-12-11 17:07:39 +01:00
Bastien Nocera
a4cf283937 background: Fix not having 3 columns in high contrast
Increase the width slightly to 860 from 850.

https://bugzilla.gnome.org/show_bug.cgi?id=683499
2012-11-14 23:07:16 +01:00
Michael Meeks
527945b29e re-license GPLv2-only code to GPLv2+ permission from SUSE/RH legal
cf. https://bugzilla.gnome.org/show_bug.cgi?id=681834
2012-11-12 15:57:09 +00:00
Jeremy Bicha
e32494f2f0 Show Printers & Region panels in Unity but hide Background
Ubuntu plans to fork a separate Appearance panel this cycle so
that Gnomebuntu can use the GNOME Background panel.

I believe Ubuntu will try to use the Printers and Region & Language
panels instead of system-config-printer & language-selector

https://bugzilla.gnome.org/show_bug.cgi?id=687258
2012-10-31 06:50:05 -04:00
Bastien Nocera
0d9fd1005f background: Fix crash when exiting panel too quickly
The background capture would still be on-going, and we would
crash poking at the now gone panel.

https://bugzilla.redhat.com/show_bug.cgi?id=866973
2012-10-17 09:40:24 +02:00
Bastien Nocera
e06657e7da background: Handle copy cancellation correctly
Make sure to avoid poking at the panel when the file copy
is cancelled.
2012-10-17 09:40:23 +02:00
Bastien Nocera
0e037561c3 background: Optimise preview for the usual shell layout
The area of screen to capture would be a ribbon at the top, so just
capture that instead of the whole screen, just to clear it afterwards.

https://bugzilla.gnome.org/show_bug.cgi?id=684993
2012-10-10 18:56:58 +02:00
Bastien Nocera
aef03317e8 background: Fix distcheck 2012-10-08 18:31:05 +02:00
Bastien Nocera
5b6385067d background: Fix clearing too much from the background 2012-09-30 05:43:06 +02:00
Jakub Steiner
f49261bb8d background: use a lighter texture for solid colors.
https://bugzilla.gnome.org/show_bug.cgi?id=682612
2012-09-28 01:51:22 +02:00