It's better for human-readable display than nm_device_get_product().
Unlike nm_device_get_product(), it never returns an empty string and
sanitizes the string.
With NM 1.12 it goes to great lengths to clean up the messy udev
strings.
It is important that potential contributors know who
they should get in touch, who is supposed to review
their work, and maintainers to know how they should
introduce changes.
Thus, this commit documents the current maintainers
together with what they maintain, and the workflow
between maintainers as well.
[skip ci]
The current widget has a very generic name "EditDialog" - rename it to something
that reflects better what it is for.
Implement it is as a full GtkWidget using GtkTemplate.
Move some of the logic from inside the dialog to the code that creates the dialog
so less data is passed around.
Store properties using functions instead of g_object_set_data - that passes
everything as a gpointer which is easy to make a mistake with.
The Password dialog uses "Verify New Password" and Add User dialog
"Confirm". Let's use "Confirm New Password" as it is on mockups to
be consistent in terminology.
The logic for the password mismatch warnings didn't handle the case where
you deleted both the passwords - it would still show them as not
matching.
Fix this by handling the three cases:
- Passwords are different
- Passwords are the same
- No passwords entered
If <tab> is pressed and password is not yet validated (ie. the verify
entry is not sensitive), focus skips the verify entry, even if the
password is strong enough. Let's validate the password when <tab> is
pressed (ie. before focus change) to prevent this <tab> breakage...
https://gitlab.gnome.org/GNOME/gnome-control-center/issues/38
MemorySanitizer (MSan) is a detector of uninitialized memory reads in C/C++ programs.
Uninitialized values occur when stack- or heap-allocated memory is read before
it is written.
ThreadSanitizer is a tool that detects data races.
UndefinedBehaviorSanitizer (UBSan) is a fast undefined behavior detector. UBSan
catches various kinds of undefined behavior, for example:
- Using misaligned or null pointer
- Signed integer overflow
- Conversion to, from, or between floating-point types which would overflow the
destination
The llvm.org states that Sanitizers have found thousands of bugs everywhere.
Sanitizers running during CI can prevent bugs from taking up residence. They
are helper tools to maintain bugs out.
Enable support for manipulating GNOME Remote Desktop settings. Settings
are done via the org.gnome.desktop.remote-desktop.vnc schema.
Configuring the VNC password is done via libsecret, thus libsecret is
added as a dependency.
• Use g_unix_is_system_fs_type() if a new enough GLib is available,
rather than maintaining our own list of system file system types.
• List network file systems separately, since GLib doesn’t ignore them.
• Ignore some file systems by label too.
See
https://gitlab.gnome.org/GNOME/gnome-settings-daemon/merge_requests/24.
Signed-off-by: Philip Withnall <withnall@endlessm.com>
AddressSanitizer (or ASan) is a programming tool that detects memory
corruption bugs such as buffer overflows or use after free. AddressSanitizer
is based on compiler instrumentation.
The llvm.org states that Sanitizers have found thousands of bugs everywhere.
Sanitizers running during CI can prevent bugs from taking up residence. They
are helper tools to maintain bugs out.
The test job was recompiling the software (unexpected behavior).
This was happening because the git checkout runs after the artifacts
download (resulting in the source code being newer than the object
files).
This commits saves and reuses the working directory produced by the
build job.
