When creating a Page, the dialog variable wasn't set and thus
dereferencing a NULL in a later code resulting a crash.
This was introduced in 14b9f65ba4
The other checkboxes on this page all have mnemonics. It seems unfair
for the background data usage one to be left out of the party.
Signed-off-by: Philip Withnall <withnall@endlessm.com>
The Add Connection widgets from the connection
editor dialog weren't properly using the available
space, since they don't expand.
Fix that by making them expand and fill the available
space properly. It also avoids blank space by vertically
centering the list.
The colour icon blends with bright themes (such as Adwaita) making
it hard to distinguish.
The symbolic variant of the same asset contrasts fine with light
and dark background and matches the "symbolic" pattern of the other
two buttons shown in the dialog (the audio-volume-* icons).
Fixes#502
At the default window size, the printer name label is too wide and
collapses the UI into phone mode. (This is the only panel that shows up
in phone mode by default.) Giving the printer name fewer characters
avoids this.
In CUPS 1.7 httpConnect() and httpConnectEncrypt() were deprecated and
replaced with httpConnect2(). This checks if httpConnect2() is available
and if so, replaces the uses of the deprecated functions.
In the CUPS source code, httpConnect() and httpConnectEncrypt() are now
wrappers around httpConnect2(), so we make sure to use the same
arguments as in the CUPS source code so the two code paths are sure to
be identical:
2c030c7a06/cups/http.c (L412)2c030c7a06/cups/http.c (L477)
In https://bugzilla.gnome.org/show_bug.cgi?id=696766 it was decided to
build with _PPD_DEPRECATED defined, to suppress the warnings about the
deprecation of the CUPS PPD API, since there was no full replacement
yet. Unfortunately this didn't make it intact through the port to Meson,
so fix it here.
The previous code would have leaked all the UpDevice objects because no
free function was set on the returned GPtrArray.
Since we already depend on upower-glib 0.99.8 which is the release in
which get_devices() was deprecated and get_devices2() was introduced, we
can simply switch to get_devices2() which does set a free function on
the returned GPtrArray, stopping the leak.
The part where this (currently disabled) test is added, is currently
hidden behind #if 0, so hide the test function as well. Otherwise the
compiler complains that the function isn't used.
When adding a Shared Folder row to the listbox, we were not settings
it to visible. Causing it to be hidden until the next time the panel
gets populated.
Fixes#580
When the user disables the use of location services in the privacy
panel, then the timezone will never be updated automatically. Automatic
timezone may still be enabled though, so we need to allow the user to
change the timezone when location services are disabled or when
automatic timezone updating is disabled.
On FreeBSD, the default full name of a user is 'User &'. The '&'
character included in the name is expected to be replaced with the login
name when it is displayed on the user interface. However, it seems that
AccountsService doesn't know it. It just returns 'User &' to the caller,
and it causes the markup to be broken in the user panel.
Mutter supports the 'Above_Tab' fake keysym that refers to the key
that is physically located above the tab key. It is used in the default
shortcut of the "Switch windows of an application" action.
As gtk_accelerator_parse() doesn't recognize the keysym, we display
the shortcut incorrectly as "disabled", and it is not taken into account
for conflict resolution.
Address this by translating binding that contains the 'Above_Tab' string
to bindings where the string is replaced with each possible keysym that
corresponds to the fixed keycode of KEY_GRAVE + 8.
https://gitlab.gnome.org/GNOME/gnome-control-center/issues/581
