applications/gnome-control-center
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
gnome-control-center/panels/network/connection-editor
History
Michael Catanzaro 3f6737dbf7 network: fix criticals when updating connection 
If the operation is cancelled (because the dialog was closed, because
the Apply button was pressed), then trying to make further use of the
source_object is a use after free, which is bad. At first I tried to fix
this by simply avoiding the use after free when the operation is
canceled, but then I realized it is ridiculous to always try committing
connection changes when closing the dialog, then immediately cancel the
operation by destroying the dialog.

So instead I've decided to not pass the cancellable along to these
operations, and instead ref the dialog to keep it alive until the
operations complete. Instead, let's just hide the window.

This commit also removes an inaccurate comment /* Leave the editor open
*/ placed right before the call to the function that hides the editor.
There's no need to leave the editor open when updating the device fails.
The connection properties at least are still saved.

Fixes #2618
2023-08-30 08:44:55 +00:00
..
8021x-security-page.ui network: Port to GTK4 2021-12-14 22:34:21 -03:00
ce-ip-address-entry.c Drop most uses of deprecated gtk_style_context_add/remove_class 2023-01-05 18:55:51 +00:00
ce-ip-address-entry.h network: Make CEIPAddressEntry 2020-12-11 19:06:48 +00:00
ce-netmask-entry.c Drop most uses of deprecated gtk_style_context_add/remove_class 2023-01-05 18:55:51 +00:00
ce-netmask-entry.h network: Make CENetmaskEntry 2020-12-11 19:06:48 +00:00
ce-page-8021x-security.c network: replace wireless-security with libnma's NMAWs 2022-11-30 13:40:09 +01:00
ce-page-8021x-security.h network: Convert CEPage widgets to GtkTemplate 2019-11-06 22:04:15 +13:00
ce-page-details.c network: Connect signal handlers in swapped form 2023-06-07 09:12:54 +12:00
ce-page-details.h wifi: Add a confirmation dialog when forgetting a connection 2023-04-11 11:28:26 +00:00
ce-page-ethernet.c Resolving suggestions 2023-03-29 14:26:55 +13:00
ce-page-ethernet.h Fix license headers that must have got search and replaced 2020-07-17 09:24:32 +12:00
ce-page-ip4.c network: keep track of radio buttons in connection editor with action 2023-05-24 08:54:06 +00:00
ce-page-ip4.h network: Port to GTK4 2021-12-14 22:34:21 -03:00
ce-page-ip6.c network: keep track of radio buttons in connection editor with action 2023-05-24 08:54:06 +00:00
ce-page-ip6.h network: Port to GTK4 2021-12-14 22:34:21 -03:00
ce-page-security.c network: replace wireless-security with libnma's NMAWs 2022-11-30 13:40:09 +01:00
ce-page-security.h Fix license headers that must have got search and replaced 2020-07-17 09:24:32 +12:00
ce-page-vpn.c network: Port to GTK4 2021-12-14 22:34:21 -03:00
ce-page-vpn.h Fix license headers that must have got search and replaced 2020-07-17 09:24:32 +12:00
ce-page-wifi.c network: Port to GTK4 2021-12-14 22:34:21 -03:00
ce-page-wifi.h Fix license headers that must have got search and replaced 2020-07-17 09:24:32 +12:00
ce-page-wireguard.c network: Connect signal handlers in swapped form 2023-06-07 09:12:54 +12:00
ce-page-wireguard.h network: Add support for WireGuard (GNOME/gnome-control-center#982) 2023-01-16 20:35:02 +00:00
ce-page.c network: Port to GTK4 2021-12-14 22:34:21 -03:00
ce-page.h network: Convert CEPage widgets to GtkTemplate 2019-11-06 22:04:15 +13:00
connection-editor.gresource.xml network: Add support for WireGuard (GNOME/gnome-control-center#982) 2023-01-16 20:35:02 +00:00
connection-editor.ui network: Add ToastOverlay to connection-editor 2023-05-26 02:04:52 +00:00
details-page.ui Mark some strings as translatable 2023-08-11 12:07:00 +02:00
ethernet-page.ui network: Increase maximum MTU value from 10000 to 65536 2023-03-24 01:47:09 +00:00
ip4-page.ui network: keep track of radio buttons in connection editor with action 2023-05-24 08:54:06 +00:00
ip6-page.ui network: keep track of radio buttons in connection editor with action 2023-05-24 08:54:06 +00:00
meson.build all: meson: do not specify resources from gresource files as dependencies 2023-05-24 08:34:14 +00:00
net-connection-editor.c network: fix criticals when updating connection 2023-08-30 08:44:55 +00:00
net-connection-editor.h network: Show spinner instead of delaying dialog 2020-12-17 21:27:51 +00:00
security-page.ui network: Port to GTK4 2021-12-14 22:34:21 -03:00
vpn-helpers.c vpn-helpers: Use GtkFileDialog and AdwMessageDialog 2023-06-06 13:33:29 +00:00
vpn-helpers.h network: Remove unused function 2019-11-06 22:04:15 +13:00
vpn-page.ui network: Port to GTK4 2021-12-14 22:34:21 -03:00
wifi-page.ui network: Port to GTK4 2021-12-14 22:34:21 -03:00
wireguard-page.ui network: Increase maximum MTU value from 10000 to 65536 2023-03-24 01:47:09 +00:00
wireguard-peer.ui network: Add support for WireGuard (GNOME/gnome-control-center#982) 2023-01-16 20:35:02 +00:00