Gnome-control-center checks the display modes by
cc_display_config_is_scaled_mode_valid()
...
cc_display_config_dbus_is_scaled_mode_valid()
to exclude unusable low resolutions.
However, it is the current using resolution that going to be tested by
is_scaled_mode_allowed() in is_scale_allowed_by_active_monitors(), if it
is global scaled required or configured as cloning mode originally.
Therefor, it will check current using resolution again and again,
instead of the enumerated one. This leads gnome-control-center building
wrong resolution list on the panel.
This patch replaces the current mode with the enumerated mode to have
the correct resolution to be tested by is_scaled_mode_allowed().
Fixes#903
We were only presenting the permission infobar when there were
already printers added (printer-list view).
We also want users to see the infobar when they don't have any
printers (empty-page).
g_warning () is for environment errors. Additional tags than the
ones we require are not necessarily an error.
This behavior causes g-c-c to spam the journal with entries such
as:
Unknown Tag in /usr/share/gnome-background-properties/fedora-workstation-backgrounds.xml: license
Unknown Tag in /usr/share/gnome-background-properties/fedora-workstation-backgrounds.xml: email
Unknown Tag in /usr/share/gnome-background-properties/fedora-workstation-backgrounds.xml: author
Where "license", "email", and "author" are valid tags that we just
don't use.
application-x-executable didn't look very good here.
adwaita-icon-theme now has a dedicated icon for this panel, which is
better suited - preferences-desktop-apps. Use this instead.