According to [1], the string "This could be the result of
the graphics driver being used, or the desktop being used
remotely" should end with a period. This wasn't addressed
in [2], so add the period to fix this issue.
[1] https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2020
[2] 909f068672
Night light can be unavailable in three cases:
- Device being used remotely
- Unsupported graphics driver
- Using a virtual machine
In all of these cases, a GtkInfoBar is shown. However, GtkInfoBar is
deprecated. AdwBanner is the replacement, but it's meant for short
text and the text explaining the three cases above is quite long for
AdwBanner. AdwStatusPage can be used with longer text, so use it.
Splitting the translation for the CcSpeakerTestButton tooltip is not
ideal. However, fixing that would require keeping track of all the
`pa_channel_position_t` and translating all speaker names as well.
From context of the dialog, it's obvious that it is about testing
speakers, so we can also go with tooltips like "Front Left" instead
of "Front Left Speaker".
We then don't need any translations.
Partially reverts commit a8148b40, but keeps the tooltips and screen
reader output is the same now as before a8148b40.
Fixes#2905
The full icon name is `org.gnome.Settings-accessibility-symbolic`. Even
though it was still being found due to the way icon lookup works, the
Fedora Update System (bodhi) Automated Testing tagged this with
Desktop file /usr/share/applications/gnome-universal-access-panel.desktop
on x86_64 references icon org.gnome.Settings-accessibility but no
subpackages contain org.gnome.Settings-accessibility
So, fix that.
AdwActionRow is already accessible by default.
Also, in [1] the GtkScales were set as activatable-widgets
of their corresponding rows, making the GtkScales to be
correctly a11y-labelled by the row title.
[1] 7e25cd8a8f
Each printer entry/row has several elements such as texts
and buttons. When there lots of printers showing in the
Printers panel (like in a corporate environment, for example),
the printer list can look very cluttered.
To fix this problem, use the new .boxed-list-separate style
class from libadwaita 1.6, which adds a gap between the rows
from a list box.
The dialog gets destroyed when closing but it was only getting recreated
when g-r-d RDP credentials changed. Instead we should recreate the
dialog on demand, just like in desktop sharing.
- In the "No Events" status page, use the .dim-label
style class instead of using the "opacity" property
- Fix a typo in a GtkStackPage name:
(page_unavaliable -> page_unavailable)
- Set the "Device Security Unavailable" status page
directly as a child widget of the panel_unavailable
GtkStackPage. Using AdwPreferencesPage/Group isn't
necessary
- Don't make the "Device Security Unavailable" status
page dimmed, as status pages from other panels aren't
dimmed
- Wrap the "No Events" status page into a GtkBox that
has the .card style, which avoids the .card looking
being incorrectly dimmed
- Use more descriptive names in the stack pages from
firmware_security_log_stack
Previously, the row would remain visible (and do nothing when clicked)
if g-c-c is compiled w/o support for libmalcontent. Now, we make sure to
only show the row if compiled w/ libmalcontent support.
This more clearly indicates that HSI-1 is firmly between HSI-0 and HSI-2
in goodness/badness. It is secure, so the lock icon is locked. It's just
not as great as HSI-2, so it's yellow rather than green.
Tweak the text slightly to improve clarity. For example, instead of just
saying "Checks Failed" let's say "Security Checks Failed." There is
room to make the strings slightly longer.
The hardest part here was deciding what to say about the HSI-1 security
level, which is not described very well currently. I've made the largest
changes at this level.
For a managed GtkShortcutController, changing its propagation phase
away from `GTK_PHASE_BUBBLE` currently results in a lingering reference
due to a bug in GTK (gtk#6246). This means the Escape key shortcut
remains active even after leaving the Display panel, resulting in a
crash when pressing Escape in any panel after leaving the Display panel.
This is now fixed in GTK (gtk!7115), but there seems to be no reason for
changing the propagation phase at all anyways. Since the callback
returns `GDK_EVENT_PROPAGATE` when it does not activate, the event
should still make it to other handlers.
So, to speed up the fix for gnome-control-center, we remove the
propagation phase changes althogether. There is also no need to let the
shortcut have global scope, managed is enough.
Closes#2768
When a permission for an app is reset, e.g. via:
flatpak permission-reset APP_ID
the Changed signal simply contains one fewer entry in its dictionary. If
we had a row for an app_id, and such app_id is not in the new
permissions we remove the row from the list box.
Fixes: https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2993
By creating a .cc-placeholder-row style class that
sets a padding, it won't be necessary to set margins
to every GtkLabel that is being used as list box
placeholder widgets.
Use em dash in the "Error: some settings cannot be unlocked",
which is now "Error — some settings cannot be unlocked".
This improves consistency with the banner from Online Accounts
which says "Offline — unable to connect accounts" when the device
is offline; this banner text uses an em dash.
Since we started moving some settings from the Sharing panel to other
panels, we were left with only tree things in the Sharing panel for
gnome-46: hostname row, file sharing row, and media sharing row.
The hostname row is already in System ->About, so we should check
whether file-sharing or media-sharing are supported and show the panel
accordingly.
Fixes#2979
So that we have a function to check whether we should show the "Media
Sharing" row.
This is going to be useful when we will try to hide the entire panel if
both "Media Sharing" and "File Sharing" aren't available.
Since [1], the crosshair options are now inside an
AdwExpanderRow, meaning that they don't need to be
insensitive when the "Crosshair Lines" option is
disabled because they get hidden in such case.
However, the "Overlap Mouse Cursor" row wasn't updated
in [1] to reflect that, so address this issue.
[1] 054d9c8769
When the Crosshair Lines option is disabled, the crosshair options
appear insensitive and consume vertical space unnecessarily. Use
AdwExpanderRow to fix this.
- Rename the "Other Media" row to "Other Media Types" (including
the window title) and remove its subtitle
- Rename "Automatically Launch Apps" row to "Media Autostart"
and use "Start apps or prompt when media is connected" as its new
subtitle
Reference:
288a451db2
