Commit graph

23745 commits

Author SHA1 Message Date
Automeris naranja
5192d9ef36 mouse-test: Make some UI tweaks to follow the latest mockups
- Use "select-mode-symbolic" in the "Clicking"
view switcher

- Ditch the border radius from the scroll test
image

- Make click-status-emblem indicator indicator
to show a more prominent green color when the
test passes

- Don't use @borders for the click-status-emblems
background color because this named color isn't
meant for backgrounds

- Make non-green click-status-emblems dimmed

Reference: 6d5e1813ca
2024-03-27 18:10:44 -03:00
Felipe Borges
bbfbfb76cb shell, window: Handle old panel cmdline arguments in System
The System panel subpages used to be CcPanels. They still have
their own desktop file so that they can be findable in Search.

A future goal is to decouple our Search model from our panel list
model, so that we can better handle panel subpages and other more
grained search results.

Fixes #2930
Fixes #2974
2024-03-27 13:38:46 +00:00
Felipe Borges
3ff371e61c shell, panel-list: Avoid accessing a negative array index
As the list of panels doesn't match the list of items in the model.
2024-03-27 13:38:46 +00:00
Felipe Borges
994a540bfc system, datetime: Don't set datetime when auto time sync is enabled
The timedate1_call will fail because network time synchronization is enabled:

GDBus.Error:org.freedesktop.timedate1.AutomaticTimeSyncEnabled: Automatic time synchronization is enabled

Let's not set_time when NTP is not available, neither set time by
accident at the widget construction stage. When widgets signals are connected
in the UI file their respective callback was getting called. By moving
the signal connection to callbacks to the widget's _init method we
avoid the unwanted callback call.

Fixes #2945
2024-03-27 13:13:13 +00:00
Felipe Borges
2cf5b90cce common: Check for valid GDateTime object before comparing
Avoids the critical below at runtime
11:14:36.7796                   **[873815]:CRITICAL: cc_util_get_smart_date: assertion 'date != NULL' failed
11:14:36.7802                   **[873815]:CRITICAL: cc_util_get_smart_date: assertion 'date != NULL' failed

Which comes from the location panel passing a NULL date object.

\#0  _g_log_abort (breakpoint=1) at ../shell/cc-log.c:72
        debugger_present = 1
\#1  0x000000000045c3c4 in cc_log_write
    (log_level=10, log_domain=0x7ffff7d592eb "GLib", log_message=0x234c400 "g_date_time_difference: assertion 'begin != NULL' failed", fields=0x7fffffffd740, n_fields=4, user_data=0x0)
    at ../shell/cc-log.c:315
        log_str = 0x234b8d0
        stream = 0x7ffff5dbb4e0 <_IO_2_1_stderr_>
        can_color = 1
\#2  0x000000000045c4f5 in cc_log_handler (log_level=G_LOG_LEVEL_CRITICAL, fields=0x7fffffffd740, n_fields=4, user_data=0x0) at ../shell/cc-log.c:348
        log_domain = 0x7ffff7d592eb "GLib"
        log_message = 0x234c400 "g_date_time_difference: assertion 'begin != NULL' failed"
\#3  0x00007ffff7c9f534 in g_log_structured_array () at /lib64/libglib-2.0.so.0
\#4  0x00007ffff7ca4f57 in g_log_default_handler () at /lib64/libglib-2.0.so.0
\#5  0x00007ffff7c9be29 in g_logv () at /lib64/libglib-2.0.so.0
\#6  0x00007ffff7c9c193 in g_log () at /lib64/libglib-2.0.so.0
\#7  0x00007ffff7c787fa in g_date_time_difference () at /lib64/libglib-2.0.so.0
\#8  0x000000000059c186 in cc_util_get_smart_date (date=0x0) at ../panels/common/cc-util.c:124
        today = 0x2350130
        local = 0x2350100
        span = 10791504
\#9  0x00000000004f8a20 in add_location_app (self=0x1dee1c0, app_id=0x232fef0 "org.gnome.Calendar", enabled=1, last_used=459618461810) at ../panels/privacy/cc-location-page.c:209
        data = 0xffffda80
        app_info = 0x2341c50
        t = 0x0
        row = 0x2348280
        w = 0x234fe00
        icon = 0x2345310
        last_used_str = 0x0
        desktop_id = 0x7fffcc034c30 "DL\310\375\a"
\#10 0x00000000004f8db4 in update_perm_store (self=0x1dee1c0, permissions=0x7fffcc04e2c0, permissions_data=0x7fffcc04ee80) at ../panels/privacy/cc-location-page.c:282
        enabled = 1
        last_used = 459618461810
        iter = {x = {140736616260288, 2, 0, 6386038, 140736616096608, 36922576, 16, 3579507750, 140737488345904, 140737350561909, 33733184, 36922576, 140737488345936, 140737350702366, 36922576, 3278251457363369984}}
        key = 0x232fef0 "org.gnome.Calendar"
        value = 0x7fffcc04e090
\#11 0x00000000004f8f4e in on_perm_store_lookup_done (source_object=0x1e24040, res=0x202ba40, user_data=0x1dee1c0) at ../panels/privacy/cc-location-page.c:324
        error = 0x0
        ret = 0x7fffcc04eef0
        permissions = 0x7fffcc04e2c0
        permissions_data = 0x7fffcc04ee80
\#12 0x00007ffff7e9082c in g_task_return_now () at /lib64/libgio-2.0.so.0
\#13 0x00007ffff7e944c3 in g_task_return () at /lib64/libgio-2.0.so.0
\#14 0x00007ffff7efe88b in reply_cb () at /lib64/libgio-2.0.so.0
\#15 0x00007ffff7e9082c in g_task_return_now () at /lib64/libgio-2.0.so.0
\#16 0x00007ffff7e944c3 in g_task_return () at /lib64/libgio-2.0.so.0
2024-03-27 13:13:13 +00:00
Automeris naranja
4a986072ce app-notifications-dialog: Port to AdwDialog
Also, remove the ESC shortcut, since AdwDialogs
already close with ESC by default.
2024-03-27 13:51:08 +01:00
Felipe Borges
d5bd2d1029 build: Bump libadwaita version to 1.5 2024-03-27 12:32:39 +00:00
Automeris naranja
b7c1b671a0 application: Port AdwAboutWindow to AdwAboutDialog 2024-03-27 12:23:36 +00:00
Automeris naranja
f366102d89 removable-media-settings: Port "Other Media" to AdwDialog 2024-03-27 12:20:47 +00:00
Felipe Borges
4525890c27 multitasking, accessibility: Remove spaces from desktop file keywords
Spaces are not supported in .desktop file keywords[0] as gnome-shell
splits the search term by spaces, and then prefix-matches each word separately
against the candidate keywords.

Inspired by commit 7bd8dd69cf
2024-03-27 10:24:02 +00:00
Automeris naranja
6e3f7c6055 secure-shell-page: Use "Command copied to clipboard" string
When copying the login command, a toast appear
saying "Command copied". However, these kind of toasts
usually says that the text was copied *to the clipboard*,
like the toast from System > About > System Details > Copy.
2024-03-26 20:46:35 -03:00
Martin
04751aebd6 Update Slovenian translation 2024-03-26 19:56:07 +00:00
Automeris naranja
2b1a66d7ce users: Rename "Add Enterprise User" to "Add Enterprise Login"
This button is labelled as "Add Enterprise Login" in
the mockups[1].

Also:
- Add missing mnemonic
- Add ellipsis to the button label, since it's required
when the button triggers further user interaction[2]

[1] a0e4f828ec
[2] https://developer.gnome.org/hig/guidelines/writing-style.html#ellipses
2024-03-25 15:08:29 +00:00
Philip Withnall
7bd8dd69cf users: Simplify parental controls keywords to remove spaces
Spaces aren’t supported in .desktop file keywords, as gnome-shell splits
the search term by spaces, and then prefix-matches each word separately
against the candidate keywords.

So a search term of ‘parental’ would match the ‘Parental Controls’
keyword, but a search term of ‘parental controls’ would not, as
‘controls’ doesn’t prefix-match anything.

Avoid that by removing spaces from the keywords.

Signed-off-by: Philip Withnall <pwithnall@gnome.org>

Helps: https://gitlab.freedesktop.org/pwithnall/malcontent/-/issues/48
2024-03-25 14:17:45 +00:00
Felipe Borges
98f0ae851a po: Update POTFILES.in for moves in privacy panel 2024-03-25 14:43:32 +01:00
Automeris naranja
f00dc11f38 privacy: Separate subpages files in their respective folders
Accessibility and System panel folders also
have this folder structure, which is way more organized.
2024-03-25 14:43:32 +01:00
Felipe Borges
97df4c7f0a po: Update POTFILES.in for changes in System panel 2024-03-25 14:36:44 +01:00
Felipe Borges
4e02ac86cb po: Update POTFILES.in for changes in appdata file
This is a regression introduced by !2252

See d9970d4f27 (note_2059992)
2024-03-25 14:34:56 +01:00
Felipe Borges
942461d0d8 system, remote-desktop: Rename "RemoteSession" code to "RemoteLogin"
To be consistent with what we show in the UI and conciliate the
confusion with Secure Shell, which was formerly named "RemoteLogin".
2024-03-25 12:33:23 +00:00
Felipe Borges
9a05b542e2 system, secure-shell: Rename internal name from RemoteLogin
As the user facing name of this setting changed to "Secure Shell",
let's change its internal name to match it.

This avoids confusion with the Remote Desktop "Remote Session" setting,
which is now named "Remote Login" in the UI and should get its code
renamed to follow that consistently.
2024-03-25 12:33:23 +00:00
Felipe Borges
96cf88c68f system, remote-login: Fix header name typo
Fixes
https://gitlab.gnome.org/GNOME/gnome-control-center/-/merge_requests/2211#note_2061610
2024-03-25 10:40:30 +00:00
Felipe Borges
5323020102 privacy: Fix Thunderbolt page tag name
The main panel was looking for a page with tag "bolt" when the panel
is actually using the "thunderbolt" tag.

Fixes #2973
2024-03-25 11:19:43 +01:00
Martin
a4d6ef5d64 Update Slovenian translation 2024-03-24 23:32:16 +00:00
Quentin PAGÈS
ab4801fc85 Update Occitan translation 2024-03-24 14:49:21 +00:00
Peter Hutterer
33c49dc125 wacom: Check for the right output connector name
Otherwise we just return the first output with the corresponding vendor
and serial number.

Fixes: 75ce02e202 ("wacom: Provide connector name for disambiguation")
2024-03-22 13:02:22 +00:00
Peter Hutterer
ebd2b013dd wacom: Accept 4-value output settings
We now store the connector name as fourth value.

Fixes: 75ce02e202 ("wacom: Provide connector name for disambiguation")
2024-03-22 13:02:22 +00:00
Felipe Borges
0787182dd0 search: Prevent listbox placeholder from being treated like a row
The Search panel providers listbox has a placeholder label that is
visible when there are no listbox items.

The placeholder label is being considered in the list of children
of the listbox while estimating whether "Moving down" is allowed for
the listbox reorder feature.
2024-03-22 12:43:24 +00:00
Automeris naranja
1d00a94009 search: Tweak "No Apps Found" placeholder
The current placeholder that appears when no
providers are available has some problems:

- The row is activatable, but this is unnecessary
- The row has no padding
- The "No Apps Found" string doesn't use header
capitalization

Fix this by using a GtkListBox placeholder widget, with
margins and with header capitalization in the string.
2024-03-22 12:43:24 +00:00
Hari Rana
d9970d4f27 flatpak: Suffix app ID with .Devel
This commit changes the app ID from `org.gnome.SettingsDevel` to `org.gnome.Settings.Devel`, as recommended by the GNOME Developer Documentation - https://developer.gnome.org/documentation/tutorials/application-id.html#application-id-for-flatpak-development.

Additionally, some changes have been made in the buildsystem, to properly substitute the app ID depending on the profile in use.
2024-03-21 16:14:31 +00:00
Felipe Borges
49e35600c9 power: Load a different list for suspend-times when on mobile
Using the systemd-hostnamed chassis-type to detect when running on
"tablet", "handset", or "watch" and setting a more reasonable list
of suspend time options for them.
2024-03-21 16:01:11 +00:00
silver
f694945b6e power: Add some more reasonable suspend time options for mobile
Edited by felipeborges.
2024-03-21 16:01:11 +00:00
Tomasz Kłoczko
74248b58ef update DocBook DTD version to latest stable 4.5
Signed-off-by: Tomasz Kłoczko <kloczek@github.com>
2024-03-21 15:56:33 +00:00
Chris Williams
bdd1a1037a system/about: Make print-renderer helper log to stderr
This avoids debug logging appearing in the UI via stdout when
G_MESSAGES_DEBUG is used.

Fixes #2387
2024-03-21 11:00:45 +00:00
Felipe Borges
180045d7b3 po: Update POTFILES.in for panels/applications/cc-default-apps-row.c 2024-03-21 09:50:45 +00:00
Munazza Shabir
adb485e18c apps, default-apps: Indicate when no apps are available for a mime type
As discussed in #2870 the current way of displaying insensitve rows when
no apps are availbe to handle a mime type is confusing.

Fix this by showing a "No Apps Available" label in the aforementioned case.

Fixes #2870
2024-03-21 09:50:45 +00:00
Automeris naranja
d5c66d25a0 about-page: Use property rows
Doing so, the system/hardware information rows
can be properly displayed in small screen sizes.
2024-03-21 09:32:48 +00:00
Sabri Ünal
da989adcbf Update Turkish translation 2024-03-20 21:26:23 +00:00
Felipe Borges
52f165f36b system: Load subpages on demand
Let's manually wire the row activation to the panel creation so that
we can create panels on demand.

This also makes calls to subpages directly avoid initializing the
other panels.

Fixes #2857
2024-03-20 15:48:57 +00:00
Hari Rana
fd41fc198c
flatpak: Use meson buildsystem for mobile-broadband-provider
mobile-broadband-provider recently ported to meson:
https://gitlab.gnome.org/GNOME/mobile-broadband-provider-info/-/merge_requests/108
2024-03-20 11:22:42 -04:00
Automeris naranja
beaa14ecdf wifi-connection-list: Add a placeholder widget to the list box
Doing so, the Wi-Fi list box won't appear broken when
it's empty.

Closes https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2574
2024-03-20 09:14:35 +00:00
Vincent Chatelain
b646ebd7fd Update French translation
(cherry picked from commit 15ffa25c7f)
2024-03-19 21:25:53 +00:00
Jordi Mas
12aca3ac64 Update Catalan translation 2024-03-19 21:53:34 +01:00
Jordi Mas i Hernandez
bca235debb Update Catalan translation
(cherry picked from commit 3209ef7a93)
2024-03-19 20:17:17 +00:00
Fran Dieguez
ec989a1151 Update Galician translation
(cherry picked from commit 01739ff0ae)
2024-03-19 15:33:04 +00:00
Robert Ancell
8840e54707 Remove myself from the maintainers list.
I'm no longer engaged enough to be a maintainer so it's best to make that clear.
Still happy to review and be involved if others need it!
This is a great project and if you want to be more involved in GNOME I'd recommend it.
2024-03-19 10:19:47 +13:00
Martin
b0f3fff2ee Update Slovenian translation 2024-03-18 16:10:50 +00:00
Automeris naranja
5844b039e3 universal-access: Open subpage when CcPanel.subpage is set
This allows launching the Accessibility panel subpages
from the command line.

See https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2940
2024-03-18 12:14:41 +00:00
Felipe Borges
a76f19bc4b Post-release version bump 2024-03-18 13:10:06 +01:00
Felipe Borges
808ac116e2 system, remote-desktop: Don't start Desktop Sharing page hidden
At init it will verify whether the panel can be constructed in the
check_desktop_sharing_available call, and with that hide/show the
panel accordingly.

Fixes #2955
2024-03-18 11:49:17 +00:00
Yaron Shahrabani
ac8fd3a4e9 Update Hebrew translation
(cherry picked from commit 56ea1812df)
2024-03-17 13:10:46 +00:00