Also, remove the list box placeholder since the button will appear
even when the list is empty. The button now acts like a placeholder
too.
Co-authored-by: Matthijs Velsink <mvelsink@gnome.org>
As suggested by Matthijs Velsink, it is much cleaner handling UI
related things in the .ui file.
This is a cleaner version of commit 3f612ab81
Related to !2656, fixing #3086
AdwStatusPage has a built-in GtkScrolledWindow and it can't be used
with other widgets. Put the GtkStack directly in AdwDialog:property
instead.
Doing so, the AdwStatusPage no longer needs the vexpand property.
Use AdwWindowTitle and show the printer name using
AdwWindowTitle:subtitle. This gives more room to show the printer name,
especially when the name long, which is prone to get ellipsized.
The GtkSearchEntry dialog was eating up the Escape key press events,
causing the dialog not to close as expected.
This adds a controller to explicitly handle key-press events on a
dialog level, which will close the dialog for the Escape key and
just propagate the event down the chain otherwise.
Fixes#3086
Laptops aren't the only devices GNOME cas run on that have an internal
screen, there are also smartphones and all-in-one desktops. This updates
the a label and some translators comments to reflect that.
Signed-off-by: Adrien Plazas <aplazas@gnome.org>
- Use AdwPreferencesPage, AdwPreferencesGroup and
AdwStatusPage
- Remove the .view style class
- Add the .boxed-list style class to the jobs list box
- Add mnemonic to the "Clear All" button
Also:
- Use gtk_button_new_from_icon_name instead of
embedding a GtkImage into a GtkButton
- Remove margins from "widget_button" and "widget_nocalib",
because suffix widgets from AdwActionRows already have
margins
- Place the "Not Calibrated" label before the switches and
use header capitalization in it, as advised by HIG
- Decrease the "widget_nocalib" margin-end to "6", so it doesn't
look too far from the switches
Instead of showing an empty space as the placeholder for the "Port" row
subtitle, use "—", like Nautilus and Disks does when a value is empty,
for example.
These rows aren't activatable, so using a mnemonic isn't necessary.
Another thing is that the rows aren't using
AdwPreferencesRow:use-underline, which makes the row title to look
broken.
Remove the underlines and also add a mnemonic to the Camera switch
row.
Whether libwacom knows about a tablet has no effect on whether the
tablet works, only whether we know how to map it, which styli are
available, etc.
Instead of pretending there is no tablet connected let's use the
libwacom fallback tablet instead. As of libwacom 2.11 that defaults to a
built-in tablet (the vast majority of devices these days) which means we
can at least map this to an output, calibrate it etc.
Doing so, the dialog will be adaptive in when the window
width is narrow.
Also, ditch the .linked style class, because the buttons
are now in a reflowing grid.
This allows to copy the row contents without opening the System
Details dialog. This can be useful if the user just wants to
copy the hardware model, for example.
Remove the gnome_rr_* bindings and substitute them with the respective
calls from the CcDisplayMonitor. This way we get the same monitor names
as the display panel.
Closes#1821
Instead, instantly show a primary click was successful. For a double
click, it will remove the primary click success. This makes the testing
feel a little more responsive.
Closes#2991
- Add GtkLabel:wrap, otherwise qr-code-dialog width will grow
if the label is long
- Justify the label to the center so it looks more balanced
when it wraps
The "Network Name" and "Password" labels look unbalanced if they
are long. To fix this, use property rows to show the network
information, which also involves porting the GtkScrolledWindow
to AdwPreferencesPage.
- Make the QR code focusable, so the alternative text can be read
by Orca
- Make all labels selectable, but with a workaround to prevent them
showing selected without any user interaction (labels need to be
selectable so they can be read)
This placeholder row will never show because the list box will never be
empty due to the presence of the "Add Input Source" row, which also acts
as a placeholder. Also, the placeholder row broke the list box row
counting even more.
So, remove the "No input source selected" placeholder row, as it's
unnecessary.
The indicators should only light up for primary or secondary clicks, but
not for a middle click.
To make this clearer too, we can use Gdk constants.
Fixes#3079
This saves a lot of code and translatable strings. Also, this will make
it easier to change the list values in the future, as they will be added
to the list even if a value is set that is not in the list.
By binding to the GSettings keys directly, even more code can be
removed.
This reverts commit 62564c623f.
The custom style class was used to provide different styling than the default destructive style, since the custom style class doesn't affect the opacity of the background.
Similarly to fd65182, rpminspect catched that gnome-wifi-panel.desktop
references an icon name that doesn't exist.
```
Desktop file /usr/share/applications/gnome-wifi-panel.desktop on x86_64 references icon network-wireless but no subpackages contain network-wireless
```
The way the icon lookup works will suffix it with "-symbolic", resulting
in "network-wireless-symbolic", which exists.
While MR !2452 provided settings icons for various panels, it didn't for
the Wifi panel.
