Commit graph

23697 commits

Author SHA1 Message Date
Felipe Borges
6127c08fa3 system, datetime: Don't set datetime when auto time sync is enabled
The timedate1_call will fail because network time synchronization is enabled:

GDBus.Error:org.freedesktop.timedate1.AutomaticTimeSyncEnabled: Automatic time synchronization is enabled

Let's not set_time when NTP is not available, neither set time by
accident at the widget construction stage. When widgets signals are connected
in the UI file their respective callback was getting called. By moving
the signal connection to callbacks to the widget's _init method we
avoid the unwanted callback call.

Fixes #2945
2024-03-27 14:22:53 +01:00
Felipe Borges
544c146ea8 common: Check for valid GDateTime object before comparing
Avoids the critical below at runtime
11:14:36.7796                   **[873815]:CRITICAL: cc_util_get_smart_date: assertion 'date != NULL' failed
11:14:36.7802                   **[873815]:CRITICAL: cc_util_get_smart_date: assertion 'date != NULL' failed

Which comes from the location panel passing a NULL date object.

\#0  _g_log_abort (breakpoint=1) at ../shell/cc-log.c:72
        debugger_present = 1
\#1  0x000000000045c3c4 in cc_log_write
    (log_level=10, log_domain=0x7ffff7d592eb "GLib", log_message=0x234c400 "g_date_time_difference: assertion 'begin != NULL' failed", fields=0x7fffffffd740, n_fields=4, user_data=0x0)
    at ../shell/cc-log.c:315
        log_str = 0x234b8d0
        stream = 0x7ffff5dbb4e0 <_IO_2_1_stderr_>
        can_color = 1
\#2  0x000000000045c4f5 in cc_log_handler (log_level=G_LOG_LEVEL_CRITICAL, fields=0x7fffffffd740, n_fields=4, user_data=0x0) at ../shell/cc-log.c:348
        log_domain = 0x7ffff7d592eb "GLib"
        log_message = 0x234c400 "g_date_time_difference: assertion 'begin != NULL' failed"
\#3  0x00007ffff7c9f534 in g_log_structured_array () at /lib64/libglib-2.0.so.0
\#4  0x00007ffff7ca4f57 in g_log_default_handler () at /lib64/libglib-2.0.so.0
\#5  0x00007ffff7c9be29 in g_logv () at /lib64/libglib-2.0.so.0
\#6  0x00007ffff7c9c193 in g_log () at /lib64/libglib-2.0.so.0
\#7  0x00007ffff7c787fa in g_date_time_difference () at /lib64/libglib-2.0.so.0
\#8  0x000000000059c186 in cc_util_get_smart_date (date=0x0) at ../panels/common/cc-util.c:124
        today = 0x2350130
        local = 0x2350100
        span = 10791504
\#9  0x00000000004f8a20 in add_location_app (self=0x1dee1c0, app_id=0x232fef0 "org.gnome.Calendar", enabled=1, last_used=459618461810) at ../panels/privacy/cc-location-page.c:209
        data = 0xffffda80
        app_info = 0x2341c50
        t = 0x0
        row = 0x2348280
        w = 0x234fe00
        icon = 0x2345310
        last_used_str = 0x0
        desktop_id = 0x7fffcc034c30 "DL\310\375\a"
\#10 0x00000000004f8db4 in update_perm_store (self=0x1dee1c0, permissions=0x7fffcc04e2c0, permissions_data=0x7fffcc04ee80) at ../panels/privacy/cc-location-page.c:282
        enabled = 1
        last_used = 459618461810
        iter = {x = {140736616260288, 2, 0, 6386038, 140736616096608, 36922576, 16, 3579507750, 140737488345904, 140737350561909, 33733184, 36922576, 140737488345936, 140737350702366, 36922576, 3278251457363369984}}
        key = 0x232fef0 "org.gnome.Calendar"
        value = 0x7fffcc04e090
\#11 0x00000000004f8f4e in on_perm_store_lookup_done (source_object=0x1e24040, res=0x202ba40, user_data=0x1dee1c0) at ../panels/privacy/cc-location-page.c:324
        error = 0x0
        ret = 0x7fffcc04eef0
        permissions = 0x7fffcc04e2c0
        permissions_data = 0x7fffcc04ee80
\#12 0x00007ffff7e9082c in g_task_return_now () at /lib64/libgio-2.0.so.0
\#13 0x00007ffff7e944c3 in g_task_return () at /lib64/libgio-2.0.so.0
\#14 0x00007ffff7efe88b in reply_cb () at /lib64/libgio-2.0.so.0
\#15 0x00007ffff7e9082c in g_task_return_now () at /lib64/libgio-2.0.so.0
\#16 0x00007ffff7e944c3 in g_task_return () at /lib64/libgio-2.0.so.0
2024-03-27 14:22:53 +01:00
Robert Ancell
e6de817031 Remove myself from the maintainers list.
I'm no longer engaged enough to be a maintainer so it's best to make that clear.
Still happy to review and be involved if others need it!
This is a great project and if you want to be more involved in GNOME I'd recommend it.
2024-03-27 14:22:53 +01:00
Felipe Borges
808bb41348 system: Load subpages on demand
Let's manually wire the row activation to the panel creation so that
we can create panels on demand.

This also makes calls to subpages directly avoid initializing the
other panels.

Fixes #2857
2024-03-27 14:22:53 +01:00
Chris Williams
c14215ea91 system/about: Make print-renderer helper log to stderr
This avoids debug logging appearing in the UI via stdout when
G_MESSAGES_DEBUG is used.

Fixes #2387
2024-03-27 14:22:53 +01:00
Felipe Borges
e1224f499e search: Prevent listbox placeholder from being treated like a row
The Search panel providers listbox has a placeholder label that is
visible when there are no listbox items.

The placeholder label is being considered in the list of children
of the listbox while estimating whether "Moving down" is allowed for
the listbox reorder feature.
2024-03-27 14:22:53 +01:00
Automeris naranja
52323e2620 universal-access: Open subpage when CcPanel.subpage is set
This allows launching the Accessibility panel subpages
from the command line.

See https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2940
2024-03-27 14:22:53 +01:00
Felipe Borges
e8b261ebfc system, remote-login: Fix header name typo
Cherry-picked from 96cf88c68f

Fixes
https://gitlab.gnome.org/GNOME/gnome-control-center/-/merge_requests/2211#note_2061610
2024-03-25 13:23:48 +01:00
Felipe Borges
8099545f2b privacy: Fix Thunderbolt page tag name
The main panel was looking for a page with tag "bolt" when the panel
is actually using the "thunderbolt" tag.

Cherry-picked from
5323020102

Fixes #2973
2024-03-25 11:24:55 +01:00
Boyuan Yang
cfefe02c2a Update Chinese (China) translation 2024-03-22 04:02:19 +00:00
Boyuan Yang
ae1a719c1a Update Chinese (China) translation 2024-03-21 23:38:06 +00:00
Sabri Ünal
80acfcdc62 Update Turkish translation 2024-03-20 21:25:03 +00:00
Vincent Chatelain
15ffa25c7f Update French translation 2024-03-19 21:25:47 +00:00
Jordi Mas i Hernandez
3209ef7a93 Update Catalan translation 2024-03-19 20:17:08 +00:00
Fran Dieguez
01739ff0ae Update Galician translation 2024-03-19 15:32:57 +00:00
Martin
04b4e996c5 Update Slovenian translation 2024-03-18 16:12:34 +00:00
Felipe Borges
9ac8f223cb 46.0 2024-03-18 12:53:41 +01:00
Felipe Borges
af041fd8be system, remote-desktop: Don't start Desktop Sharing page hidden
At init it will verify whether the panel can be constructed in the
check_desktop_sharing_available call, and with that hide/show the
panel accordingly.

Fixes #2955
2024-03-18 12:53:26 +01:00
Yaron Shahrabani
56ea1812df Update Hebrew translation 2024-03-17 13:10:41 +00:00
Asier Sarasua Garmendia
dba809f1ca Update Basque translation 2024-03-17 09:50:23 +00:00
Christian Kirbach
a95c902f97 Update German translation 2024-03-16 22:08:09 +00:00
Aurimas Černius
635364768c Update Lithuanian translation 2024-03-16 20:35:58 +00:00
Baurzhan Muftakhidinov
0c5349dc2a Update Kazakh translation 2024-03-16 18:14:08 +00:00
Ekaterine Papava
c88c560823 Update Georgian translation 2024-03-16 03:12:40 +00:00
Jiri Grönroos
561f4ce92c Update Finnish translation 2024-03-15 19:50:27 +00:00
Yuri Chornoivan
4d95b4cd59 Update Ukrainian translation 2024-03-15 19:49:39 +00:00
Bruce Cowan
88b247b3a6 Update British English translation 2024-03-15 18:32:58 +00:00
Piotr Drąg
fb203cb86e Update Polish translation 2024-03-15 18:47:33 +01:00
Emin Tufan Çetin
5ea276dd39 Update Turkish translation 2024-03-15 13:51:39 +00:00
Matthijs Velsink
ab94f36f82 shell: All search words must match to find row
Now that we match against all words in the query, if any of them matches
with a row it is "found".

However, it is more useful if all of the words must match, as narrowing
down the results is much quicker that way.
2024-03-15 12:36:36 +01:00
Matthijs Velsink
38ff5cc17e shell: Do not match on empty strings
Splitting the search query on spaces results in empty strings if there
are double spaces in the query. These would always match.

Therefore, do not do anything with empty search words.
2024-03-15 12:36:30 +01:00
Matthijs Velsink
1097e7b03e shell: Split search entry only once
There is no need to split a search entry for every row we want to match,
we can do it once when the search entry is updated.
2024-03-15 12:36:24 +01:00
Felipe Borges
061bfc1e97 shell: Display search results for multiple query words
Before, queries like "remote desktop" were going through g_strstrip()
and turning alternative matches to "remote" or "desktop" unreachable.

See #2763
2024-03-15 12:36:19 +01:00
Anders Jonsson
dee5cf0870 Update Swedish translation 2024-03-15 11:05:43 +00:00
Daniel Rusek
923d094b0a Update Czech translation 2024-03-15 10:08:20 +00:00
Danial Behzadi
e7b2b086cc Update Persian translation 2024-03-15 10:06:32 +00:00
Sabri Ünal
1bf7b6b2a1 i18n: Add missing translatable files
These files contain important strings visible on setting search.
2024-03-15 10:47:06 +01:00
Matthijs Velsink
4244d3ada5 subprojects: Update gvc to latest commit
A crash possibility has been fixed in libgnome-volume-control!25.

A similar crash was reported on the Settings side, so update to the
latest gvc commit to hopefully prevent further crashes.

Related: gnome-shell#7173
Related: #2924
2024-03-14 13:21:32 +01:00
Daniel Rusek
f53caecd6c Update Czech translation 2024-03-14 11:14:27 +00:00
Automeris naranja
47523f03a2 privacy: Update subpage tags in the main page
Each page had its AdwNavigationPage tag updated in [1],
but the tags in the Privacy panel main page weren't
updated, which made all the subpages fail to open.

[1] 917248d7bf
2024-03-14 11:59:39 +01:00
Automeris naranja
87f7a72c23 add-user-dialog: Port to AdwToolbarView
Also, allow closing the dialog with ESC.
2024-03-14 11:58:18 +01:00
Changwoo Ryu
4445f255ca Update Korean translation 2024-03-14 10:57:26 +00:00
Alan Mortensen
e85f2f67fc Update Danish translation 2024-03-12 18:03:12 +00:00
Artur S0
fb06ccd5d8 Update Russian translation 2024-03-12 13:42:28 +00:00
Daniel Rusek
88b660214f Update Czech translation 2024-03-12 11:54:49 +00:00
Felipe Borges
36f9650e90 system: Use CcPanel.subpage for launching subpages
Rather than overriding the parameters property.
2024-03-12 12:17:53 +01:00
Felipe Borges
76245d592e privacy: Open subpage when CcPanel.subpage is set
Fixes #2940
2024-03-12 12:17:49 +01:00
Felipe Borges
bec20d6cc0 privacy: Update subpages tags to match expected cmdline args 2024-03-12 12:17:42 +01:00
Felipe Borges
55c7ef74fc shell: Add CcShell.subpage string property 2024-03-12 12:17:37 +01:00
Felipe Borges
6b4f66f7d3 shell-model, panel-loader: Add CC_CATEGORY_PRIVACY
This is supposed to classify pages that belong in the Privacy panel.
2024-03-12 12:17:32 +01:00