gtk_widget_translate_coordinates() doesn't have to always set the
dest_x argument. Let's initialize the argument before use to prevent
usage of uninitialized value, which also prevents "Conditional jump
or move depends on uninitialised value(s)" messages from valgrind.
Make it clearer in two ways:
• Explicitly mention ‘metered data’, as that’s a commonly used phrase.
• Explicitly mention automatic software updates as being disabled on
metered connections, to make the implications of this checkbox a
little clearer.
Signed-off-by: Philip Withnall <withnall@endlessm.com>
Helps: https://gitlab.gnome.org/GNOME/gnome-software/merge_requests/339
As per the latest mockups, the Details section is a toplevel
section, and not an actual subsection.
Remove all the code that implemented Details as a subsection,
and simply treat these panels as toplevel ones.
The "CcPermissionInfobar" widget is a more descriptive way to
communicate that some Settings panel needs authentication in order
to perform certain actions.
This widget doesn't handle the permissions (as in GPermission)
itself. It needs to be binded to an existing instance of GPermission,
and it will react to the permission's state (show when the current
user is not authorized, and hide when the user is authorized).
This is part of a big set of changes that aim to set a consistent
authentication method accross Settings panels.
See #685, #556, and #771
The same way that GNOME Shell does it, we set:
* audio-volume-muted-symbolic when mute button is toggled*
* audio-volume-low-symbolic when 0 < volume < 30%
* audio-volume-medium-symbolic when 30% < volume < 70%
* audio-volume-high-symbolic when 70% < volume <= 100%
When "muted" we can't actually rely on volume (it can be close
to zero but not absolute zero). Instead of requiring volume == 0,
we track the state based on whether the mute button is active.
Fixes#521
A little above in the function, we update the page UI, maybe destroying
the bits that allow decoupling display-attached tablets from their display.
Later on, we unconditionally update its GtkSwitch.
This can't bode well on tablets where the widget was already destroyed.