More clear scoping and interaction with running actions in
UmAccountDialog. In later 'enterprise login' patches we have long
running actions that's why this needs cleaning up.
In particular:
* Show errors as children of the dialog.
* Errors don't make the account dialog go away, user can correct
problems.
* Use more standard GAsyncResult style callbacks:
um_account_dialog_perform() um_account_dialog_finish()
* Disable controls while the operation is happening.
* Allow the user to cancel long actions in UmAccountDialog by
pressing the cancel button.
https://bugzilla.gnome.org/show_bug.cgi?id=677548
It's confusing to read; it reads as 'user manager'. Since this
is a GObject, just use self as customary.
Most of these lines change in later commits anyway, so this won't
really pollute the 'git blame'
https://bugzilla.gnome.org/show_bug.cgi?id=677548
So they will be properly cancelled when the panel is disposed.
Also, check early if the operation was cancelled, since it's not safe to
assume the data of the callback is valid anymore before that point.
https://bugzilla.gnome.org/show_bug.cgi?id=672572
APs that don't broadcast their SSID will return NULL from
nm_access_point_get_ssid() (since that's easier to check in C
using an if statement than returning a zero-length GByteArray).
Thus the code shouldn't try to dereference the SSID byte array
since it could be NULL.
But in fact, the panel shouldn't be showing hidden APs anywhere
in the UI, since the user needs to manually enter the SSID to
connect to it anyway. So just ignore hidden APs like nm-applet
does.
Signed-off-by: Dan Williams <dcbw@redhat.com>
Signed-off-by: Richard Hughes <richard@hughsie.com>
get_item_views() was expecting all the children of the overview
to be of type "CcShellCategoryView".
It's not the case since 620e70113c
added GtkSeparators as children.
We now just skip them non-views in get_item_views().
https://bugzilla.gnome.org/show_bug.cgi?id=677314
With hard coded colors, when an account is selected in the tree view,
the text shows up as black on blue, instead of white on blue.
Fixes: https://bugzilla.gnome.org/671980
This makes the dialog return when the user presses Enter on the filter
entry and prevents the GtkTreeView search popup from being used since
we already handle searching on that tree view.
https://bugzilla.gnome.org/show_bug.cgi?id=662489
To make this work, we need to move the setting up of priv->builder
to the instance init, so that it is available when construct properties
are set; the other setup needs to remain in the constructor, since
it relies on construct properties.
https://bugzilla.gnome.org/show_bug.cgi?id=662489
This prevents the chicken-and-egg problem as described in #653296 by launching
nm-connection-editor for the inactive connection for the device.
This only works when there is one possible connection for the device, which is
helpfully typical for wired ethernet devices.
Resolves: https://bugzilla.gnome.org/show_bug.cgi?id=653296
