For example, fix adding new VPN connections.
In 60b4956c05 I correctly observed that we
need to not run code that requires a device when there is no device.
NetConnectionEditor is a multipurpose dialog and self->device is
optional when creating the dialog. E.g. when modifying VPN
configuration, we update just the configuration, not an NMDevice.
However, I added this check too soon, before updating the connection
configuration. We need to update the configuration first, then only bail
before proceeding to update the device, not sooner.
Fix#2668
Commit d980e0ffee fixed an issue when the "Left" button would appear
at the right side for RTL languages given that GtkBox would reorder
its horizontal children to RTL direction.
The solution at the time was to force the primary-button box to stay
in LTR direction when the rest of the interface is shown in RTL.
This introduced a regression where the CSS "linked" style of the
buttons used was the LTR one, breaking the "linked" styling.
This fix will manually reorder the Left/Right buttons rather than
calling gtk_widget_set_direction on the primary-button-box.
Fixes#2649
When starting the panel, it was necessary to add the sensitive
property to 'number_of_workspaces_spin', because when doing the
'g_settings_bind' it was leaving it visible even with the dynamic
workspaces option active.
This file allows us to manage the gitlab permission responsibilities
between contributors and offers more granularity than the DOAP file.
This initial version includes the exact same information as the
gnome-control-center.doap file.
From now on, we could invite and add contributors that have expertize
in certain parts of the codebase and add them to this file. These
don't need to be made responsible for entire panels, but could be
specific to certain domain-specific files.
This was inspired by GLib's CODEOWNERS file
https://gitlab.gnome.org/GNOME/glib/-/blob/5803a248/docs/CODEOWNERS
The Apps panel now contains pages that used to be panels (Default
Apps and Removable Apps).
This POTFILES.in update allows for translators to translate the
strings in these files.
Currently setting's panel list is over-populated. We can fix this by
moving some of the settings inside other panels as sub-panels.
Created a new row in applications panel for removable media and
default apps. On selecting the row we show the respective settings
which is same as before.
Removed default app and removable media from sidebar
Closes: #1092#1096
Related to: #1090
As a part of moving removable media panel under applications, we create
a function `cc_removable_media_panel_new` which return a GtkWidget
that can be added to GtkStack inside applications panel.
This allows for local translation teams to change the presentation
format of the battery level percentage string accounting for local
guidelines and standards for displaying percentage values.
See https://en.wikipedia.org/wiki/Percent_sign#Correct_style for
more information.
Fixes#2637
This is the battery charge percentage. Showing number without a space
between the percent sign is the English style.
The ISO-31-0 standard prescribes a space between the number and the
percent sign.
See #2637